Hi Josh,
On 07/28/2014 07:04 PM, Josh Boyer wrote:
commit e6fe382d1d53d4cdf9b544729dc823d4eab0217c Author: Josh Boyer jwboyer@fedoraproject.org Date: Mon Jul 28 13:03:01 2014 -0400
Make sure acpi brightness_switch is disabled (like forever in Fedora) Upstream reverted the change to turn the ACPI brightness_switch_enabled parameter off by default. Revert the revert so we go back to the state Fedora has traditionally been in.
Ack, I was planning on doing this myself but you beat me to it, thanks for taking care of this.
Note that 3.17 will have this patch:
https://git.kernel.org/cgit/linux/kernel/git/rafael/linux-pm.git/commit/?h=l...
Which fixes the 2 steps being taken for one keypress problem while keeping the acpi brightness_switch behavior enabled, so that people who have an acpi-video controlled backlight and a userspace which does not do backlight control (e.g. windowmaker).
So for 3.17 we should IMHO drop the revert-revert and stick with upstream behavior.
Alternatively we could apply that patch now instead of the revert-revert.
Regards,
Hans
On Mon, Jul 28, 2014 at 2:12 PM, Hans de Goede hdegoede@redhat.com wrote:
Hi Josh,
On 07/28/2014 07:04 PM, Josh Boyer wrote:
commit e6fe382d1d53d4cdf9b544729dc823d4eab0217c Author: Josh Boyer jwboyer@fedoraproject.org Date: Mon Jul 28 13:03:01 2014 -0400
Make sure acpi brightness_switch is disabled (like forever in Fedora) Upstream reverted the change to turn the ACPI brightness_switch_enabled parameter off by default. Revert the revert so we go back to the state Fedora has traditionally been in.Ack, I was planning on doing this myself but you beat me to it, thanks for taking care of this.
Note that 3.17 will have this patch:
https://git.kernel.org/cgit/linux/kernel/git/rafael/linux-pm.git/commit/?h=l...
Which fixes the 2 steps being taken for one keypress problem while keeping the acpi brightness_switch behavior enabled, so that people who have an acpi-video controlled backlight and a userspace which does not do backlight control (e.g. windowmaker).
So for 3.17 we should IMHO drop the revert-revert and stick with upstream behavior.
OK.
Alternatively we could apply that patch now instead of the revert-revert.
I think we'll stick with the solution we know for 3.16 and leave 3.17 to work out any issues with the new approach.
Thanks.
josh
On Tue, Jul 29, 2014 at 8:35 AM, Josh Boyer jwboyer@fedoraproject.org wrote:
On Mon, Jul 28, 2014 at 2:12 PM, Hans de Goede hdegoede@redhat.com wrote:
Hi Josh,
On 07/28/2014 07:04 PM, Josh Boyer wrote:
commit e6fe382d1d53d4cdf9b544729dc823d4eab0217c Author: Josh Boyer jwboyer@fedoraproject.org Date: Mon Jul 28 13:03:01 2014 -0400
Make sure acpi brightness_switch is disabled (like forever in Fedora) Upstream reverted the change to turn the ACPI brightness_switch_enabled parameter off by default. Revert the revert so we go back to the state Fedora has traditionally been in.Ack, I was planning on doing this myself but you beat me to it, thanks for taking care of this.
Note that 3.17 will have this patch:
https://git.kernel.org/cgit/linux/kernel/git/rafael/linux-pm.git/commit/?h=l...
Which fixes the 2 steps being taken for one keypress problem while keeping the acpi brightness_switch behavior enabled, so that people who have an acpi-video controlled backlight and a userspace which does not do backlight control (e.g. windowmaker).
So for 3.17 we should IMHO drop the revert-revert and stick with upstream behavior.
OK.
Oops. The revert-revert patch was never actually dropped so long ago. So we're still defaulting the ACPI brightness_switch_enabled parameter off by default in Fedora.
If you still believe we should drop it, I can do so with the 4.2 kernels. Hopefully we've had enough time upstream to shake out any issues. I'd like confirmation before I do that though.
josh
Oops. The revert-revert patch was never actually dropped so long ago. So we're still defaulting the ACPI brightness_switch_enabled parameter off by default in Fedora.
If you still believe we should drop it, I can do so with the 4.2 kernels. Hopefully we've had enough time upstream to shake out any issues. I'd like confirmation before I do that though.
Just to be clear, because I am hopelessly confused, what will the dropping do. Have the ACPI brightness_switch_enabled parameter enabled by default? If so, I would like that.
Thanks, Ranjan
____________________________________________________________ Share photos & screenshots in seconds... TRY FREE IM TOOLPACK at http://www.imtoolpack.com/default.aspx?rc=if1 Works in all emails, instant messengers, blogs, forums and social networks.
On Wed, Jul 29, 2015 at 11:17 AM, Ranjan Maitra maitra.mbox.ignored@inbox.com wrote:
Oops. The revert-revert patch was never actually dropped so long ago. So we're still defaulting the ACPI brightness_switch_enabled parameter off by default in Fedora.
If you still believe we should drop it, I can do so with the 4.2 kernels. Hopefully we've had enough time upstream to shake out any issues. I'd like confirmation before I do that though.
Just to be clear, because I am hopelessly confused, what will the dropping do. Have the ACPI brightness_switch_enabled parameter enabled by default? If so, I would like that.
Yes.
josh
Hi,
On 29-07-15 17:17, Ranjan Maitra wrote:
Oops. The revert-revert patch was never actually dropped so long ago. So we're still defaulting the ACPI brightness_switch_enabled parameter off by default in Fedora.
If you still believe we should drop it, I can do so with the 4.2 kernels. Hopefully we've had enough time upstream to shake out any issues. I'd like confirmation before I do that though.
Just to be clear, because I am hopelessly confused, what will the dropping do. Have the ACPI brightness_switch_enabled parameter enabled by default? If so, I would like that.
Yes dropping the Fedora specific cause will make it enabled by default, relying on it is not a good idea though, as newer laptops use a different backlight driver which does not do this, responding to brightness keypresses should really be done by userspace.
If you rely on the brightness_switch_enabled=yes behavior, your workflow will likely break when you replace your laptop.
Regards,
Hans
Hi,
On 29-07-15 17:06, Josh Boyer wrote:
On Tue, Jul 29, 2014 at 8:35 AM, Josh Boyer jwboyer@fedoraproject.org wrote:
On Mon, Jul 28, 2014 at 2:12 PM, Hans de Goede hdegoede@redhat.com wrote:
Hi Josh,
On 07/28/2014 07:04 PM, Josh Boyer wrote:
commit e6fe382d1d53d4cdf9b544729dc823d4eab0217c Author: Josh Boyer jwboyer@fedoraproject.org Date: Mon Jul 28 13:03:01 2014 -0400
Make sure acpi brightness_switch is disabled (like forever in Fedora) Upstream reverted the change to turn the ACPI brightness_switch_enabled parameter off by default. Revert the revert so we go back to the state Fedora has traditionally been in.Ack, I was planning on doing this myself but you beat me to it, thanks for taking care of this.
Note that 3.17 will have this patch:
https://git.kernel.org/cgit/linux/kernel/git/rafael/linux-pm.git/commit/?h=l...
Which fixes the 2 steps being taken for one keypress problem while keeping the acpi brightness_switch behavior enabled, so that people who have an acpi-video controlled backlight and a userspace which does not do backlight control (e.g. windowmaker).
So for 3.17 we should IMHO drop the revert-revert and stick with upstream behavior.
OK.
Oops. The revert-revert patch was never actually dropped so long ago. So we're still defaulting the ACPI brightness_switch_enabled parameter off by default in Fedora.
If you still believe we should drop it
Yes I still believe we should drop it, the kernel has had a workaround for the double brightness changes this used to cause for quite some while now, and the closer to upstream we are the better IMHO.
Regards,
Hans
On Wed, Jul 29, 2015 at 11:19 AM, Hans de Goede hdegoede@redhat.com wrote:
Hi,
On 29-07-15 17:06, Josh Boyer wrote:
On Tue, Jul 29, 2014 at 8:35 AM, Josh Boyer jwboyer@fedoraproject.org wrote:
On Mon, Jul 28, 2014 at 2:12 PM, Hans de Goede hdegoede@redhat.com wrote:
Hi Josh,
On 07/28/2014 07:04 PM, Josh Boyer wrote:
commit e6fe382d1d53d4cdf9b544729dc823d4eab0217c Author: Josh Boyer jwboyer@fedoraproject.org Date: Mon Jul 28 13:03:01 2014 -0400
Make sure acpi brightness_switch is disabled (like forever inFedora)
Upstream reverted the change to turn the ACPIbrightness_switch_enabled parameter off by default. Revert the revert so we go back to the state Fedora has traditionally been in.
Ack, I was planning on doing this myself but you beat me to it, thanks for taking care of this.
Note that 3.17 will have this patch:
https://git.kernel.org/cgit/linux/kernel/git/rafael/linux-pm.git/commit/?h=l...
Which fixes the 2 steps being taken for one keypress problem while keeping the acpi brightness_switch behavior enabled, so that people who have an acpi-video controlled backlight and a userspace which does not do backlight control (e.g. windowmaker).
So for 3.17 we should IMHO drop the revert-revert and stick with upstream behavior.
OK.
Oops. The revert-revert patch was never actually dropped so long ago. So we're still defaulting the ACPI brightness_switch_enabled parameter off by default in Fedora.
If you still believe we should drop it
Yes I still believe we should drop it, the kernel has had a workaround for the double brightness changes this used to cause for quite some while now, and the closer to upstream we are the better IMHO.
I thought as much. I will do it today so it doesn't get forgotten again. Thank you.
josh
kernel@lists.fedoraproject.org
-
Hans de Goede -
Josh Boyer -
Ranjan Maitra