From: Fedora Kernel Team kernel-team@fedoraproject.org
Hi,
As part of the ongoing rebase effort, the following configuration options need to be reviewed.
As a reminder, the ARK configuration flow involves moving unreviewed configuration options from the pending directory to the ark directory. In the diff below, options are removed from the pending directory and added to the ark hierarchy. The final options that need to be ACKed are the files that are being added to the ark hierarchy.
If the value for a file that is added should be changed, please reply with a better option.
CONFIG_DEBUG_FS_ALLOW_ALL:
No restrictions apply. Both API and filesystem registration is on. This is the normal default operation.
Symbol: DEBUG_FS_ALLOW_ALL [=y] Type : bool Defined at lib/Kconfig.debug:500 Prompt: Access normal Depends on: <choice> Location: -> Kernel hacking -> Generic Kernel Debugging Instruments -> Debug Filesystem (DEBUG_FS [=y]) -> Debugfs default access (<choice> [=y])
---
CONFIG_DEBUG_FS_ALLOW_NONE:
Access is off. Clients get -PERM when trying to create nodes in debugfs tree and debugfs is not registered as a filesystem. Client can then back-off or continue without debugfs access.
Symbol: DEBUG_FS_ALLOW_NONE [=n] Type : bool Defined at lib/Kconfig.debug:513 Prompt: No access Depends on: <choice> Location: -> Kernel hacking -> Generic Kernel Debugging Instruments -> Debug Filesystem (DEBUG_FS [=y]) -> Debugfs default access (<choice> [=y])
---
CONFIG_DEBUG_FS_DISALLOW_MOUNT:
The API is open but filesystem is not loaded. Clients can still do their work and read with debug tools that do not need debugfs filesystem.
Symbol: DEBUG_FS_DISALLOW_MOUNT [=n] Type : bool Defined at lib/Kconfig.debug:506 Prompt: Do not register debugfs as filesystem Depends on: <choice> Location: -> Kernel hacking -> Generic Kernel Debugging Instruments -> Debug Filesystem (DEBUG_FS [=y]) -> Debugfs default access (<choice> [=y])
---
Signed-off-by: Fedora Kernel Team kernel-team@fedoraproject.org --- .../common/generic/CONFIG_DEBUG_FS_ALLOW_ALL | 1 + .../common/generic/CONFIG_DEBUG_FS_ALLOW_NONE | 1 + .../generic/CONFIG_DEBUG_FS_DISALLOW_MOUNT | 1 + .../generic/CONFIG_DEBUG_FS_ALLOW_ALL | 19 ------------------ .../generic/CONFIG_DEBUG_FS_ALLOW_NONE | 20 ------------------- .../generic/CONFIG_DEBUG_FS_DISALLOW_MOUNT | 20 ------------------- 6 files changed, 3 insertions(+), 59 deletions(-) create mode 100644 redhat/configs/common/generic/CONFIG_DEBUG_FS_ALLOW_ALL create mode 100644 redhat/configs/common/generic/CONFIG_DEBUG_FS_ALLOW_NONE create mode 100644 redhat/configs/common/generic/CONFIG_DEBUG_FS_DISALLOW_MOUNT delete mode 100644 redhat/configs/pending-common/generic/CONFIG_DEBUG_FS_ALLOW_ALL delete mode 100644 redhat/configs/pending-common/generic/CONFIG_DEBUG_FS_ALLOW_NONE delete mode 100644 redhat/configs/pending-common/generic/CONFIG_DEBUG_FS_DISALLOW_MOUNT
diff --git a/redhat/configs/common/generic/CONFIG_DEBUG_FS_ALLOW_ALL b/redhat/configs/common/generic/CONFIG_DEBUG_FS_ALLOW_ALL new file mode 100644 index 000000000000..69490c3a53d5 --- /dev/null +++ b/redhat/configs/common/generic/CONFIG_DEBUG_FS_ALLOW_ALL @@ -0,0 +1 @@ +CONFIG_DEBUG_FS_ALLOW_ALL=y diff --git a/redhat/configs/common/generic/CONFIG_DEBUG_FS_ALLOW_NONE b/redhat/configs/common/generic/CONFIG_DEBUG_FS_ALLOW_NONE new file mode 100644 index 000000000000..2d2a249b14c9 --- /dev/null +++ b/redhat/configs/common/generic/CONFIG_DEBUG_FS_ALLOW_NONE @@ -0,0 +1 @@ +# CONFIG_DEBUG_FS_ALLOW_NONE is not set diff --git a/redhat/configs/common/generic/CONFIG_DEBUG_FS_DISALLOW_MOUNT b/redhat/configs/common/generic/CONFIG_DEBUG_FS_DISALLOW_MOUNT new file mode 100644 index 000000000000..d70cb272a100 --- /dev/null +++ b/redhat/configs/common/generic/CONFIG_DEBUG_FS_DISALLOW_MOUNT @@ -0,0 +1 @@ +# CONFIG_DEBUG_FS_DISALLOW_MOUNT is not set diff --git a/redhat/configs/pending-common/generic/CONFIG_DEBUG_FS_ALLOW_ALL b/redhat/configs/pending-common/generic/CONFIG_DEBUG_FS_ALLOW_ALL deleted file mode 100644 index 083ba7cb0dd7..000000000000 --- a/redhat/configs/pending-common/generic/CONFIG_DEBUG_FS_ALLOW_ALL +++ /dev/null @@ -1,19 +0,0 @@ -# CONFIG_DEBUG_FS_ALLOW_ALL: -# -# No restrictions apply. Both API and filesystem registration -# is on. This is the normal default operation. -# -# Symbol: DEBUG_FS_ALLOW_ALL [=y] -# Type : bool -# Defined at lib/Kconfig.debug:500 -# Prompt: Access normal -# Depends on: <choice> -# Location: -# -> Kernel hacking -# -> Generic Kernel Debugging Instruments -# -> Debug Filesystem (DEBUG_FS [=y]) -# -> Debugfs default access (<choice> [=y]) -# -# -# -CONFIG_DEBUG_FS_ALLOW_ALL=y diff --git a/redhat/configs/pending-common/generic/CONFIG_DEBUG_FS_ALLOW_NONE b/redhat/configs/pending-common/generic/CONFIG_DEBUG_FS_ALLOW_NONE deleted file mode 100644 index f61111aac6c0..000000000000 --- a/redhat/configs/pending-common/generic/CONFIG_DEBUG_FS_ALLOW_NONE +++ /dev/null @@ -1,20 +0,0 @@ -# CONFIG_DEBUG_FS_ALLOW_NONE: -# -# Access is off. Clients get -PERM when trying to create nodes in -# debugfs tree and debugfs is not registered as a filesystem. -# Client can then back-off or continue without debugfs access. -# -# Symbol: DEBUG_FS_ALLOW_NONE [=n] -# Type : bool -# Defined at lib/Kconfig.debug:513 -# Prompt: No access -# Depends on: <choice> -# Location: -# -> Kernel hacking -# -> Generic Kernel Debugging Instruments -# -> Debug Filesystem (DEBUG_FS [=y]) -# -> Debugfs default access (<choice> [=y]) -# -# -# -# CONFIG_DEBUG_FS_ALLOW_NONE is not set diff --git a/redhat/configs/pending-common/generic/CONFIG_DEBUG_FS_DISALLOW_MOUNT b/redhat/configs/pending-common/generic/CONFIG_DEBUG_FS_DISALLOW_MOUNT deleted file mode 100644 index 270523a0536d..000000000000 --- a/redhat/configs/pending-common/generic/CONFIG_DEBUG_FS_DISALLOW_MOUNT +++ /dev/null @@ -1,20 +0,0 @@ -# CONFIG_DEBUG_FS_DISALLOW_MOUNT: -# -# The API is open but filesystem is not loaded. Clients can still do -# their work and read with debug tools that do not need -# debugfs filesystem. -# -# Symbol: DEBUG_FS_DISALLOW_MOUNT [=n] -# Type : bool -# Defined at lib/Kconfig.debug:506 -# Prompt: Do not register debugfs as filesystem -# Depends on: <choice> -# Location: -# -> Kernel hacking -# -> Generic Kernel Debugging Instruments -# -> Debug Filesystem (DEBUG_FS [=y]) -# -> Debugfs default access (<choice> [=y]) -# -# -# -# CONFIG_DEBUG_FS_DISALLOW_MOUNT is not set
On 8/12/20 8:57 PM, GitLab Bridge on behalf of jeremycline wrote:
From: Fedora Kernel Team kernel-team@fedoraproject.org
Hi,
As part of the ongoing rebase effort, the following configuration options need to be reviewed.
As a reminder, the ARK configuration flow involves moving unreviewed configuration options from the pending directory to the ark directory. In the diff below, options are removed from the pending directory and added to the ark hierarchy. The final options that need to be ACKed are the files that are being added to the ark hierarchy.
If the value for a file that is added should be changed, please reply with a better option.
CONFIG_DEBUG_FS_ALLOW_ALL:
No restrictions apply. Both API and filesystem registration is on. This is the normal default operation.
Symbol: DEBUG_FS_ALLOW_ALL [=y] Type : bool Defined at lib/Kconfig.debug:500 Prompt: Access normal Depends on: <choice> Location: -> Kernel hacking -> Generic Kernel Debugging Instruments -> Debug Filesystem (DEBUG_FS [=y]) -> Debugfs default access (<choice> [=y])
We want this ^^ to be 'y'.
CONFIG_DEBUG_FS_ALLOW_NONE:
Access is off. Clients get -PERM when trying to create nodes in debugfs tree and debugfs is not registered as a filesystem. Client can then back-off or continue without debugfs access.
Symbol: DEBUG_FS_ALLOW_NONE [=n] Type : bool Defined at lib/Kconfig.debug:513 Prompt: No access Depends on: <choice> Location: -> Kernel hacking -> Generic Kernel Debugging Instruments -> Debug Filesystem (DEBUG_FS [=y]) -> Debugfs default access (<choice> [=y])
CONFIG_DEBUG_FS_DISALLOW_MOUNT:
The API is open but filesystem is not loaded. Clients can still do their work and read with debug tools that do not need debugfs filesystem.
Symbol: DEBUG_FS_DISALLOW_MOUNT [=n] Type : bool Defined at lib/Kconfig.debug:506 Prompt: Do not register debugfs as filesystem Depends on: <choice> Location: -> Kernel hacking -> Generic Kernel Debugging Instruments -> Debug Filesystem (DEBUG_FS [=y]) -> Debugfs default access (<choice> [=y])
These last two should be 'is not set' on the base kernel, and 'y' on debug kernels.
Nacked-by: Prarit Bhargava prarit@redhat.com
P.
Signed-off-by: Fedora Kernel Team kernel-team@fedoraproject.org
.../common/generic/CONFIG_DEBUG_FS_ALLOW_ALL | 1 + .../common/generic/CONFIG_DEBUG_FS_ALLOW_NONE | 1 + .../generic/CONFIG_DEBUG_FS_DISALLOW_MOUNT | 1 + .../generic/CONFIG_DEBUG_FS_ALLOW_ALL | 19 ------------------ .../generic/CONFIG_DEBUG_FS_ALLOW_NONE | 20 ------------------- .../generic/CONFIG_DEBUG_FS_DISALLOW_MOUNT | 20 ------------------- 6 files changed, 3 insertions(+), 59 deletions(-) create mode 100644 redhat/configs/common/generic/CONFIG_DEBUG_FS_ALLOW_ALL create mode 100644 redhat/configs/common/generic/CONFIG_DEBUG_FS_ALLOW_NONE create mode 100644 redhat/configs/common/generic/CONFIG_DEBUG_FS_DISALLOW_MOUNT delete mode 100644
redhat/configs/pending-common/generic/CONFIG_DEBUG_FS_ALLOW_ALL
delete mode 100644
redhat/configs/pending-common/generic/CONFIG_DEBUG_FS_ALLOW_NONE
delete mode 100644
redhat/configs/pending-common/generic/CONFIG_DEBUG_FS_DISALLOW_MOUNT
diff --git a/redhat/configs/common/generic/CONFIG_DEBUG_FS_ALLOW_ALL
b/redhat/configs/common/generic/CONFIG_DEBUG_FS_ALLOW_ALL
new file mode 100644 index 000000000000..69490c3a53d5 --- /dev/null +++ b/redhat/configs/common/generic/CONFIG_DEBUG_FS_ALLOW_ALL @@ -0,0 +1 @@ +CONFIG_DEBUG_FS_ALLOW_ALL=y diff --git a/redhat/configs/common/generic/CONFIG_DEBUG_FS_ALLOW_NONE
b/redhat/configs/common/generic/CONFIG_DEBUG_FS_ALLOW_NONE
new file mode 100644 index 000000000000..2d2a249b14c9 --- /dev/null +++ b/redhat/configs/common/generic/CONFIG_DEBUG_FS_ALLOW_NONE @@ -0,0 +1 @@ +# CONFIG_DEBUG_FS_ALLOW_NONE is not set diff --git a/redhat/configs/common/generic/CONFIG_DEBUG_FS_DISALLOW_MOUNT
b/redhat/configs/common/generic/CONFIG_DEBUG_FS_DISALLOW_MOUNT
new file mode 100644 index 000000000000..d70cb272a100 --- /dev/null +++ b/redhat/configs/common/generic/CONFIG_DEBUG_FS_DISALLOW_MOUNT @@ -0,0 +1 @@ +# CONFIG_DEBUG_FS_DISALLOW_MOUNT is not set diff --git a/redhat/configs/pending-common/generic/CONFIG_DEBUG_FS_ALLOW_ALL
b/redhat/configs/pending-common/generic/CONFIG_DEBUG_FS_ALLOW_ALL
deleted file mode 100644 index 083ba7cb0dd7..000000000000 --- a/redhat/configs/pending-common/generic/CONFIG_DEBUG_FS_ALLOW_ALL +++ /dev/null @@ -1,19 +0,0 @@ -# CONFIG_DEBUG_FS_ALLOW_ALL: -# -# No restrictions apply. Both API and filesystem registration -# is on. This is the normal default operation. -# -# Symbol: DEBUG_FS_ALLOW_ALL [=y] -# Type : bool -# Defined at lib/Kconfig.debug:500 -# Prompt: Access normal -# Depends on: <choice> -# Location: -# -> Kernel hacking -# -> Generic Kernel Debugging Instruments -# -> Debug Filesystem (DEBUG_FS [=y]) -# -> Debugfs default access (<choice> [=y]) -# -# -# -CONFIG_DEBUG_FS_ALLOW_ALL=y diff --git a/redhat/configs/pending-common/generic/CONFIG_DEBUG_FS_ALLOW_NONE
b/redhat/configs/pending-common/generic/CONFIG_DEBUG_FS_ALLOW_NONE
deleted file mode 100644 index f61111aac6c0..000000000000 --- a/redhat/configs/pending-common/generic/CONFIG_DEBUG_FS_ALLOW_NONE +++ /dev/null @@ -1,20 +0,0 @@ -# CONFIG_DEBUG_FS_ALLOW_NONE: -# -# Access is off. Clients get -PERM when trying to create nodes in -# debugfs tree and debugfs is not registered as a filesystem. -# Client can then back-off or continue without debugfs access. -# -# Symbol: DEBUG_FS_ALLOW_NONE [=n] -# Type : bool -# Defined at lib/Kconfig.debug:513 -# Prompt: No access -# Depends on: <choice> -# Location: -# -> Kernel hacking -# -> Generic Kernel Debugging Instruments -# -> Debug Filesystem (DEBUG_FS [=y]) -# -> Debugfs default access (<choice> [=y]) -# -# -# -# CONFIG_DEBUG_FS_ALLOW_NONE is not set diff --git
a/redhat/configs/pending-common/generic/CONFIG_DEBUG_FS_DISALLOW_MOUNT b/redhat/configs/pending-common/generic/CONFIG_DEBUG_FS_DISALLOW_MOUNT
deleted file mode 100644 index 270523a0536d..000000000000 --- a/redhat/configs/pending-common/generic/CONFIG_DEBUG_FS_DISALLOW_MOUNT +++ /dev/null @@ -1,20 +0,0 @@ -# CONFIG_DEBUG_FS_DISALLOW_MOUNT: -# -# The API is open but filesystem is not loaded. Clients can still do -# their work and read with debug tools that do not need -# debugfs filesystem. -# -# Symbol: DEBUG_FS_DISALLOW_MOUNT [=n] -# Type : bool -# Defined at lib/Kconfig.debug:506 -# Prompt: Do not register debugfs as filesystem -# Depends on: <choice> -# Location: -# -> Kernel hacking -# -> Generic Kernel Debugging Instruments -# -> Debug Filesystem (DEBUG_FS [=y]) -# -> Debugfs default access (<choice> [=y]) -# -# -# -# CONFIG_DEBUG_FS_DISALLOW_MOUNT is not set
From: Fedora Kernel Team kernel-team@fedoraproject.org
Hi,
As part of the ongoing rebase effort, the following configuration options need to be reviewed.
As a reminder, the ARK configuration flow involves moving unreviewed configuration options from the pending directory to the ark directory. In the diff below, options are removed from the pending directory and added to the ark hierarchy. The final options that need to be ACKed are the files that are being added to the ark hierarchy.
If the value for a file that is added should be changed, please reply with a better option.
CONFIG_DEBUG_FS_ALLOW_ALL:
No restrictions apply. Both API and filesystem registration is on. This is the normal default operation.
Symbol: DEBUG_FS_ALLOW_ALL [=y] Type : bool Defined at lib/Kconfig.debug:500 Prompt: Access normal Depends on: <choice> Location: -> Kernel hacking -> Generic Kernel Debugging Instruments -> Debug Filesystem (DEBUG_FS [=y]) -> Debugfs default access (<choice> [=y])
Cc: Prarit Bhargava prarit@redhat.com --- .../common/generic/CONFIG_DEBUG_FS_ALLOW_ALL | 1 + .../common/generic/CONFIG_DEBUG_FS_ALLOW_NONE | 1 + .../generic/CONFIG_DEBUG_FS_DISALLOW_MOUNT | 1 + .../generic/CONFIG_DEBUG_FS_ALLOW_ALL | 19 ------------------ .../generic/CONFIG_DEBUG_FS_ALLOW_NONE | 20 ------------------- .../generic/CONFIG_DEBUG_FS_DISALLOW_MOUNT | 20 ------------------- 6 files changed, 3 insertions(+), 59 deletions(-) create mode 100644 redhat/configs/common/generic/CONFIG_DEBUG_FS_ALLOW_ALL create mode 100644 redhat/configs/common/generic/CONFIG_DEBUG_FS_ALLOW_NONE create mode 100644 redhat/configs/common/generic/CONFIG_DEBUG_FS_DISALLOW_MOUNT delete mode 100644 redhat/configs/pending-common/generic/CONFIG_DEBUG_FS_ALLOW_ALL delete mode 100644 redhat/configs/pending-common/generic/CONFIG_DEBUG_FS_ALLOW_NONE delete mode 100644 redhat/configs/pending-common/generic/CONFIG_DEBUG_FS_DISALLOW_MOUNT
diff --git a/redhat/configs/common/generic/CONFIG_DEBUG_FS_ALLOW_ALL b/redhat/configs/common/generic/CONFIG_DEBUG_FS_ALLOW_ALL new file mode 100644 index 000000000000..69490c3a53d5 --- /dev/null +++ b/redhat/configs/common/generic/CONFIG_DEBUG_FS_ALLOW_ALL @@ -0,0 +1 @@ +CONFIG_DEBUG_FS_ALLOW_ALL=y diff --git a/redhat/configs/common/generic/CONFIG_DEBUG_FS_ALLOW_NONE b/redhat/configs/common/generic/CONFIG_DEBUG_FS_ALLOW_NONE new file mode 100644 index 000000000000..2d2a249b14c9 --- /dev/null +++ b/redhat/configs/common/generic/CONFIG_DEBUG_FS_ALLOW_NONE @@ -0,0 +1 @@ +# CONFIG_DEBUG_FS_ALLOW_NONE is not set diff --git a/redhat/configs/common/generic/CONFIG_DEBUG_FS_DISALLOW_MOUNT b/redhat/configs/common/generic/CONFIG_DEBUG_FS_DISALLOW_MOUNT new file mode 100644 index 000000000000..d70cb272a100 --- /dev/null +++ b/redhat/configs/common/generic/CONFIG_DEBUG_FS_DISALLOW_MOUNT @@ -0,0 +1 @@ +# CONFIG_DEBUG_FS_DISALLOW_MOUNT is not set diff --git a/redhat/configs/pending-common/generic/CONFIG_DEBUG_FS_ALLOW_ALL b/redhat/configs/pending-common/generic/CONFIG_DEBUG_FS_ALLOW_ALL deleted file mode 100644 index 083ba7cb0dd7..000000000000 --- a/redhat/configs/pending-common/generic/CONFIG_DEBUG_FS_ALLOW_ALL +++ /dev/null @@ -1,19 +0,0 @@ -# CONFIG_DEBUG_FS_ALLOW_ALL: -# -# No restrictions apply. Both API and filesystem registration -# is on. This is the normal default operation. -# -# Symbol: DEBUG_FS_ALLOW_ALL [=y] -# Type : bool -# Defined at lib/Kconfig.debug:500 -# Prompt: Access normal -# Depends on: <choice> -# Location: -# -> Kernel hacking -# -> Generic Kernel Debugging Instruments -# -> Debug Filesystem (DEBUG_FS [=y]) -# -> Debugfs default access (<choice> [=y]) -# -# -# -CONFIG_DEBUG_FS_ALLOW_ALL=y diff --git a/redhat/configs/pending-common/generic/CONFIG_DEBUG_FS_ALLOW_NONE b/redhat/configs/pending-common/generic/CONFIG_DEBUG_FS_ALLOW_NONE deleted file mode 100644 index f61111aac6c0..000000000000 --- a/redhat/configs/pending-common/generic/CONFIG_DEBUG_FS_ALLOW_NONE +++ /dev/null @@ -1,20 +0,0 @@ -# CONFIG_DEBUG_FS_ALLOW_NONE: -# -# Access is off. Clients get -PERM when trying to create nodes in -# debugfs tree and debugfs is not registered as a filesystem. -# Client can then back-off or continue without debugfs access. -# -# Symbol: DEBUG_FS_ALLOW_NONE [=n] -# Type : bool -# Defined at lib/Kconfig.debug:513 -# Prompt: No access -# Depends on: <choice> -# Location: -# -> Kernel hacking -# -> Generic Kernel Debugging Instruments -# -> Debug Filesystem (DEBUG_FS [=y]) -# -> Debugfs default access (<choice> [=y]) -# -# -# -# CONFIG_DEBUG_FS_ALLOW_NONE is not set diff --git a/redhat/configs/pending-common/generic/CONFIG_DEBUG_FS_DISALLOW_MOUNT b/redhat/configs/pending-common/generic/CONFIG_DEBUG_FS_DISALLOW_MOUNT deleted file mode 100644 index 270523a0536d..000000000000 --- a/redhat/configs/pending-common/generic/CONFIG_DEBUG_FS_DISALLOW_MOUNT +++ /dev/null @@ -1,20 +0,0 @@ -# CONFIG_DEBUG_FS_DISALLOW_MOUNT: -# -# The API is open but filesystem is not loaded. Clients can still do -# their work and read with debug tools that do not need -# debugfs filesystem. -# -# Symbol: DEBUG_FS_DISALLOW_MOUNT [=n] -# Type : bool -# Defined at lib/Kconfig.debug:506 -# Prompt: Do not register debugfs as filesystem -# Depends on: <choice> -# Location: -# -> Kernel hacking -# -> Generic Kernel Debugging Instruments -# -> Debug Filesystem (DEBUG_FS [=y]) -# -> Debugfs default access (<choice> [=y]) -# -# -# -# CONFIG_DEBUG_FS_DISALLOW_MOUNT is not set
On 9/30/20 9:39 AM, GitLab Bridge on behalf of jeremycline wrote:
From: Fedora Kernel Team kernel-team@fedoraproject.org
Hi,
As part of the ongoing rebase effort, the following configuration options need to be reviewed.
As a reminder, the ARK configuration flow involves moving unreviewed configuration options from the pending directory to the ark directory. In the diff below, options are removed from the pending directory and added to the ark hierarchy. The final options that need to be ACKed are the files that are being added to the ark hierarchy.
If the value for a file that is added should be changed, please reply with a better option.
CONFIG_DEBUG_FS_ALLOW_ALL:
No restrictions apply. Both API and filesystem registration is on. This is the normal default operation.
Symbol: DEBUG_FS_ALLOW_ALL [=y] Type : bool Defined at lib/Kconfig.debug:500 Prompt: Access normal Depends on: <choice> Location: -> Kernel hacking -> Generic Kernel Debugging Instruments -> Debug Filesystem (DEBUG_FS [=y]) -> Debugfs default access (<choice> [=y])
Cc: Prarit Bhargava prarit@redhat.com
We definitely want this one on.
Acked-by: Prarit Bhargava prarit@redhat.com
P.
From: Fedora Kernel Team kernel-team@fedoraproject.org
New configs in lib/Kconfig.debug
Hi,
As part of the ongoing rebase effort, the following configuration options need to be reviewed.
As a reminder, the ARK configuration flow involves moving unreviewed configuration options from the pending directory to the ark directory. In the diff below, options are removed from the pending directory and added to the ark hierarchy. The final options that need to be ACKed are the files that are being added to the ark hierarchy.
If the value for a file that is added should be changed, please reply with a better option.
CONFIG_DEBUG_FS_ALLOW_ALL:
No restrictions apply. Both API and filesystem registration is on. This is the normal default operation.
Symbol: DEBUG_FS_ALLOW_ALL [=y] Type : bool Defined at lib/Kconfig.debug:500 Prompt: Access normal Depends on: <choice> Location: -> Kernel hacking -> Generic Kernel Debugging Instruments -> Debug Filesystem (DEBUG_FS [=y]) -> Debugfs default access (<choice> [=y])
Cc: Prarit Bhargava prarit@redhat.com
diff a/redhat/configs/common/generic/CONFIG_DEBUG_FS_ALLOW_ALL b/redhat/configs/common/generic/CONFIG_DEBUG_FS_ALLOW_ALL --- /dev/null +++ b/redhat/configs/common/generic/CONFIG_DEBUG_FS_ALLOW_ALL @@ -0,0 +1 @@ +CONFIG_DEBUG_FS_ALLOW_ALL=y diff a/redhat/configs/common/generic/CONFIG_DEBUG_FS_ALLOW_NONE b/redhat/configs/common/generic/CONFIG_DEBUG_FS_ALLOW_NONE --- /dev/null +++ b/redhat/configs/common/generic/CONFIG_DEBUG_FS_ALLOW_NONE @@ -0,0 +1 @@ +# CONFIG_DEBUG_FS_ALLOW_NONE is not set diff a/redhat/configs/common/generic/CONFIG_DEBUG_FS_DISALLOW_MOUNT b/redhat/configs/common/generic/CONFIG_DEBUG_FS_DISALLOW_MOUNT --- /dev/null +++ b/redhat/configs/common/generic/CONFIG_DEBUG_FS_DISALLOW_MOUNT @@ -0,0 +1 @@ +# CONFIG_DEBUG_FS_DISALLOW_MOUNT is not set diff a/redhat/configs/pending-common/generic/CONFIG_DEBUG_FS_ALLOW_ALL b/redhat/configs/pending-common/generic/CONFIG_DEBUG_FS_ALLOW_ALL --- a/redhat/configs/pending-common/generic/CONFIG_DEBUG_FS_ALLOW_ALL +++ /dev/null @@ -1,19 +0,0 @@ -# CONFIG_DEBUG_FS_ALLOW_ALL: -# -# No restrictions apply. Both API and filesystem registration -# is on. This is the normal default operation. -# -# Symbol: DEBUG_FS_ALLOW_ALL [=y] -# Type : bool -# Defined at lib/Kconfig.debug:500 -# Prompt: Access normal -# Depends on: <choice> -# Location: -# -> Kernel hacking -# -> Generic Kernel Debugging Instruments -# -> Debug Filesystem (DEBUG_FS [=y]) -# -> Debugfs default access (<choice> [=y]) -# -# -# -CONFIG_DEBUG_FS_ALLOW_ALL=y diff a/redhat/configs/pending-common/generic/CONFIG_DEBUG_FS_ALLOW_NONE b/redhat/configs/pending-common/generic/CONFIG_DEBUG_FS_ALLOW_NONE --- a/redhat/configs/pending-common/generic/CONFIG_DEBUG_FS_ALLOW_NONE +++ /dev/null @@ -1,20 +0,0 @@ -# CONFIG_DEBUG_FS_ALLOW_NONE: -# -# Access is off. Clients get -PERM when trying to create nodes in -# debugfs tree and debugfs is not registered as a filesystem. -# Client can then back-off or continue without debugfs access. -# -# Symbol: DEBUG_FS_ALLOW_NONE [=n] -# Type : bool -# Defined at lib/Kconfig.debug:513 -# Prompt: No access -# Depends on: <choice> -# Location: -# -> Kernel hacking -# -> Generic Kernel Debugging Instruments -# -> Debug Filesystem (DEBUG_FS [=y]) -# -> Debugfs default access (<choice> [=y]) -# -# -# -# CONFIG_DEBUG_FS_ALLOW_NONE is not set diff a/redhat/configs/pending-common/generic/CONFIG_DEBUG_FS_DISALLOW_MOUNT b/redhat/configs/pending-common/generic/CONFIG_DEBUG_FS_DISALLOW_MOUNT --- a/redhat/configs/pending-common/generic/CONFIG_DEBUG_FS_DISALLOW_MOUNT +++ /dev/null @@ -1,20 +0,0 @@ -# CONFIG_DEBUG_FS_DISALLOW_MOUNT: -# -# The API is open but filesystem is not loaded. Clients can still do -# their work and read with debug tools that do not need -# debugfs filesystem. -# -# Symbol: DEBUG_FS_DISALLOW_MOUNT [=n] -# Type : bool -# Defined at lib/Kconfig.debug:506 -# Prompt: Do not register debugfs as filesystem -# Depends on: <choice> -# Location: -# -> Kernel hacking -# -> Generic Kernel Debugging Instruments -# -> Debug Filesystem (DEBUG_FS [=y]) -# -> Debugfs default access (<choice> [=y]) -# -# -# -# CONFIG_DEBUG_FS_DISALLOW_MOUNT is not set
-- https://gitlab.com/cki-project/kernel-ark/-/merge_requests/580
From: CKI Admin Bot on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/580#note_49419319...
Hi! This is the friendly CKI test bot.
It appears that you are not a member of redhat/red-hat-ci- tools/kernel/cki-runs/trusted-pipelines. This means that the CI pipeline on your MR will fail. As getting testing is important, I'll be responsible for testing your changes. After every MR change, I'll start a small testing pipeline and link it here so you can follow the results. I'll also create and link a pipeline for hardware testing that the reviewers can start to get extra test coverage.
From: CKI Admin Bot on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/580#note_49419323...
Testing pipeline status: Basic testing pipeline:
https://gitlab.com/redhat/red-hat-ci-tools/kernel/cki- runs/external-pipelines/-/pipelines/247001538 - created :hourglass_flowing_sand:
From: CKI Bot on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/580#note_49625923...
Acked-by: Prarit Bhargava prarit@redhat.com (via approve button)
kernel@lists.fedoraproject.org
-
cki-gitlab＠redhat.com -
GitLab Bridge on behalf of jeremycline
-
GitLab Bridge on behalf of jeremycline -
Jeremy Cline (via Email Bridge)
-
Prarit Bhargava