From: Fedora Kernel Team kernel-team@fedoraproject.org
Hi,
As part of the ongoing rebase effort, the following configuration options need to be reviewed.
As a reminder, the ARK configuration flow involves moving unreviewed configuration options from the pending directory to the ark directory. In the diff below, options are removed from the pending directory and added to the ark hierarchy. The final options that need to be ACKed are the files that are being added to the ark hierarchy.
If the value for a file that is added should be changed, please reply with a better option.
CONFIG_DRM_AMD_DC_DCN3_0:
Choose this option if you want to have sienna_cichlid support for display engine
Symbol: DRM_AMD_DC_DCN3_0 [=n] Type : bool Defined at drivers/gpu/drm/amd/display/Kconfig:20 Prompt: DCN 3.0 family Depends on: HAS_IOMEM [=y] && DRM [=m] && DRM_AMDGPU [=m] && DRM_AMD_DC [=y] && X86 [=y] && DRM_AMD_DC_DCN [=y] Location: -> Device Drivers -> Graphics support -> AMD GPU (DRM_AMDGPU [=m]) -> Display Engine Configuration
---
CONFIG_NOUVEAU_DEBUG_PUSH:
Say Y here if you want to enable verbose push buffer debug output and sanity checks.
Symbol: NOUVEAU_DEBUG_PUSH [=n] Type : bool Defined at drivers/gpu/drm/nouveau/Kconfig:79 Prompt: Enable additional push buffer debugging Depends on: HAS_IOMEM [=y] && DRM_NOUVEAU [=m] Location: -> Device Drivers -> Graphics support -> Nouveau (NVIDIA) cards (DRM_NOUVEAU [=m])
---
Cc: David Airlie airlied@redhat.com Cc: Adam Jackson ajax@redhat.com Signed-off-by: Fedora Kernel Team kernel-team@fedoraproject.org --- .../common/generic/CONFIG_DRM_AMD_DC_DCN3_0 | 1 + .../common/generic/CONFIG_NOUVEAU_DEBUG_PUSH | 1 + .../generic/CONFIG_DRM_AMD_DC_DCN3_0 | 19 ------------------- .../generic/CONFIG_NOUVEAU_DEBUG_PUSH | 18 ------------------ 4 files changed, 2 insertions(+), 37 deletions(-) create mode 100644 redhat/configs/common/generic/CONFIG_DRM_AMD_DC_DCN3_0 create mode 100644 redhat/configs/common/generic/CONFIG_NOUVEAU_DEBUG_PUSH delete mode 100644 redhat/configs/pending-common/generic/CONFIG_DRM_AMD_DC_DCN3_0 delete mode 100644 redhat/configs/pending-common/generic/CONFIG_NOUVEAU_DEBUG_PUSH
diff --git a/redhat/configs/common/generic/CONFIG_DRM_AMD_DC_DCN3_0 b/redhat/configs/common/generic/CONFIG_DRM_AMD_DC_DCN3_0 new file mode 100644 index 000000000000..708bd22e809e --- /dev/null +++ b/redhat/configs/common/generic/CONFIG_DRM_AMD_DC_DCN3_0 @@ -0,0 +1 @@ +# CONFIG_DRM_AMD_DC_DCN3_0 is not set diff --git a/redhat/configs/common/generic/CONFIG_NOUVEAU_DEBUG_PUSH b/redhat/configs/common/generic/CONFIG_NOUVEAU_DEBUG_PUSH new file mode 100644 index 000000000000..5614c2c49809 --- /dev/null +++ b/redhat/configs/common/generic/CONFIG_NOUVEAU_DEBUG_PUSH @@ -0,0 +1 @@ +# CONFIG_NOUVEAU_DEBUG_PUSH is not set diff --git a/redhat/configs/pending-common/generic/CONFIG_DRM_AMD_DC_DCN3_0 b/redhat/configs/pending-common/generic/CONFIG_DRM_AMD_DC_DCN3_0 deleted file mode 100644 index f6a3c764772e..000000000000 --- a/redhat/configs/pending-common/generic/CONFIG_DRM_AMD_DC_DCN3_0 +++ /dev/null @@ -1,19 +0,0 @@ -# CONFIG_DRM_AMD_DC_DCN3_0: -# -# Choose this option if you want to have -# sienna_cichlid support for display engine -# -# Symbol: DRM_AMD_DC_DCN3_0 [=n] -# Type : bool -# Defined at drivers/gpu/drm/amd/display/Kconfig:20 -# Prompt: DCN 3.0 family -# Depends on: HAS_IOMEM [=y] && DRM [=m] && DRM_AMDGPU [=m] && DRM_AMD_DC [=y] && X86 [=y] && DRM_AMD_DC_DCN [=y] -# Location: -# -> Device Drivers -# -> Graphics support -# -> AMD GPU (DRM_AMDGPU [=m]) -# -> Display Engine Configuration -# -# -# -# CONFIG_DRM_AMD_DC_DCN3_0 is not set diff --git a/redhat/configs/pending-common/generic/CONFIG_NOUVEAU_DEBUG_PUSH b/redhat/configs/pending-common/generic/CONFIG_NOUVEAU_DEBUG_PUSH deleted file mode 100644 index c28eaf703375..000000000000 --- a/redhat/configs/pending-common/generic/CONFIG_NOUVEAU_DEBUG_PUSH +++ /dev/null @@ -1,18 +0,0 @@ -# CONFIG_NOUVEAU_DEBUG_PUSH: -# -# Say Y here if you want to enable verbose push buffer debug output -# and sanity checks. -# -# Symbol: NOUVEAU_DEBUG_PUSH [=n] -# Type : bool -# Defined at drivers/gpu/drm/nouveau/Kconfig:79 -# Prompt: Enable additional push buffer debugging -# Depends on: HAS_IOMEM [=y] && DRM_NOUVEAU [=m] -# Location: -# -> Device Drivers -# -> Graphics support -# -> Nouveau (NVIDIA) cards (DRM_NOUVEAU [=m]) -# -# -# -# CONFIG_NOUVEAU_DEBUG_PUSH is not set
On Thu, Aug 13, 2020 at 10:57 AM GitLab Bridge on behalf of jeremycline jcline@redhat.com wrote:
From: Fedora Kernel Team kernel-team@fedoraproject.org
Hi,
As part of the ongoing rebase effort, the following configuration options need to be reviewed.
As a reminder, the ARK configuration flow involves moving unreviewed configuration options from the pending directory to the ark directory. In the diff below, options are removed from the pending directory and added to the ark hierarchy. The final options that need to be ACKed are the files that are being added to the ark hierarchy.
If the value for a file that is added should be changed, please reply with a better option.
CONFIG_DRM_AMD_DC_DCN3_0:
Please enable this one. the rest are fine.
Choose this option if you want to have sienna_cichlid support for display engine
Symbol: DRM_AMD_DC_DCN3_0 [=n] Type : bool Defined at drivers/gpu/drm/amd/display/Kconfig:20 Prompt: DCN 3.0 family Depends on: HAS_IOMEM [=y] && DRM [=m] && DRM_AMDGPU [=m] && DRM_AMD_DC [=y] && X86 [=y] && DRM_AMD_DC_DCN [=y] Location: -> Device Drivers -> Graphics support -> AMD GPU (DRM_AMDGPU [=m]) -> Display Engine Configuration
CONFIG_NOUVEAU_DEBUG_PUSH:
Say Y here if you want to enable verbose push buffer debug output and sanity checks.
Symbol: NOUVEAU_DEBUG_PUSH [=n] Type : bool Defined at drivers/gpu/drm/nouveau/Kconfig:79 Prompt: Enable additional push buffer debugging Depends on: HAS_IOMEM [=y] && DRM_NOUVEAU [=m] Location: -> Device Drivers -> Graphics support -> Nouveau (NVIDIA) cards (DRM_NOUVEAU [=m])
Cc: David Airlie airlied@redhat.com Cc: Adam Jackson ajax@redhat.com Signed-off-by: Fedora Kernel Team kernel-team@fedoraproject.org
.../common/generic/CONFIG_DRM_AMD_DC_DCN3_0 | 1 + .../common/generic/CONFIG_NOUVEAU_DEBUG_PUSH | 1 + .../generic/CONFIG_DRM_AMD_DC_DCN3_0 | 19 ------------------- .../generic/CONFIG_NOUVEAU_DEBUG_PUSH | 18 ------------------ 4 files changed, 2 insertions(+), 37 deletions(-) create mode 100644 redhat/configs/common/generic/CONFIG_DRM_AMD_DC_DCN3_0 create mode 100644 redhat/configs/common/generic/CONFIG_NOUVEAU_DEBUG_PUSH delete mode 100644 redhat/configs/pending-common/generic/CONFIG_DRM_AMD_DC_DCN3_0 delete mode 100644 redhat/configs/pending-common/generic/CONFIG_NOUVEAU_DEBUG_PUSH
diff --git a/redhat/configs/common/generic/CONFIG_DRM_AMD_DC_DCN3_0 b/redhat/configs/common/generic/CONFIG_DRM_AMD_DC_DCN3_0 new file mode 100644 index 000000000000..708bd22e809e --- /dev/null +++ b/redhat/configs/common/generic/CONFIG_DRM_AMD_DC_DCN3_0 @@ -0,0 +1 @@ +# CONFIG_DRM_AMD_DC_DCN3_0 is not set diff --git a/redhat/configs/common/generic/CONFIG_NOUVEAU_DEBUG_PUSH b/redhat/configs/common/generic/CONFIG_NOUVEAU_DEBUG_PUSH new file mode 100644 index 000000000000..5614c2c49809 --- /dev/null +++ b/redhat/configs/common/generic/CONFIG_NOUVEAU_DEBUG_PUSH @@ -0,0 +1 @@ +# CONFIG_NOUVEAU_DEBUG_PUSH is not set diff --git a/redhat/configs/pending-common/generic/CONFIG_DRM_AMD_DC_DCN3_0 b/redhat/configs/pending-common/generic/CONFIG_DRM_AMD_DC_DCN3_0 deleted file mode 100644 index f6a3c764772e..000000000000 --- a/redhat/configs/pending-common/generic/CONFIG_DRM_AMD_DC_DCN3_0 +++ /dev/null @@ -1,19 +0,0 @@ -# CONFIG_DRM_AMD_DC_DCN3_0: -# -# Choose this option if you want to have -# sienna_cichlid support for display engine -# -# Symbol: DRM_AMD_DC_DCN3_0 [=n] -# Type : bool -# Defined at drivers/gpu/drm/amd/display/Kconfig:20 -# Prompt: DCN 3.0 family -# Depends on: HAS_IOMEM [=y] && DRM [=m] && DRM_AMDGPU [=m] && DRM_AMD_DC [=y] && X86 [=y] && DRM_AMD_DC_DCN [=y] -# Location: -# -> Device Drivers -# -> Graphics support -# -> AMD GPU (DRM_AMDGPU [=m]) -# -> Display Engine Configuration -# -# -# -# CONFIG_DRM_AMD_DC_DCN3_0 is not set diff --git a/redhat/configs/pending-common/generic/CONFIG_NOUVEAU_DEBUG_PUSH b/redhat/configs/pending-common/generic/CONFIG_NOUVEAU_DEBUG_PUSH deleted file mode 100644 index c28eaf703375..000000000000 --- a/redhat/configs/pending-common/generic/CONFIG_NOUVEAU_DEBUG_PUSH +++ /dev/null @@ -1,18 +0,0 @@ -# CONFIG_NOUVEAU_DEBUG_PUSH: -# -# Say Y here if you want to enable verbose push buffer debug output -# and sanity checks. -# -# Symbol: NOUVEAU_DEBUG_PUSH [=n] -# Type : bool -# Defined at drivers/gpu/drm/nouveau/Kconfig:79 -# Prompt: Enable additional push buffer debugging -# Depends on: HAS_IOMEM [=y] && DRM_NOUVEAU [=m] -# Location: -# -> Device Drivers -# -> Graphics support -# -> Nouveau (NVIDIA) cards (DRM_NOUVEAU [=m]) -# -# -#
-# CONFIG_NOUVEAU_DEBUG_PUSH is not set
GitLab
From: jeremycline on gitlab.com
Hi,
As part of the ongoing rebase effort, the following configuration options need to be reviewed.
As a reminder, the ARK configuration flow involves moving unreviewed configuration options from the pending directory to the ark directory. In the diff below, options are removed from the pending directory and added to the ark hierarchy. The final options that need to be ACKed are the files that are being added to the ark hierarchy.
If the value for a file that is added should be changed, please reply with a better option.
CONFIG_DRM_AMD_DC_DCN3_0:
Choose this option if you want to have sienna_cichlid support for display engine
Symbol: DRM_AMD_DC_DCN3_0 [=n] Type : bool Defined at drivers/gpu/drm/amd/display/Kconfig:20 Prompt: DCN 3.0 family Depends on: HAS_IOMEM [=y] && DRM [=m] && DRM_AMDGPU [=m] && DRM_AMD_DC [=y] && X86 [=y] && DRM_AMD_DC_DCN [=y] Location: -> Device Drivers -> Graphics support -> AMD GPU (DRM_AMDGPU [=m]) -> Display Engine Configuration
---
CONFIG_NOUVEAU_DEBUG_PUSH:
Say Y here if you want to enable verbose push buffer debug output and sanity checks.
Symbol: NOUVEAU_DEBUG_PUSH [=n] Type : bool Defined at drivers/gpu/drm/nouveau/Kconfig:79 Prompt: Enable additional push buffer debugging Depends on: HAS_IOMEM [=y] && DRM_NOUVEAU [=m] Location: -> Device Drivers -> Graphics support -> Nouveau (NVIDIA) cards (DRM_NOUVEAU [=m])
---
Cc: David Airlie airlied@redhat.com Cc: Adam Jackson ajax@redhat.com Signed-off-by: Fedora Kernel Team kernel-team@fedoraproject.org
From: Patrick Talbert ptalbert@redhat.com
--- redhat/configs/common/generic/CONFIG_DRM_AMD_DC_DCN3_0 | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/redhat/configs/common/generic/CONFIG_DRM_AMD_DC_DCN3_0 b/redhat/configs/common/generic/CONFIG_DRM_AMD_DC_DCN3_0 index 708bd22e809e..1404e6f7d82c 100644 --- a/redhat/configs/common/generic/CONFIG_DRM_AMD_DC_DCN3_0 +++ b/redhat/configs/common/generic/CONFIG_DRM_AMD_DC_DCN3_0 @@ -1 +1 @@ -# CONFIG_DRM_AMD_DC_DCN3_0 is not set +CONFIG_DRM_AMD_DC_DCN3_0=y
From: Fedora Kernel Team kernel-team@fedoraproject.org
Hi,
As part of the ongoing rebase effort, the following configuration options need to be reviewed.
As a reminder, the ARK configuration flow involves moving unreviewed configuration options from the pending directory to the ark directory. In the diff below, options are removed from the pending directory and added to the ark hierarchy. The final options that need to be ACKed are the files that are being added to the ark hierarchy.
If the value for a file that is added should be changed, please reply with a better option.
CONFIG_DRM_AMD_DC_DCN3_0:
Choose this option if you want to have sienna_cichlid support for display engine
Symbol: DRM_AMD_DC_DCN3_0 [=n] Type : bool Defined at drivers/gpu/drm/amd/display/Kconfig:20 Prompt: DCN 3.0 family Depends on: HAS_IOMEM [=y] && DRM [=m] && DRM_AMDGPU [=m] && DRM_AMD_DC [=y] && X86 [=y] && DRM_AMD_DC_DCN [=y] Location: -> Device Drivers -> Graphics support -> AMD GPU (DRM_AMDGPU [=m]) -> Display Engine Configuration
---
CONFIG_NOUVEAU_DEBUG_PUSH:
Say Y here if you want to enable verbose push buffer debug output and sanity checks.
Symbol: NOUVEAU_DEBUG_PUSH [=n] Type : bool Defined at drivers/gpu/drm/nouveau/Kconfig:79 Prompt: Enable additional push buffer debugging Depends on: HAS_IOMEM [=y] && DRM_NOUVEAU [=m] Location: -> Device Drivers -> Graphics support -> Nouveau (NVIDIA) cards (DRM_NOUVEAU [=m])
---
Cc: David Airlie airlied@redhat.com Cc: Adam Jackson ajax@redhat.com Signed-off-by: Fedora Kernel Team kernel-team@fedoraproject.org --- .../common/generic/CONFIG_DRM_AMD_DC_DCN3_0 | 1 + .../common/generic/CONFIG_NOUVEAU_DEBUG_PUSH | 1 + .../generic/CONFIG_DRM_AMD_DC_DCN3_0 | 19 ------------------- .../generic/CONFIG_NOUVEAU_DEBUG_PUSH | 18 ------------------ 4 files changed, 2 insertions(+), 37 deletions(-) create mode 100644 redhat/configs/common/generic/CONFIG_DRM_AMD_DC_DCN3_0 create mode 100644 redhat/configs/common/generic/CONFIG_NOUVEAU_DEBUG_PUSH delete mode 100644 redhat/configs/pending-common/generic/CONFIG_DRM_AMD_DC_DCN3_0 delete mode 100644 redhat/configs/pending-common/generic/CONFIG_NOUVEAU_DEBUG_PUSH
diff --git a/redhat/configs/common/generic/CONFIG_DRM_AMD_DC_DCN3_0 b/redhat/configs/common/generic/CONFIG_DRM_AMD_DC_DCN3_0 new file mode 100644 index 000000000000..708bd22e809e --- /dev/null +++ b/redhat/configs/common/generic/CONFIG_DRM_AMD_DC_DCN3_0 @@ -0,0 +1 @@ +# CONFIG_DRM_AMD_DC_DCN3_0 is not set diff --git a/redhat/configs/common/generic/CONFIG_NOUVEAU_DEBUG_PUSH b/redhat/configs/common/generic/CONFIG_NOUVEAU_DEBUG_PUSH new file mode 100644 index 000000000000..5614c2c49809 --- /dev/null +++ b/redhat/configs/common/generic/CONFIG_NOUVEAU_DEBUG_PUSH @@ -0,0 +1 @@ +# CONFIG_NOUVEAU_DEBUG_PUSH is not set diff --git a/redhat/configs/pending-common/generic/CONFIG_DRM_AMD_DC_DCN3_0 b/redhat/configs/pending-common/generic/CONFIG_DRM_AMD_DC_DCN3_0 deleted file mode 100644 index f6a3c764772e..000000000000 --- a/redhat/configs/pending-common/generic/CONFIG_DRM_AMD_DC_DCN3_0 +++ /dev/null @@ -1,19 +0,0 @@ -# CONFIG_DRM_AMD_DC_DCN3_0: -# -# Choose this option if you want to have -# sienna_cichlid support for display engine -# -# Symbol: DRM_AMD_DC_DCN3_0 [=n] -# Type : bool -# Defined at drivers/gpu/drm/amd/display/Kconfig:20 -# Prompt: DCN 3.0 family -# Depends on: HAS_IOMEM [=y] && DRM [=m] && DRM_AMDGPU [=m] && DRM_AMD_DC [=y] && X86 [=y] && DRM_AMD_DC_DCN [=y] -# Location: -# -> Device Drivers -# -> Graphics support -# -> AMD GPU (DRM_AMDGPU [=m]) -# -> Display Engine Configuration -# -# -# -# CONFIG_DRM_AMD_DC_DCN3_0 is not set diff --git a/redhat/configs/pending-common/generic/CONFIG_NOUVEAU_DEBUG_PUSH b/redhat/configs/pending-common/generic/CONFIG_NOUVEAU_DEBUG_PUSH deleted file mode 100644 index c28eaf703375..000000000000 --- a/redhat/configs/pending-common/generic/CONFIG_NOUVEAU_DEBUG_PUSH +++ /dev/null @@ -1,18 +0,0 @@ -# CONFIG_NOUVEAU_DEBUG_PUSH: -# -# Say Y here if you want to enable verbose push buffer debug output -# and sanity checks. -# -# Symbol: NOUVEAU_DEBUG_PUSH [=n] -# Type : bool -# Defined at drivers/gpu/drm/nouveau/Kconfig:79 -# Prompt: Enable additional push buffer debugging -# Depends on: HAS_IOMEM [=y] && DRM_NOUVEAU [=m] -# Location: -# -> Device Drivers -# -> Graphics support -# -> Nouveau (NVIDIA) cards (DRM_NOUVEAU [=m]) -# -# -# -# CONFIG_NOUVEAU_DEBUG_PUSH is not set
From: Patrick Talbert on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/563#note_48097114...
Hello David,
I have made the change as requested. Please rereview if you can.
Note that all commits will be squashed upon merge.
Thank you,
Patrick
From: Patrick Talbert on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/563#note_49404686...
This merge request has not been updated in over 15 days. Please review this MR's current changes regarding the following configuration option(s):
CONFIG_DRM_AMD_DC_DCN3_0 CONFIG_NOUVEAU_DEBUG_PUSH
From: Lyude Paul on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/563#note_55193004...
`CONFIG_NOUVEAU_DEBUG_PUSH` really should be enabled for debug configs `CONFIG_DRM_AMD_DC_DCN3_0` definitely needs to be set to Y for all configurations
From: Patrick Talbert on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/563#note_55350327...
Thank you Lyude. I have rebased this and made the requested change. Let me know what you think.
Patrick
kernel@lists.fedoraproject.org