From: "CKI@GitLab" cki-project@redhat.com
Hi,
As part of the ongoing rebase effort, the following configuration options need to be reviewed.
As a reminder, the ARK configuration flow involves moving unreviewed configuration options from the pending directory to the ark directory. In the diff below, options are removed from the pending directory and added to the ark hierarchy. The final options that need to be ACKed are the files that are being added to the ark hierarchy.
If the value for a file that is added should be changed, please reply with a better option.
CONFIG_SPI_AMD:
Enables SPI controller driver for AMD SoC.
Symbol: SPI_AMD [=n] Type : tristate Defined at drivers/spi/Kconfig:917 Prompt: AMD SPI controller Depends on: SPI [=y] && SPI_MASTER [=y] && (SPI_MASTER [=y] || COMPILE_TEST [=n]) Location: -> Device Drivers -> SPI support (SPI [=y])
---
Signed-off-by: CKI@GitLab cki-project@redhat.com --- redhat/configs/common/generic/CONFIG_SPI_AMD | 1 + .../pending-common/generic/CONFIG_SPI_AMD | 16 ---------------- 2 files changed, 1 insertion(+), 16 deletions(-) create mode 100644 redhat/configs/common/generic/CONFIG_SPI_AMD delete mode 100644 redhat/configs/pending-common/generic/CONFIG_SPI_AMD
diff --git a/redhat/configs/common/generic/CONFIG_SPI_AMD b/redhat/configs/common/generic/CONFIG_SPI_AMD new file mode 100644 index 000000000000..0dc059dce496 --- /dev/null +++ b/redhat/configs/common/generic/CONFIG_SPI_AMD @@ -0,0 +1 @@ +# CONFIG_SPI_AMD is not set diff --git a/redhat/configs/pending-common/generic/CONFIG_SPI_AMD b/redhat/configs/pending-common/generic/CONFIG_SPI_AMD deleted file mode 100644 index ac7ea25e07a7..000000000000 --- a/redhat/configs/pending-common/generic/CONFIG_SPI_AMD +++ /dev/null @@ -1,16 +0,0 @@ -# CONFIG_SPI_AMD: -# -# Enables SPI controller driver for AMD SoC. -# -# Symbol: SPI_AMD [=n] -# Type : tristate -# Defined at drivers/spi/Kconfig:917 -# Prompt: AMD SPI controller -# Depends on: SPI [=y] && SPI_MASTER [=y] && (SPI_MASTER [=y] || COMPILE_TEST [=n]) -# Location: -# -> Device Drivers -# -> SPI support (SPI [=y]) -# -# -# -# CONFIG_SPI_AMD is not set
On 6/2/20 12:38 AM, GitLab Bridge on behalf of jeremycline wrote:
From: "CKI@GitLab" cki-project@redhat.com
Hi,
As part of the ongoing rebase effort, the following configuration options need to be reviewed.
As a reminder, the ARK configuration flow involves moving unreviewed configuration options from the pending directory to the ark directory. In the diff below, options are removed from the pending directory and added to the ark hierarchy. The final options that need to be ACKed are the files that are being added to the ark hierarchy.
If the value for a file that is added should be changed, please reply with a better option.
CONFIG_SPI_AMD:
Enables SPI controller driver for AMD SoC.
Symbol: SPI_AMD [=n] Type : tristate Defined at drivers/spi/Kconfig:917 Prompt: AMD SPI controller Depends on: SPI [=y] && SPI_MASTER [=y] && (SPI_MASTER [=y] || COMPILE_TEST [=n]) Location: -> Device Drivers -> SPI support (SPI [=y])
Please set this to "Y".
Politely,
Nacked-by: Prarit Bhargava prarit@redhat.com
P.
Signed-off-by: CKI@GitLab cki-project@redhat.com
redhat/configs/common/generic/CONFIG_SPI_AMD | 1 + .../pending-common/generic/CONFIG_SPI_AMD | 16 ---------------- 2 files changed, 1 insertion(+), 16 deletions(-) create mode 100644 redhat/configs/common/generic/CONFIG_SPI_AMD delete mode 100644 redhat/configs/pending-common/generic/CONFIG_SPI_AMD
diff --git a/redhat/configs/common/generic/CONFIG_SPI_AMD b/redhat/configs/common/generic/CONFIG_SPI_AMD new file mode 100644 index 000000000000..0dc059dce496 --- /dev/null +++ b/redhat/configs/common/generic/CONFIG_SPI_AMD @@ -0,0 +1 @@ +# CONFIG_SPI_AMD is not set diff --git a/redhat/configs/pending-common/generic/CONFIG_SPI_AMD b/redhat/configs/pending-common/generic/CONFIG_SPI_AMD deleted file mode 100644 index ac7ea25e07a7..000000000000 --- a/redhat/configs/pending-common/generic/CONFIG_SPI_AMD +++ /dev/null @@ -1,16 +0,0 @@ -# CONFIG_SPI_AMD: -# -# Enables SPI controller driver for AMD SoC. -# -# Symbol: SPI_AMD [=n] -# Type : tristate -# Defined at drivers/spi/Kconfig:917 -# Prompt: AMD SPI controller -# Depends on: SPI [=y] && SPI_MASTER [=y] && (SPI_MASTER [=y] || COMPILE_TEST [=n]) -# Location: -# -> Device Drivers -# -> SPI support (SPI [=y]) -# -# -# -# CONFIG_SPI_AMD is not set
From: jeremycline on gitlab.com
Hi,
As part of the ongoing rebase effort, the following configuration options need to be reviewed.
As a reminder, the ARK configuration flow involves moving unreviewed configuration options from the pending directory to the ark directory. In the diff below, options are removed from the pending directory and added to the ark hierarchy. The final options that need to be ACKed are the files that are being added to the ark hierarchy.
If the value for a file that is added should be changed, please reply with a better option.
CONFIG_SPI_AMD:
Enables SPI controller driver for AMD SoC.
Symbol: SPI_AMD [=n] Type : tristate Defined at drivers/spi/Kconfig:917 Prompt: AMD SPI controller Depends on: SPI [=y] && SPI_MASTER [=y] && (SPI_MASTER [=y] || COMPILE_TEST [=n]) Location: -> Device Drivers -> SPI support (SPI [=y])
---
Signed-off-by: CKI@GitLab cki-project@redhat.com
From: Justin Forbes jforbes@fedoraproject.org
--- redhat/configs/common/generic/CONFIG_SPI_AMD | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/redhat/configs/common/generic/CONFIG_SPI_AMD b/redhat/configs/common/generic/CONFIG_SPI_AMD index 0dc059dce496..5bbc923fba96 100644 --- a/redhat/configs/common/generic/CONFIG_SPI_AMD +++ b/redhat/configs/common/generic/CONFIG_SPI_AMD @@ -1 +1 @@ -# CONFIG_SPI_AMD is not set +CONFIG_SPI_AMD=y
From: "CKI@GitLab" cki-project@redhat.com
Hi,
As part of the ongoing rebase effort, the following configuration options need to be reviewed.
As a reminder, the ARK configuration flow involves moving unreviewed configuration options from the pending directory to the ark directory. In the diff below, options are removed from the pending directory and added to the ark hierarchy. The final options that need to be ACKed are the files that are being added to the ark hierarchy.
If the value for a file that is added should be changed, please reply with a better option.
CONFIG_SPI_AMD:
Enables SPI controller driver for AMD SoC.
Symbol: SPI_AMD [=n] Type : tristate Defined at drivers/spi/Kconfig:917 Prompt: AMD SPI controller Depends on: SPI [=y] && SPI_MASTER [=y] && (SPI_MASTER [=y] || COMPILE_TEST [=n]) Location: -> Device Drivers -> SPI support (SPI [=y])
---
Signed-off-by: CKI@GitLab cki-project@redhat.com --- redhat/configs/common/generic/CONFIG_SPI_AMD | 1 + .../pending-common/generic/CONFIG_SPI_AMD | 16 ---------------- 2 files changed, 1 insertion(+), 16 deletions(-) create mode 100644 redhat/configs/common/generic/CONFIG_SPI_AMD delete mode 100644 redhat/configs/pending-common/generic/CONFIG_SPI_AMD
diff --git a/redhat/configs/common/generic/CONFIG_SPI_AMD b/redhat/configs/common/generic/CONFIG_SPI_AMD new file mode 100644 index 000000000000..0dc059dce496 --- /dev/null +++ b/redhat/configs/common/generic/CONFIG_SPI_AMD @@ -0,0 +1 @@ +# CONFIG_SPI_AMD is not set diff --git a/redhat/configs/pending-common/generic/CONFIG_SPI_AMD b/redhat/configs/pending-common/generic/CONFIG_SPI_AMD deleted file mode 100644 index ac7ea25e07a7..000000000000 --- a/redhat/configs/pending-common/generic/CONFIG_SPI_AMD +++ /dev/null @@ -1,16 +0,0 @@ -# CONFIG_SPI_AMD: -# -# Enables SPI controller driver for AMD SoC. -# -# Symbol: SPI_AMD [=n] -# Type : tristate -# Defined at drivers/spi/Kconfig:917 -# Prompt: AMD SPI controller -# Depends on: SPI [=y] && SPI_MASTER [=y] && (SPI_MASTER [=y] || COMPILE_TEST [=n]) -# Location: -# -> Device Drivers -# -> SPI support (SPI [=y]) -# -# -# -# CONFIG_SPI_AMD is not set
From: jeremycline on gitlab.com
Hi,
As part of the ongoing rebase effort, the following configuration options need to be reviewed.
As a reminder, the ARK configuration flow involves moving unreviewed configuration options from the pending directory to the ark directory. In the diff below, options are removed from the pending directory and added to the ark hierarchy. The final options that need to be ACKed are the files that are being added to the ark hierarchy.
If the value for a file that is added should be changed, please reply with a better option.
CONFIG_SPI_AMD:
Enables SPI controller driver for AMD SoC.
Symbol: SPI_AMD [=n] Type : tristate Defined at drivers/spi/Kconfig:917 Prompt: AMD SPI controller Depends on: SPI [=y] && SPI_MASTER [=y] && (SPI_MASTER [=y] || COMPILE_TEST [=n]) Location: -> Device Drivers -> SPI support (SPI [=y])
---
Signed-off-by: CKI@GitLab cki-project@redhat.com
From: "CKI@GitLab" cki-project@redhat.com
Hi,
As part of the ongoing rebase effort, the following configuration options need to be reviewed.
As a reminder, the ARK configuration flow involves moving unreviewed configuration options from the pending directory to the ark directory. In the diff below, options are removed from the pending directory and added to the ark hierarchy. The final options that need to be ACKed are the files that are being added to the ark hierarchy.
If the value for a file that is added should be changed, please reply with a better option.
CONFIG_SPI_AMD:
Enables SPI controller driver for AMD SoC.
Symbol: SPI_AMD [=n] Type : tristate Defined at drivers/spi/Kconfig:917 Prompt: AMD SPI controller Depends on: SPI [=y] && SPI_MASTER [=y] && (SPI_MASTER [=y] || COMPILE_TEST [=n]) Location: -> Device Drivers -> SPI support (SPI [=y])
---
Signed-off-by: CKI@GitLab cki-project@redhat.com --- redhat/configs/common/generic/CONFIG_SPI_AMD | 1 + .../pending-common/generic/CONFIG_SPI_AMD | 16 ---------------- 2 files changed, 1 insertion(+), 16 deletions(-) create mode 100644 redhat/configs/common/generic/CONFIG_SPI_AMD delete mode 100644 redhat/configs/pending-common/generic/CONFIG_SPI_AMD
diff --git a/redhat/configs/common/generic/CONFIG_SPI_AMD b/redhat/configs/common/generic/CONFIG_SPI_AMD new file mode 100644 index 000000000000..0dc059dce496 --- /dev/null +++ b/redhat/configs/common/generic/CONFIG_SPI_AMD @@ -0,0 +1 @@ +# CONFIG_SPI_AMD is not set diff --git a/redhat/configs/pending-common/generic/CONFIG_SPI_AMD b/redhat/configs/pending-common/generic/CONFIG_SPI_AMD deleted file mode 100644 index ac7ea25e07a7..000000000000 --- a/redhat/configs/pending-common/generic/CONFIG_SPI_AMD +++ /dev/null @@ -1,16 +0,0 @@ -# CONFIG_SPI_AMD: -# -# Enables SPI controller driver for AMD SoC. -# -# Symbol: SPI_AMD [=n] -# Type : tristate -# Defined at drivers/spi/Kconfig:917 -# Prompt: AMD SPI controller -# Depends on: SPI [=y] && SPI_MASTER [=y] && (SPI_MASTER [=y] || COMPILE_TEST [=n]) -# Location: -# -> Device Drivers -# -> SPI support (SPI [=y]) -# -# -# -# CONFIG_SPI_AMD is not set
From: Justin Forbes jforbes@fedoraproject.org
Cc: Al Stone ahs3@redhat.com --- redhat/configs/common/generic/CONFIG_SPI_AMD | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/redhat/configs/common/generic/CONFIG_SPI_AMD b/redhat/configs/common/generic/CONFIG_SPI_AMD index 0dc059dce496..5bbc923fba96 100644 --- a/redhat/configs/common/generic/CONFIG_SPI_AMD +++ b/redhat/configs/common/generic/CONFIG_SPI_AMD @@ -1 +1 @@ -# CONFIG_SPI_AMD is not set +CONFIG_SPI_AMD=y
From: Patrick Talbert on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/396#note_49406044...
This merge request has not been updated in over 90 days. Please review this MR's current changes regarding the following configuration option(s):
CONFIG_SPI_AMD
From: CKI Bot on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/396#note_49625634...
Acked-by: Prarit Bhargava prarit@redhat.com (via approve button)
From: Jeremy Cline on gitlab.com Merge Request: https://gitlab.com/cki-project/kernel-ark/-/merge_requests/396
Hi,
As part of the ongoing rebase effort, the following configuration options need to be reviewed.
As a reminder, the ARK configuration flow involves moving unreviewed configuration options from the pending directory to the ark directory. In the diff below, options are removed from the pending directory and added to the ark hierarchy. The final options that need to be ACKed are the files that are being added to the ark hierarchy.
If the value for a file that is added should be changed, please reply with a better option.
CONFIG_SPI_AMD:
Enables SPI controller driver for AMD SoC.
Symbol: SPI_AMD [=n] Type : tristate Defined at drivers/spi/Kconfig:917 Prompt: AMD SPI controller Depends on: SPI [=y] && SPI_MASTER [=y] && (SPI_MASTER [=y] || COMPILE_TEST [=n]) Location: -> Device Drivers -> SPI support (SPI [=y])
---
Cc: Al Stone ahs3@redhat.com Cc: Prarit Bhargava prarit@redhat.com Signed-off-by: CKI@GitLab cki-project@redhat.com
From: CKI@GitLab cki-project@redhat.com
[redhat] New configs in drivers/spi
Hi,
As part of the ongoing rebase effort, the following configuration options need to be reviewed.
As a reminder, the ARK configuration flow involves moving unreviewed configuration options from the pending directory to the ark directory. In the diff below, options are removed from the pending directory and added to the ark hierarchy. The final options that need to be ACKed are the files that are being added to the ark hierarchy.
If the value for a file that is added should be changed, please reply with a better option.
CONFIG_SPI_AMD:
Enables SPI controller driver for AMD SoC.
Symbol: SPI_AMD [=n] Type : tristate Defined at drivers/spi/Kconfig:917 Prompt: AMD SPI controller Depends on: SPI [=y] && SPI_MASTER [=y] && (SPI_MASTER [=y] || COMPILE_TEST [=n]) Location: -> Device Drivers -> SPI support (SPI [=y])
---
Signed-off-by: CKI@GitLab cki-project@redhat.com
diff a/redhat/configs/common/generic/CONFIG_SPI_AMD b/redhat/configs/common/generic/CONFIG_SPI_AMD --- /dev/null +++ b/redhat/configs/common/generic/CONFIG_SPI_AMD @@ -0,0 +1 @@ +# CONFIG_SPI_AMD is not set diff a/redhat/configs/pending-common/generic/CONFIG_SPI_AMD b/redhat/configs/pending-common/generic/CONFIG_SPI_AMD --- a/redhat/configs/pending-common/generic/CONFIG_SPI_AMD +++ /dev/null @@ -1,16 +0,0 @@ -# CONFIG_SPI_AMD: -# -# Enables SPI controller driver for AMD SoC. -# -# Symbol: SPI_AMD [=n] -# Type : tristate -# Defined at drivers/spi/Kconfig:917 -# Prompt: AMD SPI controller -# Depends on: SPI [=y] && SPI_MASTER [=y] && (SPI_MASTER [=y] || COMPILE_TEST [=n]) -# Location: -# -> Device Drivers -# -> SPI support (SPI [=y]) -# -# -# -# CONFIG_SPI_AMD is not set
-- https://gitlab.com/cki-project/kernel-ark/-/merge_requests/396
From: Justin Forbes jforbes@fedoraproject.org
Update CONFIG_SPI_AMD based on Prarit's recommendations
Cc: Al Stone ahs3@redhat.com
diff a/redhat/configs/common/generic/CONFIG_SPI_AMD b/redhat/configs/common/generic/CONFIG_SPI_AMD --- a/redhat/configs/common/generic/CONFIG_SPI_AMD +++ b/redhat/configs/common/generic/CONFIG_SPI_AMD @@ -1 +1 @@ -# CONFIG_SPI_AMD is not set +CONFIG_SPI_AMD=y
-- https://gitlab.com/cki-project/kernel-ark/-/merge_requests/396
On 1/28/21 3:04 PM, Jeremy Cline (via Email Bridge) wrote:
From: Justin Forbes jforbes@fedoraproject.org
Update CONFIG_SPI_AMD based on Prarit's recommendations
Cc: Al Stone ahs3@redhat.com
diff a/redhat/configs/common/generic/CONFIG_SPI_AMD
b/redhat/configs/common/generic/CONFIG_SPI_AMD
--- a/redhat/configs/common/generic/CONFIG_SPI_AMD +++ b/redhat/configs/common/generic/CONFIG_SPI_AMD @@ -1 +1 @@ -# CONFIG_SPI_AMD is not set +CONFIG_SPI_AMD=y
Acked-by: Prarit Bhargava prarit@redhat.com
P.
On 28 Jan 2021 20:04, Jeremy Cline (via Email Bridge) wrote:
From: Justin Forbes jforbes@fedoraproject.org
Update CONFIG_SPI_AMD based on Prarit's recommendations
Cc: Al Stone ahs3@redhat.com
diff a/redhat/configs/common/generic/CONFIG_SPI_AMD b/redhat/configs/common/generic/CONFIG_SPI_AMD --- a/redhat/configs/common/generic/CONFIG_SPI_AMD +++ b/redhat/configs/common/generic/CONFIG_SPI_AMD @@ -1 +1 @@ -# CONFIG_SPI_AMD is not set +CONFIG_SPI_AMD=y
-- https://gitlab.com/cki-project/kernel-ark/-/merge_requests/396
Acked-by: Al Stone ahs3@redhat.com
From: CKI Admin Bot on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/396#note_49657724...
Hi! This is the friendly CKI test bot.
It appears that you are not a member of redhat/red-hat-ci- tools/kernel/cki-runs/trusted-pipelines. This means that the CI pipeline on your MR will fail. As getting testing is important, I'll be responsible for testing your changes. After every MR change, I'll start a small testing pipeline and link it here so you can follow the results. I'll also create and link a pipeline for hardware testing that the reviewers can start to get extra test coverage.
You can find more details about the contributor setup, permission issues and how to resolve them at https://cki-project.org/docs/user_docs/gitlab-mr-testing/#trusted-and- external-contributors
From: CKI Admin Bot on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/396#note_49657727...
Testing pipeline status: Basic testing pipeline:
https://gitlab.com/redhat/red-hat-ci-tools/kernel/cki- runs/external-pipelines/-/pipelines/248345236 - created :hourglass_flowing_sand:
kernel@lists.fedoraproject.org