From: Jakub Čajka jcajka@redhat.com
Keep VIRTIO_CONSOLE on s390x available.
This regression has been hit in the CoreOS pipeline as it utilizes it to gather build logs from build VMs during build of the CoreOS.
Fixes RHBZ1917575
diff a/redhat/configs/pending-common/generic/s390x/CONFIG_VIRTIO_CONSOLE b/redhat/configs/pending-common/generic/s390x/CONFIG_VIRTIO_CONSOLE --- a/redhat/configs/pending-common/generic/s390x/CONFIG_VIRTIO_CONSOLE +++ /dev/null @@ -1 +0,0 @@ -# CONFIG_VIRTIO_CONSOLE is not set
-- https://gitlab.com/cki-project/kernel-ark/-/merge_requests/873
From: CKI Admin Bot on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/873#note_49505504...
Hi! This is the friendly CKI test bot.
It appears that you are not a member of redhat/red-hat-ci- tools/kernel/cki-runs/trusted-pipelines. This means that the CI pipeline on your MR will fail. As getting testing is important, I'll be responsible for testing your changes. After every MR change, I'll start a small testing pipeline and link it here so you can follow the results. I'll also create and link a pipeline for hardware testing that the reviewers can start to get extra test coverage.
From: CKI Admin Bot on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/873#note_49505509...
Testing pipeline status: Basic testing pipeline:
https://gitlab.com/redhat/red-hat-ci-tools/kernel/cki- runs/external-pipelines/-/pipelines/247495155 - created :hourglass_flowing_sand:
From: Dan Horák on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/873#note_49507504...
not sure this works, but
CC: Philipp Rudo prudo@redhat.com CC: Steve Best sbest@redhat.com
Hi Dan,
apparently that doesn't work. I pass the question on to Claudio from our virt team.
Thanks Philipp
On Wed, 27 Jan 2021 12:08:32 -0000 cki-gitlab@redhat.com wrote:
From: Dan Horák on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/873#note_49507504...
not sure this works, but
CC: Philipp Rudo prudo@redhat.com CC: Steve Best sbest@redhat.com _______________________________________________ kernel mailing list -- kernel@lists.fedoraproject.org To unsubscribe send an email to kernel-leave@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/kernel@lists.fedoraproject.org
From: Jakub Cajka on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/873#note_49507669...
For the record I haven't been able to build srpms/kernel from this repo. Changing the generated configs in the Fedora kernel dist-git and building srpm/kernel with it resolves the mentioned rhbz for me.
From: Dan Horák on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/873#note_49507733...
Phillip, non-s390x arches have the VIRTIO_CONSOLE support built as a module, but s390x has it built-in (same for mainline default config). Is there a reason for that?
From: Justin Forbes on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/873#note_49510642...
Yes, and the reason was stated in the actual file deleted here. Upstream change made it to where building in VIRTIO_CONSOLE required building in all of virtio. This was put in as a quick fix to get kernels building again, which is why there is no MR to change it outside of pending. That upstream issue was fixed with 9f30eb29c514589e16f2999ea070598583d1f6ec and this can go away. Merging this, it does not need review as CONFIG_VIRTIO_CONSOLE=y is the actual reviewed and accepted CONFIG status, we are simply deleting a pending.
kernel@lists.fedoraproject.org
-
cki-gitlab＠redhat.com -
Jakub Cajka (via Email Bridge)
-
Philipp Rudo