On Wed, Jul 1, 2020 at 7:20 AM Tomas Kopecek <tkopecek@redhat.com> wrote:
I suspect it is some relict predating python 2.4. But I also wonder, why untagBuild has comment about not being able to be staticmethoded. Mike?

That particular comment is stale. I think originally, this wrapper around _untag_build was very, very simple. So this comment was explaining why it wasn't simply untagBuild = staticmethod(_untag_build). With the current version is there significant code in the wrapper, so of course the latter method would not work.
 

út 30. 6. 2020 v 20:16 odesílatel Ken Dreyer <ktdreyer@ktdreyer.com> napsal:
Someone was asking me recently why hub/kojihub.py has a convention like:

  listChannels = staticmethod(list_channels)

Is it fine to just remove this and use the @staticmethod decorator on
all the "public API" methods everywhere?

- Ken
_______________________________________________
koji-devel mailing list -- koji-devel@lists.fedorahosted.org
To unsubscribe send an email to koji-devel-leave@lists.fedorahosted.org
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedorahosted.org/archives/list/koji-devel@lists.fedorahosted.org


--

            Tomas Kopecek <tkopecek@redhat.com>
            RHEL Build Development, RedHat