hi,
thanks for the changes, I have some comments/questions..
wbr,
jirka
On Sun, Feb 13, 2011 at 10:05 PM, Sebastian Pipping <sping(a)gentoo.org> wrote:
> Hello Jiri,
>
>
> I came across latrace and played with a Gentoo ebuild for it, current
> result at [1]. On the way I discovered a few minor issues with the
> release of 0.5.10:
>
> - Compile flags are not respected everywhere. Please consider
> application of attached patch.
I'm ok with CFLAGS being used for linking, but I'm not sure
whats the benefit with LDFLAGS in compile.. I looked over few
projects (flex/strace/utliss-linux-ng) and none seems to be using this.
Could you please specify the reason?
>
> - A configure script is required, but the script itself is not shipped.
> Please adjust your packaging scripts accordingly.
You can get the configure script by running 'autoconf', but I guess you need it
in the package without running anything right?
Is it gento requirement?
>
> - Packaging for Debain is shipped twice:
> - debian/
> - package/debian/
yep, thats confusing :) looks like ./debian/changelog is more recent
Akos, can I move it to the ./package/ ?