Gitweb: http://git.fedorahosted.org/git/?p=lvm2.git;a=commitdiff;h=b2d819eafac630cc…
Commit: b2d819eafac630cc683c5fdf02730a636dd9bff6
Parent: e3b904fd08712cf71a2248f72dd2be5b42039282
Author: David Teigland <teigland(a)redhat.com>
AuthorDate: Mon Feb 29 13:50:02 2016 -0600
Committer: David Teigland <teigland(a)redhat.com>
CommitterDate: Mon Feb 29 13:50:02 2016 -0600
update WHATS_NEW
including changes not recorded for the previous release.
---
WHATS_NEW | 4 ++++
1 files changed, 4 insertions(+), 0 deletions(-)
diff --git a/WHATS_NEW b/WHATS_NEW
index 77b0a40..507e028 100644
--- a/WHATS_NEW
+++ b/WHATS_NEW
@@ -1,8 +1,12 @@
Version 2.02.145 -
=====================================
+ Display [unknown] instead of blank for unknown VG names in pvs output.
Version 2.02.144 - 26th February 2016
=====================================
+ Use new PV processing code in pvcreate/vgcreate/vgextend/pvremove.
+ Add new PV processing code that prompts user without locks held.
+ Prevent lvmlockd blocking with new flag requiring sanlock 3.3.0.
Only show (u)sed pv_attr char when PV is not (a)llocatable. (2.02.143)
Update makefile to generate lcov output also for lvmpolld and lvmlockd.
Fix SystemdService lvm2-lvmdbusd.service name.
Gitweb: http://git.fedorahosted.org/git/?p=lvm2.git;a=commitdiff;h=68cfdd55335d6f8a…
Commit: 68cfdd55335d6f8af8e00ec559353a2fbafb683a
Parent: 0000000000000000000000000000000000000000
Author: Alasdair G Kergon <agk(a)redhat.com>
AuthorDate: 2016-02-26 21:04 +0000
Committer: Alasdair G Kergon <agk(a)redhat.com>
CommitterDate: 2016-02-26 21:04 +0000
annotated tag: v2_02_144 has been created
at 68cfdd55335d6f8af8e00ec559353a2fbafb683a (tag)
tagging 731a9c1354481524a5d8674f10f0ca57c503c655 (commit)
replaces v2_02_143
Release 2.02.144.
Another development release - recent interface changes are not yet frozen.
322 files changed, 3212 insertions(+), 1389 deletions(-)
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.14 (GNU/Linux)
iEYEABECAAYFAlbQvf0ACgkQIoGRwVZ+LBdxKwCggAq4Adeq0NXrfHxALe37Q4T3
M/8AoNXdvyGP/BE97ZXtRyKPZdDUKA2P
=NZ11
-----END PGP SIGNATURE-----
Alasdair G Kergon (4):
post-release
configure
report: Shift (u)sed pv_attr under (a)llocatable.
pre-release
Bryn M. Reeves (8):
dmstats: create dmstats symlink in test/lib
tests: add basic dmstats tests
tests: add driver_at_least() to aux.sh
tests: add template tests/shell/dmstats-create.sh
tests: install does not depend on lib/version-expected
tests: make lib/expected-version-dm a dependency of .tests-stamp
tests: add dmstats create tests
tests: add simple dmstats report tests
David Teigland (28):
test: add make check_lvmlockd_test
lvmlockd: invalidate name in lockspace struct after remove
tests: fix clean up after lvmlockd tests
tests: add SKIP_WITH_LVMLOCKD
tests: updates for check_lvmlockd
lvmlockd: set default result value
lvmlockd: fix sparse snapshot case
tests: include lvmlockd in default make check
lvmlockd: use new sanlock flag to avoid blocking
configure: require sanlock 3.3.0
vg_write: add list of pvs to write
metadata: refactor part of add_pv_to_vg
metadata: use pv_write_list for _check_old_pv_ext_for_vg
vgconvert: refactor to avoid pvcreate code
toollib: add two phase pv processing code
pvcreate: use the common toollib pv create
vgextend: use the common toollib pv create
vgcreate: use the common toollib pv create
liblvm: replace pvcreate_single with pvcreate_vol
toollib: remove unsed pvcreate params function
pvremove: use common toollib processing code
metadata: add fixme about code used only by liblvm
redefine pvcreate structs
replace pvcreate_params with pvcreate_each_params
pvcreate: fix setting uuid arg
Use a common message for a used PV
pvcreate: fix error from pv_write
pvcreate: fix data alignment error check
Marian Csontos (3):
spec: Fix 04ab1fa572bb: Remove left-overs
lvmdbusd: Fix make install for python >= 3.5
make: Add check_lvmlockd_* targets to top-level
Peter Rajnoha (1):
lvmcache: fix missing free of vginfo->system_id causing mem leak
Tony Asleson (10):
lvmdbustest.py: Make executable
lvmdbusd: background.py, fix stdout parse error
lvmdbus: Make unit tests work in test env
lvmdbusd: Add env variable to use session bus
lvmdbusd: Remove unlimited retries
lvmdbusd: Initial unit test driver script
lvmdbusd: Reduce unnecessary state refreshes
lvmdbustest.py: Move helper code to testlib.py
lvmdbusd testing: Add validatestate.py utility
lvmdbusd: Do only 1 refresh for Vg.Change()
Vratislav Podzimek (1):
dbus: fix the systemd service providing the DBus service
Zdenek Kabelac (38):
lvmetad: fix error path
libdm: grow with initialized struct content
cleanup: libdm clang warnings
cleanup: indent changes
cleanup: use char arrays.
tests: skip thin-flags test on 32bit el6 kernel
thin: fix read size compare
cache: enforce header check
gcc: cleanup some sign warnings
cleanup: drop double ;
pvremove: add warn when removing PV in use
gcc: cleanup Wunused-const-variable
gcc: logical-op warning go away
tests: check warn about belong is printed
libdm: fix string boundary
coverity: drop unneeded header
coverity: check for info pointer existance
coverity: check for zero length buffer
coverity: drop unused assignments
coverity: ensure non-null pointers are used
coverity: check cmd pointer exists
coverity: check for dm_snprintf
coverity: use same arithmetic for both major and minor
coverity: ensure thin_pool_seg is not NULL
cleanup: use braces around macro params
cleanup: use sizeof instead of macro.
lvresize: fix regression with zero size arg
lvconvert: fix vg parameter
lvconvert: simplify handler processing
lvconvert: use more display_lvname
lvconvert: use lp->repair
cleanup: poll better check for internal errors
cleanup: indent
cleanup: drop unneeded test
tests: lvresize with zero arg
makefiles: add more dirs for lcov output
coverity: helping coverity with NULL pointer
tests: skip on older version
Gitweb: http://git.fedorahosted.org/git/?p=lvm2.git;a=commitdiff;h=98981265963f5c25…
Commit: 98981265963f5c2572687cc7c8b49aa7cb6f85ec
Parent: 183bd8ca0342f6f72630afcb42b453b88ee90ac6
Author: Alasdair G Kergon <agk(a)redhat.com>
AuthorDate: Fri Feb 26 15:46:37 2016 +0000
Committer: Alasdair G Kergon <agk(a)redhat.com>
CommitterDate: Fri Feb 26 15:46:37 2016 +0000
report: Shift (u)sed pv_attr under (a)llocatable.
Showing 'u' in the pv_attr reporting field is mostly unnecessary because
most PVs are allocatable, and being allocatable implies it is (u)sed,
and this is already obvious from other fields in the default 'pvs'
output like the VG name.
So move the new (u)sed pv_attr from character position 4 to 1, and only
show it in those rare cases when the PV is not (a)llocatable or the
relevant metadata is missing.
(Scripts should not be using pv_attr, but rather pv_allocatable,
pv_exported, pv_missing, pv_in_use etc.)
---
WHATS_NEW | 1 +
lib/metadata/pv.c | 8 +++++---
man/pvs.8.in | 2 +-
test/shell/pvchange-usage.sh | 10 +++++-----
4 files changed, 12 insertions(+), 9 deletions(-)
diff --git a/WHATS_NEW b/WHATS_NEW
index f91b3d0..610ea43 100644
--- a/WHATS_NEW
+++ b/WHATS_NEW
@@ -1,5 +1,6 @@
Version 2.02.144 -
=====================================
+ Only show (u)sed pv_attr char when PV is not (a)llocatable. (2.02.143)
Update makefile to generate lcov output also for lvmpolld and lvmlockd.
Fix SystemdService lvm2-lvmdbusd.service name.
Improve support for env LVM_VG_NAME for reference VG name in lvconvert.
diff --git a/lib/metadata/pv.c b/lib/metadata/pv.c
index 1d68045..7ea993f 100644
--- a/lib/metadata/pv.c
+++ b/lib/metadata/pv.c
@@ -237,15 +237,17 @@ char *pv_attr_dup(struct dm_pool *mem, const struct physical_volume *pv)
char *repstr;
int used = is_used_pv(pv);
- if (!(repstr = dm_pool_zalloc(mem, 5))) {
+ if (!(repstr = dm_pool_zalloc(mem, 4))) {
log_error("dm_pool_alloc failed");
return NULL;
}
- repstr[0] = (pv->status & ALLOCATABLE_PV) ? 'a' : '-';
+ /*
+ * An allocatable PV is always used, so we don't need to show 'u'.
+ */
+ repstr[0] = (pv->status & ALLOCATABLE_PV) ? 'a' : (used > 0) ? 'u' : '-';
repstr[1] = (pv->status & EXPORTED_VG) ? 'x' : '-';
repstr[2] = (pv->status & MISSING_PV) ? 'm' : '-';
- repstr[3] = used <= 0 ? '-' : 'u';
return repstr;
}
diff --git a/man/pvs.8.in b/man/pvs.8.in
index 4bc042b..0e0ad92 100644
--- a/man/pvs.8.in
+++ b/man/pvs.8.in
@@ -86,7 +86,7 @@ pv_mda_used_count, pvseg_start, and pvseg_size
With \fB\-\-segments\fP, any "pvseg_" prefixes are optional; otherwise any
"pv_" prefixes are optional. Columns mentioned in \fBvgs\fP(8) can also
be chosen. The pv_attr bits are: (a)llocatable, e(x)ported, (m)issing and
-(u)sed.
+(u)sed (but not allocatable).
.TP
.B \-\-segments
Produces one line of output for each contiguous allocation of space on each
diff --git a/test/shell/pvchange-usage.sh b/test/shell/pvchange-usage.sh
index efffe18..df7893e 100644
--- a/test/shell/pvchange-usage.sh
+++ b/test/shell/pvchange-usage.sh
@@ -24,11 +24,11 @@ aux prepare_pvs 4
# check 'allocatable' pv attribute
pvcreate "$dev1"
-check pv_field "$dev1" pv_attr ----
+check pv_field "$dev1" pv_attr ---
vgcreate $vg1 "$dev1"
-check pv_field "$dev1" pv_attr a--u
+check pv_field "$dev1" pv_attr a--
pvchange --allocatable n "$dev1"
-check pv_field "$dev1" pv_attr ---u
+check pv_field "$dev1" pv_attr u--
vgremove -ff $vg1
not pvchange --allocatable y "$dev1"
pvremove -ff "$dev1"
@@ -51,10 +51,10 @@ do
# "vgchange disable/enable allocation for pvs with metadatacopies = $mda (bz452982)"
pvchange "$dev1" -x n
pvchange "$dev1" -x n # already disabled
- check pv_field "$dev1" pv_attr ---u
+ check pv_field "$dev1" pv_attr u--
pvchange "$dev1" -x y
pvchange "$dev1" -x y # already enabled
- check pv_field "$dev1" pv_attr a--u
+ check pv_field "$dev1" pv_attr a--
# check we are able to change number of managed metadata areas
if test $mda -gt 0 ; then
Gitweb: http://git.fedorahosted.org/git/?p=lvm2.git;a=commitdiff;h=183bd8ca0342f6f7…
Commit: 183bd8ca0342f6f72630afcb42b453b88ee90ac6
Parent: 2988fa3c21cf84071446bc11cb61d5b8507c088c
Author: Zdenek Kabelac <zkabelac(a)redhat.com>
AuthorDate: Fri Feb 26 08:45:06 2016 +0100
Committer: Zdenek Kabelac <zkabelac(a)redhat.com>
CommitterDate: Fri Feb 26 10:21:36 2016 +0100
tests: skip on older version
Skip with older driver version.
Update address.
---
test/shell/dmstats-create.sh | 5 ++---
test/shell/dmstats-report.sh | 8 +++++---
2 files changed, 7 insertions(+), 6 deletions(-)
diff --git a/test/shell/dmstats-create.sh b/test/shell/dmstats-create.sh
index d5db79f..028bec7 100644
--- a/test/shell/dmstats-create.sh
+++ b/test/shell/dmstats-create.sh
@@ -1,5 +1,5 @@
#!/bin/sh
-# Copyright (C) 2009-2011 Red Hat, Inc. All rights reserved.
+# Copyright (C) 2016 Red Hat, Inc. All rights reserved.
#
# This copyrighted material is made available to anyone wishing to use,
# modify, copy, or redistribute it subject to the terms and conditions
@@ -7,7 +7,7 @@
#
# You should have received a copy of the GNU General Public License
# along with this program; if not, write to the Free Software Foundation,
-# Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA
+# Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
. lib/inittest
@@ -24,4 +24,3 @@ dmstats create --start 0 --len 1 "$dev1"
dmstats create --segments "$dev1"
dmstats create --precise "$dev1"
dmstats create --bounds 10ms,20ms,30ms "$dev1"
-
diff --git a/test/shell/dmstats-report.sh b/test/shell/dmstats-report.sh
index c36e3eb..702ea61 100644
--- a/test/shell/dmstats-report.sh
+++ b/test/shell/dmstats-report.sh
@@ -1,5 +1,5 @@
#!/bin/sh
-# Copyright (C) 2009-2011 Red Hat, Inc. All rights reserved.
+# Copyright (C) 2016 Red Hat, Inc. All rights reserved.
#
# This copyrighted material is made available to anyone wishing to use,
# modify, copy, or redistribute it subject to the terms and conditions
@@ -7,10 +7,13 @@
#
# You should have received a copy of the GNU General Public License
# along with this program; if not, write to the Free Software Foundation,
-# Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA
+# Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
. lib/inittest
+# Don't attempt to test stats with driver < 4.33.00
+aux driver_at_least 4 33 || skip
+
# ensure we can create devices (uses dmsetup, etc)
aux prepare_devs 1
@@ -21,4 +24,3 @@ dmstats create --bounds 10ms,20ms,30ms "$dev1"
dmstats report
dmstats report --count 1
dmstats report --histogram
-
Gitweb: http://git.fedorahosted.org/git/?p=lvm2.git;a=commitdiff;h=2988fa3c21cf8407…
Commit: 2988fa3c21cf84071446bc11cb61d5b8507c088c
Parent: 85a593c1911f5c7ef5a8de38178b085c02ad3965
Author: Zdenek Kabelac <zkabelac(a)redhat.com>
AuthorDate: Fri Feb 26 10:15:24 2016 +0100
Committer: Zdenek Kabelac <zkabelac(a)redhat.com>
CommitterDate: Fri Feb 26 10:21:36 2016 +0100
coverity: helping coverity with NULL pointer
Helping with understanding we will not try to deref NULL pointer,
as if the sizes are initialized to NULL it also means 'mem' would
be NULL, but thats too hard to model so make it obvious.
---
libdaemon/client/config-util.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/libdaemon/client/config-util.c b/libdaemon/client/config-util.c
index 7a7dfed..e262182 100644
--- a/libdaemon/client/config-util.c
+++ b/libdaemon/client/config-util.c
@@ -366,9 +366,9 @@ int buffer_append(struct buffer *buf, const char *string)
{
int len = strlen(string);
- if ((buf->allocated - buf->used <= len) &&
+ if ((!buf->mem || (buf->allocated - buf->used <= len)) &&
!buffer_realloc(buf, len + 1))
- return 0;
+ return 0;
strcpy(buf->mem + buf->used, string);
buf->used += len;