Hi,
I wanted to install Docky 2.1.0 on my laptop, but noticed that the current version in the Fedora repos is still 2.0.x. Rather than solve the problem for me only and building the new version and its dependencies from source, I decided to be a good citizen and try to properly update the Docky package for Fedora.
I'm not finished with that yet, but I noticed that Fedora also doesn't have the dbus-sharp 0.7.0 (F15 and rawhide have 0.63) which the new Docky requires. Therefore, I would like to propose my work to update dbus-sharp to the new version. My patch (against the pkgs.fedoraproject.org repo) is attached to this message.
As dbus-sharp 0.7.0 changes the pkgconfig file name (dbus-sharp-1.0.git instead of dbus-sharp.git), I looked for reverse dependencies with repoquery against rawhide, which reveals "lat" as only package using it. I have a second patch which adjusts its configure.ac to look for dbus-sharp-1.0, and for dbus-sharp if the former fails. (I also posted the patch upstream.) The patch, including the needed spec file changes, are also attached here.
I hope the patches meet your quality expectations and can be integrated into the Fedora repository.
Regards, Denis Washington
P.S.: The dbus-sharp update removes both downstream patches as they neither seem applicable nor needed anymore (the GTK+ requirement for the examples seems to be removed).
Am 19.05.2011 14:10, schrieb Denis Washington:
I'm not finished with that yet, but I noticed that Fedora also doesn't have the dbus-sharp 0.7.0 (F15 and rawhide have 0.63) which the new Docky requires. Therefore, I would like to propose my work to update dbus-sharp to the new version. My patch (against the pkgs.fedoraproject.org repo) is attached to this message.
Forgot to mention where to find the upstream tarball, it's official position is here: http://github.com/downloads/mono/dbus-sharp/dbus-sharp-0.7.0.tar.gz
Hi Denis, Hi All,
sorry for the late reply (and the cross-posting).
On 05/19/2011 02:10 PM, Denis Washington wrote:
I'm not finished with that yet, but I noticed that Fedora also doesn't have the dbus-sharp 0.7.0 (F15 and rawhide have 0.63) which the new Docky requires. Therefore, I would like to propose my work to update dbus-sharp to the new version. My patch (against the pkgs.fedoraproject.org repo) is attached to this message.
Yep, dbus-sharp 0.7.0 (and dbus-sharp-glib-0.5.0) is needed for the new banshee 2.1.x as well.
Unfortunately, it is not that easy:
AFAIK dbus-sharp is a fork of ndesk-dbus-sharp. IMHO it is not API compatible to the original dbus-sharp from freedesktop.org. So technically it is not a simple update but a different package. Although we might be able to package it as an update, getting it reviewed again would be probably the best approach.
It looks like that the original dbus-sharp 0.63 is quite dead and besides lat nobody uses it anymore.
As dbus-sharp 0.7.0 changes the pkgconfig file name (dbus-sharp-1.0.git instead of dbus-sharp.git), I looked for reverse dependencies with repoquery against rawhide, which reveals "lat" as only package using it.
It is "lat" and "blam", although it looks like that blam actually uses ndesk-dbus and so the Requirement for dbus-sharp is just some remains from former times when blam used dbus-sharp.
@blam-owners: Please can you check whether the dbus-sharp dependencies could be entirely dropped from the blam package?
I have a second patch which adjusts its configure.ac to look for dbus-sharp-1.0, and for dbus-sharp if the former fails. (I also posted the patch upstream.) The patch, including the needed spec file changes, are also attached here.
I have tested your patch against lat:
- after patching configure.ac you have to rebuild configure during the %build section, preferably with "autoreconf -f -i"
- however, if the NetworkManager support is turned on once the configure script found dbus-sharp correctly, it does not compile anymore
That seems to be the API incompatibility I mentioned earlier.
@lat-owner, @Denis: Please can you take a look at this issue?
Best regards, Christian
mono@lists.stg.fedoraproject.org
-
Christian Krause -
Denis Washington