Re: pnemade pushed to nodejs-deep-extend (el6). "Specify exclusively arch list as per nodejs packaging guidelines"
On 13/01/16 11:43, notifications@fedoraproject.org wrote:
From 393558883ad677a3e3b6dcb74ce42a189d712576 Mon Sep 17 00:00:00 2001 From: Parag Nemade pnemade@redhat.com Date: Wed, 13 Jan 2016 10:43:33 +0530 Subject: Specify exclusively arch list as per nodejs packaging guidelines
nodejs-deep-extend.spec | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/nodejs-deep-extend.spec b/nodejs-deep-extend.spec index e34ec94..dbe09a0 100644 --- a/nodejs-deep-extend.spec +++ b/nodejs-deep-extend.spec @@ -5,14 +5,14 @@
Name: nodejs-%{module_name} Version: 0.3.2 -Release: 1%{?dist} +Release: 2%{?dist} Summary: Recursive object extending
License: MIT URL: https://github.com/unclechu/node-deep-extend Source0: http://registry.npmjs.org/%%7Bmodule_name%7D/-/%%7Bmodule_name%7D-%%7Bversio... BuildArch: noarch -ExclusiveArch: %{nodejs_arches} noarch +ExclusiveArch: %{ix86} x86_64 %{arm} noarch
This is the exact opposite of what the guidelines say surely?
The whole point of adding the nodejs_arches macro was to avoid having the list of supported architectures embedded in all the spec files, so that they could be extended in future without changing every spec.
Tom
On Wed, Jan 13, 2016 at 12:45 PM, Tom Hughes tom@compton.nu wrote:
On 13/01/16 11:43, notifications@fedoraproject.org wrote:
From 393558883ad677a3e3b6dcb74ce42a189d712576 Mon Sep 17 00:00:00 2001 From: Parag Nemade pnemade@redhat.com Date: Wed, 13 Jan 2016 10:43:33 +0530 Subject: Specify exclusively arch list as per nodejs packaging guidelines
nodejs-deep-extend.spec | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/nodejs-deep-extend.spec b/nodejs-deep-extend.spec index e34ec94..dbe09a0 100644 --- a/nodejs-deep-extend.spec +++ b/nodejs-deep-extend.spec @@ -5,14 +5,14 @@
Name: nodejs-%{module_name} Version: 0.3.2 -Release: 1%{?dist} +Release: 2%{?dist} Summary: Recursive object extending
License: MIT URL: https://github.com/unclechu/node-deep-extend Source0: http://registry.npmjs.org/%%7Bmodule_name%7D/-/%%7Bmodule_name%7D-%%7Bversio... BuildArch: noarch -ExclusiveArch: %{nodejs_arches} noarch +ExclusiveArch: %{ix86} x86_64 %{arm} noarch
This is the exact opposite of what the guidelines say surely?
The whole point of adding the nodejs_arches macro was to avoid having the list of supported architectures embedded in all the spec files, so that they could be extended in future without changing every spec.
This macros is unavailable on el6. (but is available on epel7 and all active Fedora branches).
I'm using:
%if 0%{?rhel} == 6 ExclusiveArch: %{ix86} x86_64 %{arm} noarch %else ExclusiveArch: %{nodejs_arches} noarch %endif
The previous version of the guidelines had an conditional on rhel (without version), I don't know why it is removed.
Tom
-- Tom Hughes (tom@compton.nu) http://compton.nu/ _______________________________________________ nodejs mailing list nodejs@lists.fedoraproject.org http://lists.fedoraproject.org/admin/lists/nodejs@lists.fedoraproject.org
On 13/01/16 13:09, Piotr Popieluch wrote:
On Wed, Jan 13, 2016 at 12:45 PM, Tom Hughes <tom@compton.nu mailto:tom@compton.nu> wrote:
On 13/01/16 11:43, notifications@fedoraproject.org <mailto:notifications@fedoraproject.org> wrote: From 393558883ad677a3e3b6dcb74ce42a189d712576 Mon Sep 17 00:00:00 2001 From: Parag Nemade <pnemade@redhat.com <mailto:pnemade@redhat.com>> Date: Wed, 13 Jan 2016 10:43:33 +0530 Subject: Specify exclusively arch list as per nodejs packaging guidelines --- nodejs-deep-extend.spec | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/nodejs-deep-extend.spec b/nodejs-deep-extend.spec index e34ec94..dbe09a0 100644 --- a/nodejs-deep-extend.spec +++ b/nodejs-deep-extend.spec @@ -5,14 +5,14 @@ Name: nodejs-%{module_name} Version: 0.3.2 -Release: 1%{?dist} +Release: 2%{?dist} Summary: Recursive object extending License: MIT URL: https://github.com/unclechu/node-deep-extend Source0: http://registry.npmjs.org/%{module_name}/-/%{module_name}-%{version}.tgz BuildArch: noarch -ExclusiveArch: %{nodejs_arches} noarch +ExclusiveArch: %{ix86} x86_64 %{arm} noarch This is the exact opposite of what the guidelines say surely? The whole point of adding the nodejs_arches macro was to avoid having the list of supported architectures embedded in all the spec files, so that they could be extended in future without changing every spec.This macros is unavailable on el6. (but is available on epel7 and all active Fedora branches).
I'm using:
%if 0%{?rhel} == 6 ExclusiveArch: %{ix86} x86_64 %{arm} noarch %else ExclusiveArch: %{nodejs_arches} noarch %endif
The previous version of the guidelines had an conditional on rhel (without version), I don't know why it is removed.
But that commit was on the epel7 branch wasn't it? Which should have the macro?
Tom
Hi Tom,
On Wed, Jan 13, 2016 at 6:43 PM, Tom Hughes tom@compton.nu wrote:
On 13/01/16 13:09, Piotr Popieluch wrote:
On Wed, Jan 13, 2016 at 12:45 PM, Tom Hughes <tom@compton.nu mailto:tom@compton.nu> wrote:
On 13/01/16 11:43, notifications@fedoraproject.org <mailto:notifications@fedoraproject.org> wrote: From 393558883ad677a3e3b6dcb74ce42a189d712576 Mon Sep 17 00:00:00 2001 From: Parag Nemade <pnemade@redhat.comDate: Wed, 13 Jan 2016 10:43:33 +0530 Subject: Specify exclusively arch list as per nodejs packaging guidelines --- nodejs-deep-extend.spec | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/nodejs-deep-extend.spec b/nodejs-deep-extend.spec index e34ec94..dbe09a0 100644 --- a/nodejs-deep-extend.spec +++ b/nodejs-deep-extend.spec @@ -5,14 +5,14 @@ Name: nodejs-%{module_name} Version: 0.3.2 -Release: 1%{?dist} +Release: 2%{?dist} Summary: Recursive object extending License: MIT URL: https://github.com/unclechu/node-deep-extend Source0:http://registry.npmjs.org/%%7Bmodule_name%7D/-/%%7Bmodule_name%7D-%%7Bversio... BuildArch: noarch -ExclusiveArch: %{nodejs_arches} noarch +ExclusiveArch: %{ix86} x86_64 %{arm} noarch
This is the exact opposite of what the guidelines say surely? The whole point of adding the nodejs_arches macro was to avoid having the list of supported architectures embedded in all the spec files, so that they could be extended in future without changing every spec.This macros is unavailable on el6. (but is available on epel7 and all active Fedora branches).
I'm using:
%if 0%{?rhel} == 6 ExclusiveArch: %{ix86} x86_64 %{arm} noarch %else ExclusiveArch: %{nodejs_arches} noarch %endif
The previous version of the guidelines had an conditional on rhel (without version), I don't know why it is removed.
But that commit was on the epel7 branch wasn't it? Which should have the macro?
Yes you are right. The guidelines are not clear. I am not sure if someone removed EPEL7 specific information but as of these days I am not able to find that information in the nodejs packaging guidelines. Therefore, I started adding dependency generator, expanded macro to epel7 as well. The problem I found is that if I use that macro and build the package then only srpm will appear in epel srpm repository and corresponding binary noarch rpm will not get composed in repository at all.
See this ticket https://fedorahosted.org/rel-eng/ticket/6323
Regards, Parag.
On 13/01/16 13:58, Parag Nemade wrote:
Yes you are right. The guidelines are not clear. I am not sure if someone removed EPEL7 specific information but as of these days I am not able to find that information in the nodejs packaging guidelines. Therefore, I started adding dependency generator, expanded macro to epel7 as well. The problem I found is that if I use that macro and build the package then only srpm will appear in epel srpm repository and corresponding binary noarch rpm will not get composed in repository at all.
See this ticket https://fedorahosted.org/rel-eng/ticket/6323
That ticket is about EPEL6 though, where the macro isn't defined!
I don't have an EPEL7 machine to check, but does it not have a redhat-rpm-config that contains /usr/lib/rpm/macros.d/macros.nodejs-srpm which defines the nodejs_arches macro?
Tom
Hi Tom,
On Wed, Jan 13, 2016 at 7:40 PM, Tom Hughes tom@compton.nu wrote:
On 13/01/16 13:58, Parag Nemade wrote:
Yes you are right. The guidelines are not clear. I am not sure if someone removed EPEL7 specific information but as of these days I am not able to find that information in the nodejs packaging guidelines. Therefore, I started adding dependency generator, expanded macro to epel7 as well. The problem I found is that if I use that macro and build the package then only srpm will appear in epel srpm repository and corresponding binary noarch rpm will not get composed in repository at all.
See this ticket https://fedorahosted.org/rel-eng/ticket/6323
That ticket is about EPEL6 though, where the macro isn't defined!
I don't have an EPEL7 machine to check, but does it not have a redhat-rpm-config that contains /usr/lib/rpm/macros.d/macros.nodejs-srpm which defines the nodejs_arches macro?
Yes redhat-rpm-config provides that macro in /etc/rpm/macros.nodejs-srpm file.
Do you want me to re-add that macro in the packages? Good to update the nodejs packaging guidelines page as well to add this information.
How about adding separate package say nodejs-rpm-macros in EPEL6 that will provide this macro?
Regards, Parag.
On Wed, Jan 13, 2016 at 3:18 PM, Parag Nemade pnemade@redhat.com wrote:
Hi Tom,
On Wed, Jan 13, 2016 at 7:40 PM, Tom Hughes tom@compton.nu wrote:
On 13/01/16 13:58, Parag Nemade wrote:
Yes you are right. The guidelines are not clear. I am not sure if someone removed EPEL7 specific information but as of these days I am not able to find that information in the nodejs packaging guidelines. Therefore, I started adding dependency generator, expanded macro to epel7 as well. The problem I found is that if I use that macro and build the package then only srpm will appear in epel srpm repository and corresponding binary noarch rpm will not get composed in repository at all.
See this ticket https://fedorahosted.org/rel-eng/ticket/6323
That ticket is about EPEL6 though, where the macro isn't defined!
I don't have an EPEL7 machine to check, but does it not have a redhat-rpm-config that contains /usr/lib/rpm/macros.d/macros.nodejs-srpm which defines the nodejs_arches macro?
Yes redhat-rpm-config provides that macro in /etc/rpm/macros.nodejs-srpm file.
Do you want me to re-add that macro in the packages? Good to update the nodejs packaging guidelines page as well to add this information.
How about adding separate package say nodejs-rpm-macros in EPEL6 that
will provide this macro?
Jason Tibbits is working on a rpm with missing macros for EPEL6, i've requested him to add the nodejs_arches and nodejs_find_provides_and_requires. I didn't get a confirmation, so you might better ask him again.
Regards, Parag. _______________________________________________ nodejs mailing list nodejs@lists.fedoraproject.org http://lists.fedoraproject.org/admin/lists/nodejs@lists.fedoraproject.org
Hi Piotr,
On Wed, Jan 13, 2016 at 7:57 PM, Piotr Popieluch piotr1212@gmail.com wrote:
On Wed, Jan 13, 2016 at 3:18 PM, Parag Nemade pnemade@redhat.com wrote:
Hi Tom,
On Wed, Jan 13, 2016 at 7:40 PM, Tom Hughes tom@compton.nu wrote:
On 13/01/16 13:58, Parag Nemade wrote:
Yes you are right. The guidelines are not clear. I am not sure if someone removed EPEL7 specific information but as of these days I am not able to find that information in the nodejs packaging guidelines. Therefore, I started adding dependency generator, expanded macro to epel7 as well. The problem I found is that if I use that macro and build the package then only srpm will appear in epel srpm repository and corresponding binary noarch rpm will not get composed in repository at all.
See this ticket https://fedorahosted.org/rel-eng/ticket/6323
That ticket is about EPEL6 though, where the macro isn't defined!
I don't have an EPEL7 machine to check, but does it not have a redhat-rpm-config that contains /usr/lib/rpm/macros.d/macros.nodejs-srpm which defines the nodejs_arches macro?
Yes redhat-rpm-config provides that macro in /etc/rpm/macros.nodejs-srpm file.
Do you want me to re-add that macro in the packages? Good to update the nodejs packaging guidelines page as well to add this information.
How about adding separate package say nodejs-rpm-macros in EPEL6 that
will provide this macro?
Jason Tibbits is working on a rpm with missing macros for EPEL6, i've requested him to add the nodejs_arches and nodejs_find_provides_and_requires. I didn't get a confirmation, so you might better ask him again.
I too requested for nodejs_arches macro in the same thread but tibbs has not answered yet. I better file FPC ticket to change guidelines text for EPEL7 and request for this macro to be added to rpm-redhat-config package.
Regards, Parag.
On Wed, Jan 13, 2016 at 8:08 PM, Parag Nemade pnemade@redhat.com wrote:
Hi Piotr,
On Wed, Jan 13, 2016 at 7:57 PM, Piotr Popieluch piotr1212@gmail.com wrote:
On Wed, Jan 13, 2016 at 3:18 PM, Parag Nemade pnemade@redhat.com wrote:
Hi Tom,
On Wed, Jan 13, 2016 at 7:40 PM, Tom Hughes tom@compton.nu wrote:
On 13/01/16 13:58, Parag Nemade wrote:
Yes you are right. The guidelines are not clear. I am not sure if someone removed EPEL7 specific information but as of these days I am not able to find that information in the nodejs packaging guidelines. Therefore, I started adding dependency generator, expanded macro to epel7 as well. The problem I found is that if I use that macro and build the package then only srpm will appear in epel srpm repository and corresponding binary noarch rpm will not get composed in repository at all.
See this ticket https://fedorahosted.org/rel-eng/ticket/6323
That ticket is about EPEL6 though, where the macro isn't defined!
I don't have an EPEL7 machine to check, but does it not have a redhat-rpm-config that contains /usr/lib/rpm/macros.d/macros.nodejs-srpm which defines the nodejs_arches macro?
Yes redhat-rpm-config provides that macro in /etc/rpm/macros.nodejs-srpm file.
Do you want me to re-add that macro in the packages? Good to update the nodejs packaging guidelines page as well to add this information.
How about adding separate package say nodejs-rpm-macros in EPEL6 that
will provide this macro?
Jason Tibbits is working on a rpm with missing macros for EPEL6, i've requested him to add the nodejs_arches and nodejs_find_provides_and_requires. I didn't get a confirmation, so you might better ask him again.
I too requested for nodejs_arches macro in the same thread but tibbs has not answered yet. I better file FPC ticket to change guidelines text for EPEL7 and request for this macro to be added to rpm-redhat-config package.
Reported FPC ticket -> https://fedorahosted.org/fpc/ticket/589 and also modified EPEL guidelines as well -> https://fedoraproject.org/wiki/EPEL:Packaging#Node.js
Once that macro become available in EPEL6 stable, I will rebuild my nodejs EPEL packages to use %{nodejs_arches} macro wherever its needed.
Thanks. Parag.
nodejs@lists.fedoraproject.org
-
Parag Nemade -
Piotr Popieluch -
Tom Hughes