On Thursday, January 23, 2014 16:28:28 Kai Engert wrote:
On Do, 2014-01-23 at 12:23 +0100, Kai Engert wrote:
> do you allow me to apply
> to https://git.fedorahosted.org/cgit/nss-pem.git/
Kamil has done that in the meantime, thanks!
> I notice that file rsawrapr.c has several sections that are disabled
> #if 0
> For better readability, I would like to
> - either remove those blocks
> - or move those blocks to a separate file rsawrapr-unsused.c
> Is that ok? Any preference?
Also in the meantime, I've started this ticket:
that suggests to avoid the copies of NSS RSA code that we currently have
in file rsawrapr.c
In that ticket, I've suggested a modification to function pem_RSA_Sign.
I believe the change is functionally equivalent.
Thank you for working on this, Kai!
As a result of that change, a lot of code in file rsawrapr.c would
I've attached a full patch to the ticket, which removes all the code
that's no longer necessary to build, and moved it to the new file
If you cannot think of a good reason to keep the old code, we could
simply remove them completely (and not create rsawrapr-unused.c)
I vote for just removing the unused code. It is pretty easy to look it up
in the git repository anytime later.