-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/219/
-----------------------------------------------------------
Review request for OpenLMI Developers.
Repository: openlmi-storage
Description
-------
Simplify error handling of FormatProvider.get_format_for_id and get_format_for_name.
With tuple (None, None) returned, following code can be used for error
handling:
(device, fmt) = fmtprovider.get_format_for_name(...)
if not device:
raise ...
With None, the unpacking would not be possible.
Also extend the documentation to explicitly state which device is returned.
Diffs
-----
src/openlmi/storage/FormatProvider.py 611e9012ea9fbecae788cb1bfa1c635ff4f16c33
Diff: http://reviewboard-openlmi.rhcloud.com/r/219/diff/
Testing
-------
Thanks,
Jan Safranek
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/218/
-----------------------------------------------------------
Review request for OpenLMI Developers.
Repository: openlmi-storage
Description
-------
Extend the test suite with setting expiration.
Diffs
-----
src/openlmi/storage/LMI_StorageConfigurationService.py 8ea10fbff155d627873c71bd09890a1bb1bb5341
test/unit/config/test_unit_settings.py b33edb2e12ce9e5d4b8d41418683405af91c3182
Diff: http://reviewboard-openlmi.rhcloud.com/r/218/diff/
Testing
-------
Thanks,
Jan Safranek
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/217/
-----------------------------------------------------------
Review request for OpenLMI Developers.
Repository: openlmi-storage
Description
-------
Fixed Setting test suite with new logging and new Setting constructor.
Diffs
-----
test/unit/config/test_unit_settings.py b33edb2e12ce9e5d4b8d41418683405af91c3182
Diff: http://reviewboard-openlmi.rhcloud.com/r/217/diff/
Testing
-------
Thanks,
Jan Safranek
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/214/
-----------------------------------------------------------
Review request for OpenLMI Developers.
Repository: openlmi-storage
Description
-------
'Touch' used settings in all methods.
If a method uses Setting object, we must restart its timer for garbage
collection.
Diffs
-----
src/openlmi/storage/LMI_DiskPartitioningConfigurationService.py 4087de3e0cc3ab20fea9176a3ee43fad3cd25354
src/openlmi/storage/LMI_FileSystemConfigurationService.py 32f15febfaab9528f974081c503eb588b89c2f0a
src/openlmi/storage/LMI_StorageConfigurationService.py 8ea10fbff155d627873c71bd09890a1bb1bb5341
Diff: http://reviewboard-openlmi.rhcloud.com/r/214/diff/
Testing
-------
Thanks,
Jan Safranek
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/215/
-----------------------------------------------------------
Review request for OpenLMI Developers.
Repository: openlmi-storage
Description
-------
Update logger test to new .conf file structure.
Diffs
-----
test/unit/test_unit_logging.py 32e8fc8cdc0650b3b6734beeb1e689795f65ccf9
Diff: http://reviewboard-openlmi.rhcloud.com/r/215/diff/
Testing
-------
Thanks,
Jan Safranek
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/210/
-----------------------------------------------------------
Review request for OpenLMI Developers.
Repository: openlmi-storage
Description
-------
Fixed ParityLayoutDefault type in LMI_VGStorageCapabilities.
Diffs
-----
src/openlmi/storage/LMI_VGStorageCapabilities.py fe89b6d432d829f1e4d17557933a3d20117261e3
Diff: http://reviewboard-openlmi.rhcloud.com/r/210/diff/
Testing
-------
Thanks,
Jan Safranek
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/208/
-----------------------------------------------------------
Review request for OpenLMI Developers.
Repository: openlmi-providers
Description
-------
Use UTC times for all wall clock times.
clocktime_of_last_state_change was in local time.
Diffs
-----
src/python/openlmi/common/JobManager.py bb6fed806de5c2e47d67d3261159a33625bfadce
Diff: http://reviewboard-openlmi.rhcloud.com/r/208/diff/
Testing
-------
Thanks,
Jan Safranek