-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/701/
-----------------------------------------------------------
(Updated Sept. 19, 2013, 1:16 p.m.)
Status
------
This change has been marked as submitted.
Review request for OpenLMI Developers.
Repository: openlmi-tools
Description
-------
When retrieving constant values from either LMIClass or LMIMethod, cast them to python/lmishell native types before returning.
Diffs
-----
cli/lmi/shell/LMIUtil.py 5954b9650f358e53fb75e08d9aac30365be8964f
cli/lmi/shell/LMIConstantValues.py 6e564ac413f3fbcb0afc3a8406b55d7701a3ab71
Diff: http://reviewboard-openlmi.rhcloud.com/r/701/diff/
Testing
-------
Thanks,
Peter Hatina
_______________________________________________
openlmi-reviews mailing list
openlmi-reviews(a)lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/openlmi-reviews
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/699/
-----------------------------------------------------------
(Updated Sept. 19, 2013, 1:16 p.m.)
Status
------
This change has been marked as submitted.
Review request for OpenLMI Developers.
Repository: openlmi-tools
Description
-------
lmi_isinstance is a LMIShell helper function, which checks if provided LMIInstance/LMIInstanceName is instance of provided LMIClass.
Example usage:
> cimv2 = c.root.cimv2
> se = cimv2.LMI_StorageExtent.first_instance()
> lmi_isinstance(se, cimv2.LMI_StorageExtent)
True
> lmi_isinstance(se, cimv2.CIM_StorageExtent)
True
> lmi_isinstance(se, cimv2.CIM_FileSystem)
False
Diffs
-----
cli/lmi/shell/LMIBaseClient.py 2ef94cc6266b59b22928585f1b99194f2935782d
cli/lmi/shell/LMIConsole.py 2c28d36fcc47d5cf1f1cc9959ba77c002c458f0b
cli/lmi/shell/LMIInstanceName.py 91406c453091c094f10a91e34a07667f1660b2c4
cli/lmi/shell/LMIShellCache.py bca32ebbf801ada326911d9a738e7f0726b55216
cli/lmi/shell/LMIShellClient.py eb850600d1d527ffc843f4fd233616259c7a2013
cli/lmi/shell/LMIUtil.py 618ee42634e70390d85a23c5a0b1d6c77c62db33
Diff: http://reviewboard-openlmi.rhcloud.com/r/699/diff/
Testing
-------
Thanks,
Peter Hatina
_______________________________________________
openlmi-reviews mailing list
openlmi-reviews(a)lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/openlmi-reviews
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/692/
-----------------------------------------------------------
(Updated Sept. 19, 2013, 1:16 p.m.)
Status
------
This change has been marked as submitted.
Review request for OpenLMI Developers.
Repository: openlmi-tools
Description
-------
This patch fixes class names in wrapped LMIInstance objects.
Diffs
-----
cli/lmi/shell/LMIClass.py 23bcb8a7e789ef495d21e879c115f89f8780c795
Diff: http://reviewboard-openlmi.rhcloud.com/r/692/diff/
Testing
-------
Thanks,
Peter Hatina
_______________________________________________
openlmi-reviews mailing list
openlmi-reviews(a)lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/openlmi-reviews
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/691/
-----------------------------------------------------------
(Updated Sept. 19, 2013, 1:16 p.m.)
Status
------
This change has been marked as submitted.
Review request for OpenLMI Developers.
Repository: openlmi-tools
Description
-------
By this patch, all the wrapper classes (LMINamespace, LMIClass, LMIInstance{Name}, LMIMethod) have now property "connection", which returns the former LMIConnection object retrieved by connect().
Diffs
-----
cli/lmi/shell/LMIBaseObject.py 08d05513892c68388d76730652df1d07ced626f9
cli/lmi/shell/LMIClass.py 5e8db27847d9ddefb7883946b8ae8fe65faf5eee
cli/lmi/shell/LMIConnection.py 786fdd578b06873fe51528acaca575cde00133c7
cli/lmi/shell/LMIInstance.py af83f647b0037a259d0e5fdfefbd0176ead41dba
cli/lmi/shell/LMIInstanceName.py 20440cb20af0671a927de547d3537f5206cd7a50
cli/lmi/shell/LMIMethod.py 3a05740aab526f9cf3f35b2ae6d33e0555c5572f
cli/lmi/shell/LMINamespace.py 72a5f4d88d370768fe58c9796cfc1c45b14ad036
cli/lmi/shell/LMIUtil.py 370c073a22c2461428c066d019326d9941235679
Diff: http://reviewboard-openlmi.rhcloud.com/r/691/diff/
Testing
-------
Thanks,
Peter Hatina
_______________________________________________
openlmi-reviews mailing list
openlmi-reviews(a)lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/openlmi-reviews
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/677/
-----------------------------------------------------------
(Updated Sept. 19, 2013, 1:15 p.m.)
Status
------
This change has been marked as submitted.
Review request for OpenLMI Developers.
Repository: openlmi-tools
Description
-------
This patch finishes so-called synchronous method calls in terms of proper return value, parameters and error string set.
Diffs
-----
cli/lmi/shell/LMIMethod.py 6b604625998aa2dc88b9ebed2c9e65299b2b91b2
Diff: http://reviewboard-openlmi.rhcloud.com/r/677/diff/
Testing
-------
Tested with openlmi-storage provider.
Thanks,
Peter Hatina
_______________________________________________
openlmi-reviews mailing list
openlmi-reviews(a)lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/openlmi-reviews
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/568/
-----------------------------------------------------------
(Updated Sept. 19, 2013, 1:13 p.m.)
Status
------
This change has been marked as submitted.
Review request for OpenLMI Developers.
Repository: openlmi-tools
Description
-------
This patch introduces the access to contant values present either in the CIMClass or in the CIMMethod.
To access desired contant, do following (eg. storage provider):
> conf_class = c.root.cimv2.LMI_FileSystemConfigurationService
> conf_class.OperatingStatusValues.Completed
8
For quick list, just type following:
> conf_class.OperatingStatusValues
Dormant = 7
Immigrating = 11
Unknown = 0
Completed = 8
InService = 16
ShuttingDown = 13
InTest = 14
Stopping = 4
Stopped = 5
Servicing = 2
Aborted = 6
NotAvailable = 1
Snapshotting = 12
Transitioning = 15
Migrating = 9
Starting = 3
Emigrating = 10
>
Similar action can be performed within method:
> conf_service = conf_class.first_instance()
> conf_service.RequestStateChange.RequestedStateValues.Enabled
2
>
Diffs
-----
cli-tools/lmi/lmi_client_shell.py 8c25cece6c0782f77b47d1888f9f031691b27a4b
cli-tools/lmishell bbbe0df89844320c84c8445699046c656d058fd9
Diff: http://reviewboard-openlmi.rhcloud.com/r/568/diff/
Testing
-------
Thanks,
Peter Hatina
_______________________________________________
openlmi-reviews mailing list
openlmi-reviews(a)lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/openlmi-reviews
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/549/
-----------------------------------------------------------
(Updated Sept. 19, 2013, 1:12 p.m.)
Status
------
This change has been marked as submitted.
Review request for OpenLMI Developers.
Repository: openlmi-tools
Description
-------
By this patch, we introduce a feature, which enables LMIShell to perform synchronous method calls. In other words, when there is a method call executed, which returns a CIM_ConcretJob object (derived from), LMIShell is able to either subscribe an indication and then wait for the job to finish and return job output parameters. If the shell is not able to use indications (can not start tcp server), then it uses "blind" polling as the waiting method. Indication method of waiting also checks the JobState value of the object to prevent the shell from infinite waiting.
To invoke a "synchro" method, see following (example with filesystem):
> ... some stuff to get necessary objects ...
> conf_service.SyncLMI_CreateFileSystem(FileSystemType = 11, InExtents = [sda1])
^^^^
The prefix "Sync" is also added to interactive interface (tab-completion).
Question 1)
As the patch of a version 1, there is only unsecure http used for indication delivery. The question is: what kind of certificate to use, do we generate some for the shell at install time, or use some existing? Please, tell me your opinion.
Question 2)
Can we setup Pegasus to permit other users to create objects in the namespace PG_InterOp? In the example below, there is root account used, other users for me with default Pegasus setup can not create indication handler and subscription objects. Now, the shell will fail to get necessary static filter instance (used for the subscription) and will fail to call "synchro" method.
Diffs
-----
cli-tools/lmi/__init__.py e69de29bb2d1d6434b8b29ae775ad8c2e48c5391
cli-tools/lmi/lmi_client_shell.py 9a6788cc17582f7c4419df909cd4322d9e6b23f9
cli-tools/lmi/lmi_listener.py 6670b204a84485b6e1f8bef5dfa2893098f0a9da
cli-tools/lmishell a12233eedc159a6f6c570ca31dfff20ac6d17161
Diff: http://reviewboard-openlmi.rhcloud.com/r/549/diff/
Testing
-------
Tested with storage provider.
> c = connect("hostname", "root", "root")
> sda = c.root.cimv2.LMI_StorageExtent.first_instance({"ElementName" : "sda"})
> basedon = sda.first_reference(ResultClass = "LMI_PartitionBasedOn")
> sda1 = basedon.Dependent.to_instance()
> conf_service = c.root.cimv2.LMI_FileSystemConfigurationService.first_instance()
> (ret, out, err) = conf_service.SyncLMI_CreateFileSystem(FileSystemType = 11, InExtents = [sda1])
> print "%s\n%s\n%s" % (ret, out, err)
4096
NocaseDict({'out': _LmiInstance(classname='CIM_ManagedElement', ...)})
Note: see return value and output parameters (ret == 4096, out['out'] == _LmiInstance(...)) <- this will be changed once we have Pegasus fixed. Now synchro method does not modify return value of the method, therefore you can find 4096 in the result. Once we have proper values in output parameters (Job.JobOutParameters), return code and return parameters will be modified respectively.
Thanks,
Peter Hatina
_______________________________________________
openlmi-reviews mailing list
openlmi-reviews(a)lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/openlmi-reviews