| This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/879/ |
Ship it!
Those are just nitpicks, feel free to ship it.
| src/logicalfile/doc/source/conf.py (Diff revision 1) | |||
|---|---|---|---|
| 50 | version = '0.1' |
||
| 51 | # The full version, including alpha/beta/rc tags. |
||
| 52 | release = '0.1' |
||
Shouldn't be version 0.2 to match version of providers?
| src/logicalfile/doc/source/usage.rst (Diff revision 1) | |||
|---|---|---|---|
| 50 | No classes that represent files have the ``EnumInstances`` method |
||
EnumInstances is just a shortcut used by konkret. Official name is EnumerateInstances.
| src/logicalfile/doc/source/usage.rst (Diff revision 1) | |||
|---|---|---|---|
| 114 | 'FSCreationClassName':'LMI_LocalFileSystem', |
||
Does this property really need to be used? User might not know whether is the home directory local.
| src/logicalfile/doc/source/usage.rst (Diff revision 1) | |||
|---|---|---|---|
| 153 | symlink = unixsymlink.associators(AssocClass='LMI_FileIdentity')[0] |
||
Use first_associator(...) instead of associators(...)[0], it's more readable.
- Radek Novacek
On September 19th, 2013, 2:09 p.m. CEST, Jan Synacek wrote:
|
Review request for OpenLMI Developers.
By Jan Synacek.
Updated Sept. 19, 2013, 2:09 p.m.
Repository:
openlmi-providers
Description
Diffs
|