Ship it!
Wrong argument order, according to the cmake docs, it should be:
pkg_check_modules(<PREFIX> [REQUIRED] [QUIET] <MODULE> [<MODULE>]*)
so:
pkg_check_modules(DBUS1 REQUIRED dbus-1)
pkg_check_modules(GLIB2 REQUIRED glib-2.0)
Why is it here? -Wall CFlag is already specified in top-level CMakeLists.txt.
The FIXME seems not valid any more.
Most of this document should be merged to top-level readme, only parts related to Realmd provider should be here.
src/realmd/rdcp_dbus.c
(Diff revision 1)
|
|
|
120 |
switch (message_type) |
|
|
121 |
{ |
|
|
122 |
case DBUS_MESSAGE_TYPE_SIGNAL: |
|
|
123 |
return "signal"; |
|
|
124 |
case DBUS_MESSAGE_TYPE_METHOD_CALL: |
|
|
125 |
return "method call"; |
|
|
126 |
case DBUS_MESSAGE_TYPE_METHOD_RETURN: |
|
|
127 |
return "method return"; |
|
|
128 |
case DBUS_MESSAGE_TYPE_ERROR: |
|
|
129 |
return "error"; |
|
|
130 |
default: |
|
|
131 |
return "(unknown message type)"; |
This code don't follow coding conventions:
https://fedorahosted.org/openlmi/wiki/CodingConventions
Please reformat this file using 4 space indentation.
Those are mostly minor nitpicks, feel free to push it.
- Radek
On April 23rd, 2013, 10:14 a.m. CEST, Tomas Smetana wrote:
Review request for OpenLMI Developers.
By Tomas Smetana.
Updated April 23, 2013, 10:14 a.m.
Repository:
openlmi-providers
Description
This is the John Dennis' RealmD provider merged into the openlmi-providers tree. I have not included the tools scripts and left out the spec file. I had to also add LMI_RealmdService_ChangeAffectedElementsAssignedSequence() function stub to avoid linker error with --no-undefined.
Please let me know if this is OK.
|
Diffs
- CMakeLists.txt (b42debc577a53ece07682bfbdaeb32cf88919c67)
- mof/LMI_Realmd.mof (PRE-CREATION)
- src/CMakeLists.txt (6bf4b8519168a1629faf3e4d0dd5e81435215276)
- src/realmd/CMakeLists.txt (PRE-CREATION)
- src/realmd/LMI_HostedRealmdServiceProvider.c (PRE-CREATION)
- src/realmd/LMI_RealmdKerberosRealmProvider.c (PRE-CREATION)
- src/realmd/LMI_RealmdRealmProvider.c (PRE-CREATION)
- src/realmd/LMI_RealmdServiceProvider.c (PRE-CREATION)
- src/realmd/LMI_ServiceAffectsRealmdRealmProvider.c (PRE-CREATION)
- src/realmd/README (PRE-CREATION)
- src/realmd/VERSION (PRE-CREATION)
- src/realmd/doc/class_diagram.svg (PRE-CREATION)
- src/realmd/doc/examples/realmd-cim (PRE-CREATION)
- src/realmd/rdcp_dbus.h (PRE-CREATION)
- src/realmd/rdcp_dbus.c (PRE-CREATION)
- src/realmd/rdcp_error.h (PRE-CREATION)
- src/realmd/rdcp_error.c (PRE-CREATION)
- src/realmd/rdcp_realmdrealm.h (PRE-CREATION)
- src/realmd/rdcp_util.h (PRE-CREATION)
- src/realmd/rdcp_util.c (PRE-CREATION)
- src/realmd/realm-dbus-constants.h (PRE-CREATION)
View Diff
|