On 04/25/2014 12:21 PM, Jan Safranek wrote:
On 04/24/2014 02:39 PM, Pavel Březina wrote:
Hi, latest version can be found at: http://bit.ly/1iQkNjE
It completely separates domains and processes. Domains and subdomains are both of class LMI_SSSDDomain. They are distinguished only by flag and topology given by LMI_SSSDDomainSubdomain association.
The design looks just fine. Few minor nits:
[Description("Enable this component. SSSD has to be restarted in order " "this change to take any effect.")] uint32 Enable();If a method returns uint32, it should describe what the integer means, like:
[Description("Permanently change debug level of this component."), ValueMap { "0", "1", "2" }, Values { "Success", "Failed", "Invalid arguments" }] uint32 SetDebugLevelPermanently([In] uint16 debug_level);
Fixed.
Define error codes as you find appropriate, the above is just suggestion.
[Description("The output format this domain uses.")] string OutputFormat;I have no idea what 'output of a domain' could be, it sounds really strange to me. Anyway, I just hope that the name and its description makes some sense to average SSSD user/admin, my feelings are irrelevant here.
Its the how users from the domain are presented in the system. I.e. user@domain or DOMAIN\user, etc. It is expected to be known by admins.
Do you need any other help with the provider? I think the mof file does not need any further review.
Jan
Thank you for the review. I'll start working on the implementation. And send patches for review when ready.