This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/252/ |
On April 23rd, 2013, 3 p.m. CEST, Radek Novacek wrote:
src/realmd/CMakeLists.txt (Diff revision 1) 20 set(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} -Wall")Why is it here? -Wall CFlag is already specified in top-level CMakeLists.txt.
It's not there any more.
On April 23rd, 2013, 3 p.m. CEST, Radek Novacek wrote:
src/realmd/CMakeLists.txt (Diff revision 1) 33 # FIXME - /usr/include/openlmi shouldn't be hardcoded, needed for globals.h
The FIXME seems not valid any more.
...and has been removed too.
On April 23rd, 2013, 3 p.m. CEST, Radek Novacek wrote:
src/realmd/README (Diff revision 1) 1 Realmd CIM ProviderMost of this document should be merged to top-level readme, only parts related to Realmd provider should be here.
I have merged the "Development tips" section to the root-level README, added some RealmD description, and left only FAQ and TODO sections in the RealmD specific document.
On April 23rd, 2013, 3 p.m. CEST, Radek Novacek wrote:
src/realmd/rdcp_dbus.c (Diff revision 1) 120 switch (message_type)121 {
122 case DBUS_MESSAGE_TYPE_SIGNAL:123 return "signal";124 case DBUS_MESSAGE_TYPE_METHOD_CALL:125 return "method call";126 case DBUS_MESSAGE_TYPE_METHOD_RETURN:127 return "method return";128 case DBUS_MESSAGE_TYPE_ERROR:129 return "error";130 default:
131 return "(unknown message type)";This code don't follow coding conventions: https://fedorahosted.org/openlmi/wiki/CodingConventions Please reformat this file using 4 space indentation.
Done.
- Tomas
On April 23rd, 2013, 10:14 a.m. CEST, Tomas Smetana wrote:
Review request for OpenLMI Developers.
By Tomas Smetana.
Updated April 23, 2013, 10:14 a.m.
Repository:
openlmi-providers
Description
Diffs
|