----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/851/#review1181 -----------------------------------------------------------

Ship it!

src/service-dbus/LMI_ServiceProvider.c http://reviewboard-openlmi.rhcloud.com/r/851/#comment735

This is not readable, use enum for return codes or at least add comment here.

- Radek Novacek

On Sept. 11, 2013, 4:24 p.m., Vitezslav Crhonek wrote:

---

This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/851/

---

(Updated Sept. 11, 2013, 4:24 p.m.)

Review request for OpenLMI Developers.

Repository: openlmi-providers

Description

Service: Propagate error messages, check for invalid (NULL) service names

Diffs

src/service-dbus/LMI_ServiceProvider.c e4fa3aaf15c26eaf3fe26f08f5b1c74b412532bc src/service-dbus/util/serviceutil.h d1ed1be194f5b97f953979a97c778731684bb18f src/service-dbus/util/serviceutil.c af1e7fff749b4d7278a3fc92d72d333a193af2d2

Diff: http://reviewboard-openlmi.rhcloud.com/r/851/diff/

Testing

Thanks,

Vitezslav Crhonek

_______________________________________________ openlmi-reviews mailing list openlmi-reviews@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/openlmi-reviews