Review Request 244: openlmi-networking [1/6] Simplify creation of IPAssignmentSettingData
----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/244/ -----------------------------------------------------------
Review request for OpenLMI Developers.
Repository: openlmi-networking
Description -------
Simplify creation of IPAssignmentSettingData
Use one common function to create instances of all following classes: * LMI_IPAssignmentSettingData * LMI_ExtendedStaticIPAssignmentSettingData * LMI_DHCPSettingData
Diffs -----
src/LMI_DHCPSettingDataProvider.c 6c3f2fc56d52395d6babe57ef3c1e350f188a157 src/CMakeLists.txt f0f1ea7f22e85298f69074aa7ce6a9c6c26eb38e src/LMI_ExtendedStaticIPAssignmentSettingDataProvider.c c17b93921cc035352be7e733760d34a03f29a30a src/LMI_IPAssignmentSettingDataProvider.c 96b70f67db210023e939dcfe2a20ba598802bc46 src/ipassignmentsettingdata.h PRE-CREATION src/ipassignmentsettingdata.c PRE-CREATION
Diff: http://reviewboard-openlmi.rhcloud.com/r/244/diff/
Testing -------
Thanks,
Radek Novacek
----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/244/#review274 -----------------------------------------------------------
src/LMI_IPAssignmentSettingDataProvider.c http://reviewboard-openlmi.rhcloud.com/r/244/#comment164
You might save few CPU cycles by using some enum instead of string with class name & strcmp
(remarks the one who writes providers in Python :)
src/ipassignmentsettingdata.c http://reviewboard-openlmi.rhcloud.com/r/244/#comment165
I don't know KonkretCMPI internals, but shouldn't it return 'res' instead?
- Jan Safranek
On April 19, 2013, 2:41 p.m., Radek Novacek wrote:
This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/244/
(Updated April 19, 2013, 2:41 p.m.)
Review request for OpenLMI Developers.
Repository: openlmi-networking
Description
Simplify creation of IPAssignmentSettingData
Use one common function to create instances of all following classes:
- LMI_IPAssignmentSettingData
- LMI_ExtendedStaticIPAssignmentSettingData
- LMI_DHCPSettingData
Diffs
src/LMI_DHCPSettingDataProvider.c 6c3f2fc56d52395d6babe57ef3c1e350f188a157 src/CMakeLists.txt f0f1ea7f22e85298f69074aa7ce6a9c6c26eb38e src/LMI_ExtendedStaticIPAssignmentSettingDataProvider.c c17b93921cc035352be7e733760d34a03f29a30a src/LMI_IPAssignmentSettingDataProvider.c 96b70f67db210023e939dcfe2a20ba598802bc46 src/ipassignmentsettingdata.h PRE-CREATION src/ipassignmentsettingdata.c PRE-CREATION
Diff: http://reviewboard-openlmi.rhcloud.com/r/244/diff/
Testing
Thanks,
Radek Novacek
On April 22, 2013, 3:27 p.m., Jan Safranek wrote:
src/ipassignmentsettingdata.c, line 176 http://reviewboard-openlmi.rhcloud.com/r/244/diff/1/?file=1352#file1352line176
I don't know KonkretCMPI internals, but shouldn't it return 'res' instead?
Thanks for noticing, will fix
- Radek
----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/244/#review274 -----------------------------------------------------------
On April 19, 2013, 2:41 p.m., Radek Novacek wrote:
This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/244/
(Updated April 19, 2013, 2:41 p.m.)
Review request for OpenLMI Developers.
Repository: openlmi-networking
Description
Simplify creation of IPAssignmentSettingData
Use one common function to create instances of all following classes:
- LMI_IPAssignmentSettingData
- LMI_ExtendedStaticIPAssignmentSettingData
- LMI_DHCPSettingData
Diffs
src/LMI_DHCPSettingDataProvider.c 6c3f2fc56d52395d6babe57ef3c1e350f188a157 src/CMakeLists.txt f0f1ea7f22e85298f69074aa7ce6a9c6c26eb38e src/LMI_ExtendedStaticIPAssignmentSettingDataProvider.c c17b93921cc035352be7e733760d34a03f29a30a src/LMI_IPAssignmentSettingDataProvider.c 96b70f67db210023e939dcfe2a20ba598802bc46 src/ipassignmentsettingdata.h PRE-CREATION src/ipassignmentsettingdata.c PRE-CREATION
Diff: http://reviewboard-openlmi.rhcloud.com/r/244/diff/
Testing
Thanks,
Radek Novacek
On April 22, 2013, 3:27 p.m., Jan Safranek wrote:
src/LMI_IPAssignmentSettingDataProvider.c, line 68 http://reviewboard-openlmi.rhcloud.com/r/244/diff/1/?file=1350#file1350line68
You might save few CPU cycles by using some enum instead of string with class name & strcmp (remarks the one who writes providers in Python :)
I'll do it later, thanks for the tip.
- Radek
----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/244/#review274 -----------------------------------------------------------
On April 19, 2013, 2:41 p.m., Radek Novacek wrote:
This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/244/
(Updated April 19, 2013, 2:41 p.m.)
Review request for OpenLMI Developers.
Repository: openlmi-networking
Description
Simplify creation of IPAssignmentSettingData
Use one common function to create instances of all following classes:
- LMI_IPAssignmentSettingData
- LMI_ExtendedStaticIPAssignmentSettingData
- LMI_DHCPSettingData
Diffs
src/LMI_DHCPSettingDataProvider.c 6c3f2fc56d52395d6babe57ef3c1e350f188a157 src/CMakeLists.txt f0f1ea7f22e85298f69074aa7ce6a9c6c26eb38e src/LMI_ExtendedStaticIPAssignmentSettingDataProvider.c c17b93921cc035352be7e733760d34a03f29a30a src/LMI_IPAssignmentSettingDataProvider.c 96b70f67db210023e939dcfe2a20ba598802bc46 src/ipassignmentsettingdata.h PRE-CREATION src/ipassignmentsettingdata.c PRE-CREATION
Diff: http://reviewboard-openlmi.rhcloud.com/r/244/diff/
Testing
Thanks,
Radek Novacek
----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/244/#review275 -----------------------------------------------------------
Ship it!
The patch looks OK otherwise
- Jan Safranek
On April 19, 2013, 2:41 p.m., Radek Novacek wrote:
This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/244/
(Updated April 19, 2013, 2:41 p.m.)
Review request for OpenLMI Developers.
Repository: openlmi-networking
Description
Simplify creation of IPAssignmentSettingData
Use one common function to create instances of all following classes:
- LMI_IPAssignmentSettingData
- LMI_ExtendedStaticIPAssignmentSettingData
- LMI_DHCPSettingData
Diffs
src/LMI_DHCPSettingDataProvider.c 6c3f2fc56d52395d6babe57ef3c1e350f188a157 src/CMakeLists.txt f0f1ea7f22e85298f69074aa7ce6a9c6c26eb38e src/LMI_ExtendedStaticIPAssignmentSettingDataProvider.c c17b93921cc035352be7e733760d34a03f29a30a src/LMI_IPAssignmentSettingDataProvider.c 96b70f67db210023e939dcfe2a20ba598802bc46 src/ipassignmentsettingdata.h PRE-CREATION src/ipassignmentsettingdata.c PRE-CREATION
Diff: http://reviewboard-openlmi.rhcloud.com/r/244/diff/
Testing
Thanks,
Radek Novacek
----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/244/#review276 -----------------------------------------------------------
Ship it!
The patch looks OK otherwise
- Jan Safranek
On April 19, 2013, 2:41 p.m., Radek Novacek wrote:
This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/244/
(Updated April 19, 2013, 2:41 p.m.)
Review request for OpenLMI Developers.
Repository: openlmi-networking
Description
Simplify creation of IPAssignmentSettingData
Use one common function to create instances of all following classes:
- LMI_IPAssignmentSettingData
- LMI_ExtendedStaticIPAssignmentSettingData
- LMI_DHCPSettingData
Diffs
src/LMI_DHCPSettingDataProvider.c 6c3f2fc56d52395d6babe57ef3c1e350f188a157 src/CMakeLists.txt f0f1ea7f22e85298f69074aa7ce6a9c6c26eb38e src/LMI_ExtendedStaticIPAssignmentSettingDataProvider.c c17b93921cc035352be7e733760d34a03f29a30a src/LMI_IPAssignmentSettingDataProvider.c 96b70f67db210023e939dcfe2a20ba598802bc46 src/ipassignmentsettingdata.h PRE-CREATION src/ipassignmentsettingdata.c PRE-CREATION
Diff: http://reviewboard-openlmi.rhcloud.com/r/244/diff/
Testing
Thanks,
Radek Novacek
----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/244/ -----------------------------------------------------------
(Updated April 23, 2013, 8:19 a.m.)
Status ------
This change has been marked as submitted.
Review request for OpenLMI Developers.
Repository: openlmi-networking
Description -------
Simplify creation of IPAssignmentSettingData
Use one common function to create instances of all following classes: * LMI_IPAssignmentSettingData * LMI_ExtendedStaticIPAssignmentSettingData * LMI_DHCPSettingData
Diffs -----
src/LMI_DHCPSettingDataProvider.c 6c3f2fc56d52395d6babe57ef3c1e350f188a157 src/CMakeLists.txt f0f1ea7f22e85298f69074aa7ce6a9c6c26eb38e src/LMI_ExtendedStaticIPAssignmentSettingDataProvider.c c17b93921cc035352be7e733760d34a03f29a30a src/LMI_IPAssignmentSettingDataProvider.c 96b70f67db210023e939dcfe2a20ba598802bc46 src/ipassignmentsettingdata.h PRE-CREATION src/ipassignmentsettingdata.c PRE-CREATION
Diff: http://reviewboard-openlmi.rhcloud.com/r/244/diff/
Testing -------
Thanks,
Radek Novacek
openlmi-devel@lists.stg.fedorahosted.org
-
Stephen Gallagher