Review Request 186: service: added dbus based service provider [1/1] service: added dbus based service provider
----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/186/ -----------------------------------------------------------
Review request for OpenLMI Developers.
Repository: openlmi-providers
Description -------
service: added dbus based service provider
Diffs -----
README 7e17e458ef4699a62ec933a6d4a51f35588f97e1 src/CMakeLists.txt 73189110171562bdcbaf56faff7d2d07b325a076 src/service-dbus/CMakeLists.txt PRE-CREATION src/service-dbus/LMI_ServiceProvider.c PRE-CREATION src/service-dbus/util/serviceutil.h PRE-CREATION src/service-dbus/util/serviceutil.c PRE-CREATION
Diff: http://reviewboard-openlmi.rhcloud.com/r/186/diff/
Testing -------
Thanks,
Vitezslav Crhonek
----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/186/#review218 -----------------------------------------------------------
src/service-dbus/LMI_ServiceProvider.c http://reviewboard-openlmi.rhcloud.com/r/186/#comment122
Looking at Service_Find_All() definition it can return NULL - check it here.
src/service-dbus/LMI_ServiceProvider.c http://reviewboard-openlmi.rhcloud.com/r/186/#comment123
Use LMI_Service_ClassName from LMI_Service.h
src/service-dbus/LMI_ServiceProvider.c http://reviewboard-openlmi.rhcloud.com/r/186/#comment124
Again, use LMI_Service_ClassName
src/service-dbus/util/serviceutil.h http://reviewboard-openlmi.rhcloud.com/r/186/#comment127
Function names does not follow our coding conventions - name of methods / variables use snake_case_with_underscores
src/service-dbus/util/serviceutil.c http://reviewboard-openlmi.rhcloud.com/r/186/#comment125
Missing checks for malloc()s
src/service-dbus/util/serviceutil.c http://reviewboard-openlmi.rhcloud.com/r/186/#comment126
What are these magic numbers? Maybe add a comment.
src/service-dbus/util/serviceutil.c http://reviewboard-openlmi.rhcloud.com/r/186/#comment128
Looks like missing free for those strdup()s.
- Roman Rakus
On April 11, 2013, 3:23 p.m., Vitezslav Crhonek wrote:
This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/186/
(Updated April 11, 2013, 3:23 p.m.)
Review request for OpenLMI Developers.
Repository: openlmi-providers
Description
service: added dbus based service provider
Diffs
README 7e17e458ef4699a62ec933a6d4a51f35588f97e1 src/CMakeLists.txt 73189110171562bdcbaf56faff7d2d07b325a076 src/service-dbus/CMakeLists.txt PRE-CREATION src/service-dbus/LMI_ServiceProvider.c PRE-CREATION src/service-dbus/util/serviceutil.h PRE-CREATION src/service-dbus/util/serviceutil.c PRE-CREATION
Diff: http://reviewboard-openlmi.rhcloud.com/r/186/diff/
Testing
Thanks,
Vitezslav Crhonek
----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/186/#review236 -----------------------------------------------------------
src/service-dbus/util/serviceutil.c http://reviewboard-openlmi.rhcloud.com/r/186/#comment137
why not strdup? It runs strlen internally.
src/service-dbus/util/serviceutil.c http://reviewboard-openlmi.rhcloud.com/r/186/#comment138
please check str(n)dup results for NULL, it's like malloc.
src/service-dbus/util/serviceutil.c http://reviewboard-openlmi.rhcloud.com/r/186/#comment141
This function allocates lot of data (strdup), I haven't found a place where it's released.
src/service-dbus/util/serviceutil.c http://reviewboard-openlmi.rhcloud.com/r/186/#comment140
rename to value_long?
src/service-dbus/util/serviceutil.c http://reviewboard-openlmi.rhcloud.com/r/186/#comment139
check for strdup results
- Jan Safranek
On April 11, 2013, 5:23 p.m., Vitezslav Crhonek wrote:
This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/186/
(Updated April 11, 2013, 5:23 p.m.)
Review request for OpenLMI Developers.
Repository: openlmi-providers
Description
service: added dbus based service provider
Diffs
README 7e17e458ef4699a62ec933a6d4a51f35588f97e1 src/CMakeLists.txt 73189110171562bdcbaf56faff7d2d07b325a076 src/service-dbus/CMakeLists.txt PRE-CREATION src/service-dbus/LMI_ServiceProvider.c PRE-CREATION src/service-dbus/util/serviceutil.h PRE-CREATION src/service-dbus/util/serviceutil.c PRE-CREATION
Diff: http://reviewboard-openlmi.rhcloud.com/r/186/diff/
Testing
Thanks,
Vitezslav Crhonek
On April 17, 2013, 10:15 a.m., Jan Safranek wrote:
src/service-dbus/util/serviceutil.c, lines 105-107 http://reviewboard-openlmi.rhcloud.com/r/186/diff/1/?file=1032#file1032line105
This function allocates lot of data (strdup), I haven't found a place where it's released.
Also the function should free the data on error, e.g. when getting ActiveState property fails, all the strdups before should be freed.
- Jan
----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/186/#review236 -----------------------------------------------------------
On April 11, 2013, 5:23 p.m., Vitezslav Crhonek wrote:
This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/186/
(Updated April 11, 2013, 5:23 p.m.)
Review request for OpenLMI Developers.
Repository: openlmi-providers
Description
service: added dbus based service provider
Diffs
README 7e17e458ef4699a62ec933a6d4a51f35588f97e1 src/CMakeLists.txt 73189110171562bdcbaf56faff7d2d07b325a076 src/service-dbus/CMakeLists.txt PRE-CREATION src/service-dbus/LMI_ServiceProvider.c PRE-CREATION src/service-dbus/util/serviceutil.h PRE-CREATION src/service-dbus/util/serviceutil.c PRE-CREATION
Diff: http://reviewboard-openlmi.rhcloud.com/r/186/diff/
Testing
Thanks,
Vitezslav Crhonek
----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/186/ -----------------------------------------------------------
(Updated April 23, 2013, 2:01 p.m.)
Review request for OpenLMI Developers.
Repository: openlmi-providers
Description -------
service: added dbus based service provider
Diffs (updated) -----
.reviewboardrc PRE-CREATION README 7e17e458ef4699a62ec933a6d4a51f35588f97e1 lmi-review-git.sh PRE-CREATION src/CMakeLists.txt 73189110171562bdcbaf56faff7d2d07b325a076 src/service-dbus/CMakeLists.txt PRE-CREATION src/service-dbus/LMI_ServiceProvider.c PRE-CREATION src/service-dbus/util/serviceutil.h PRE-CREATION src/service-dbus/util/serviceutil.c PRE-CREATION
Diff: http://reviewboard-openlmi.rhcloud.com/r/186/diff/
Testing -------
Thanks,
Vitezslav Crhonek
----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/186/ -----------------------------------------------------------
(Updated April 23, 2013, 2:11 p.m.)
Review request for OpenLMI Developers.
Repository: openlmi-providers
Description -------
service: added dbus based service provider
Diffs (updated) -----
README 7e17e458ef4699a62ec933a6d4a51f35588f97e1 src/CMakeLists.txt 73189110171562bdcbaf56faff7d2d07b325a076 src/service-dbus/CMakeLists.txt PRE-CREATION src/service-dbus/LMI_ServiceProvider.c PRE-CREATION src/service-dbus/util/serviceutil.h PRE-CREATION src/service-dbus/util/serviceutil.c PRE-CREATION
Diff: http://reviewboard-openlmi.rhcloud.com/r/186/diff/
Testing -------
Thanks,
Vitezslav Crhonek
----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/186/#review289 -----------------------------------------------------------
Ship it!
src/service-dbus/util/serviceutil.c http://reviewboard-openlmi.rhcloud.com/r/186/#comment181
It might be good to call error(...) here (and in other error cases), so it will be easier to debug potential issues.
- Radek Novacek
On April 23, 2013, 4:11 p.m., Vitezslav Crhonek wrote:
This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/186/
(Updated April 23, 2013, 4:11 p.m.)
Review request for OpenLMI Developers.
Repository: openlmi-providers
Description
service: added dbus based service provider
Diffs
README 7e17e458ef4699a62ec933a6d4a51f35588f97e1 src/CMakeLists.txt 73189110171562bdcbaf56faff7d2d07b325a076 src/service-dbus/CMakeLists.txt PRE-CREATION src/service-dbus/LMI_ServiceProvider.c PRE-CREATION src/service-dbus/util/serviceutil.h PRE-CREATION src/service-dbus/util/serviceutil.c PRE-CREATION
Diff: http://reviewboard-openlmi.rhcloud.com/r/186/diff/
Testing
Thanks,
Vitezslav Crhonek
----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/186/#review292 -----------------------------------------------------------
src/service-dbus/util/serviceutil.c http://reviewboard-openlmi.rhcloud.com/r/186/#comment186
free(slist) here on error
- Jan Safranek
On April 23, 2013, 4:11 p.m., Vitezslav Crhonek wrote:
This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/186/
(Updated April 23, 2013, 4:11 p.m.)
Review request for OpenLMI Developers.
Repository: openlmi-providers
Description
service: added dbus based service provider
Diffs
README 7e17e458ef4699a62ec933a6d4a51f35588f97e1 src/CMakeLists.txt 73189110171562bdcbaf56faff7d2d07b325a076 src/service-dbus/CMakeLists.txt PRE-CREATION src/service-dbus/LMI_ServiceProvider.c PRE-CREATION src/service-dbus/util/serviceutil.h PRE-CREATION src/service-dbus/util/serviceutil.c PRE-CREATION
Diff: http://reviewboard-openlmi.rhcloud.com/r/186/diff/
Testing
Thanks,
Vitezslav Crhonek
----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/186/ -----------------------------------------------------------
(Updated May 13, 2013, 2:41 p.m.)
Status ------
This change has been marked as submitted.
Review request for OpenLMI Developers.
Repository: openlmi-providers
Description -------
service: added dbus based service provider
Diffs -----
README 7e17e458ef4699a62ec933a6d4a51f35588f97e1 src/CMakeLists.txt 73189110171562bdcbaf56faff7d2d07b325a076 src/service-dbus/CMakeLists.txt PRE-CREATION src/service-dbus/LMI_ServiceProvider.c PRE-CREATION src/service-dbus/util/serviceutil.h PRE-CREATION src/service-dbus/util/serviceutil.c PRE-CREATION
Diff: http://reviewboard-openlmi.rhcloud.com/r/186/diff/
Testing -------
Thanks,
Vitezslav Crhonek
openlmi-devel@lists.stg.fedorahosted.org
-
Stephen Gallagher