packagedb-cli-commits November 2014

packagedb-cli-commits@lists.stg.fedorahosted.org

1 participants
115 discussions

[packagedb-cli/pkgdb_admin: 26/37] If all checks cleared, return a message saying so
by Pierre-YvesChibon 24 Nov '14

24 Nov '14

commit 2bec7324e9348c77ff803576d80b4f88179a3768 Author: Pierre-Yves Chibon <pingou(a)pingoured.fr> Date: Fri Oct 10 11:00:23 2014 +0200 If all checks cleared, return a message saying so pkgdb2client/utils.py | 5 +++++ 1 files changed, 5 insertions(+), 0 deletions(-) --- diff --git a/pkgdb2client/utils.py b/pkgdb2client/utils.py index c77c6b7..e759560 100644 --- a/pkgdb2client/utils.py +++ b/pkgdb2client/utils.py @@ -165,4 +165,9 @@ def check_package_creation(info, bugid): 'User {0} is not a packager but set the fedora-review ' 'flag to `+`'.format(flag['setter'])) + if not messages: + messages.append( + 'All checks cleared for review {0}: {1}'.format( + bugid, info['pkg_name'])) + return messages

1 0

[packagedb-cli/pkgdb_admin: 25/37] Finally figure out a way to retrieve a FAS user by his/her email address
by Pierre-YvesChibon 24 Nov '14

24 Nov '14

commit 3d5694825a2ee9ea49b198a2730f0e2363f6638e Author: Pierre-Yves Chibon <pingou(a)pingoured.fr> Date: Fri Oct 10 10:25:17 2014 +0200 Finally figure out a way to retrieve a FAS user by his/her email address pkgdb2client/utils.py | 11 ++++++++--- 1 files changed, 8 insertions(+), 3 deletions(-) --- diff --git a/pkgdb2client/utils.py b/pkgdb2client/utils.py index e48d3be..c77c6b7 100644 --- a/pkgdb2client/utils.py +++ b/pkgdb2client/utils.py @@ -96,10 +96,15 @@ def __get_fas_user_by_email(email_address): ''' if email_address in FASCLIENT._AccountSystem__alternate_email: - user = FASCLIENT.person_by_id( - FASCLIENT._AccountSystem__alternate_email[email_address]) + userid = FASCLIENT._AccountSystem__alternate_email[email_address] + else: - user = FASCLIENT.people_by_key('email', email_address) + userid = FASCLIENT.people_query( + constraints={'email': email_address}, + columns=['id'] + )[0].id + + user = FASCLIENT.person_by_id(userid) return user

1 0

[packagedb-cli/pkgdb_admin: 24/37] Be consistent on how we build our strings, use .format() everywhere
by Pierre-YvesChibon 24 Nov '14

24 Nov '14

commit 7a1460cd04aaa1ad5c952980bf997661ec875421 Author: Pierre-Yves Chibon <pingou(a)pingoured.fr> Date: Thu Oct 9 17:36:00 2014 +0200 Be consistent on how we build our strings, use .format() everywhere pkgdb2client/utils.py | 6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) --- diff --git a/pkgdb2client/utils.py b/pkgdb2client/utils.py index b9a14c6..e48d3be 100644 --- a/pkgdb2client/utils.py +++ b/pkgdb2client/utils.py @@ -150,14 +150,14 @@ def check_package_creation(info, bugid): # Check if the participants are packagers for user in get_users_in_bug(bugid): if not is_packager(user): - messages.append('User %s is not a packager' % user) + messages.append('User {0} is not a packager'.format(user)) # Check who updated the fedora-review flag to + for flag in bug.flags: if flag['name'] == 'fedora-review' and flag['status'] == '+': if not is_packager(flag['setter']): messages.append( - 'User %s is not a packager but set the fedora-review ' - 'flag to `+`' % flag['setter']) + 'User {0} is not a packager but set the fedora-review ' + 'flag to `+`'.format(flag['setter'])) return messages

1 0

[packagedb-cli/pkgdb_admin: 23/37] Check if the summary of the bug fits the expectation for package reviews
by Pierre-YvesChibon 24 Nov '14

24 Nov '14

commit ba7a0e837270c173bc10649c3b7b904b7a2d544d Author: Pierre-Yves Chibon <pingou(a)pingoured.fr> Date: Thu Oct 9 17:35:00 2014 +0200 Check if the summary of the bug fits the expectation for package reviews pkgdb2client/utils.py | 13 +++++++++++-- 1 files changed, 11 insertions(+), 2 deletions(-) --- diff --git a/pkgdb2client/utils.py b/pkgdb2client/utils.py index 81eaa17..b9a14c6 100644 --- a/pkgdb2client/utils.py +++ b/pkgdb2client/utils.py @@ -120,7 +120,7 @@ def is_packager(email_address): and user['group_roles']['packager']['role_status'] == 'approved' -def check_package_creation(bugid): +def check_package_creation(info, bugid): ''' Performs a number of checks to see if a package review satisfies the criterias to create the package on pkgdb. @@ -137,8 +137,17 @@ def check_package_creation(bugid): FASCLIENT.username = username FASCLIENT.password = password - # Check if the participants are packagers bug = get_bug(bugid, login=True) + + # Check if the title of the bug fits the expectations + expected = 'Review Request: {0} - {1}'.format( + info['pkg_name'], info['pkg_summary']) + if bug.summary != expected: + messages.append( + 'The bug title does not fit the expected one\n' + ' exp: "{0}" vs obs: "{1}"'.format(expected, bug.summary)) + + # Check if the participants are packagers for user in get_users_in_bug(bugid): if not is_packager(user): messages.append('User %s is not a packager' % user)

1 0

[packagedb-cli/pkgdb_admin: 22/37] Start working on the check pre-package creation
by Pierre-YvesChibon 24 Nov '14

24 Nov '14

commit c6fa2b8e5af1b55ae270d567c6c4d06d86186e63 Author: Pierre-Yves Chibon <pingou(a)pingoured.fr> Date: Thu Oct 9 17:24:50 2014 +0200 Start working on the check pre-package creation pkgdb2client/utils.py | 34 ++++++++++++++++++++++++++++++++++ 1 files changed, 34 insertions(+), 0 deletions(-) --- diff --git a/pkgdb2client/utils.py b/pkgdb2client/utils.py index 1e4d5ec..81eaa17 100644 --- a/pkgdb2client/utils.py +++ b/pkgdb2client/utils.py @@ -118,3 +118,37 @@ def is_packager(email_address): return user \ and 'packager' in user['group_roles'] \ and user['group_roles']['packager']['role_status'] == 'approved' + + +def check_package_creation(bugid): + ''' Performs a number of checks to see if a package review satisfies the + criterias to create the package on pkgdb. + + Checks: + - If the users on the review are packagers + - If the person that approved the review (set fedora-review to +) is + a packager + - ... + ''' + messages = [] + + if not FASCLIENT.username: + username, password = pkgdb2client.ask_password() + FASCLIENT.username = username + FASCLIENT.password = password + + # Check if the participants are packagers + bug = get_bug(bugid, login=True) + for user in get_users_in_bug(bugid): + if not is_packager(user): + messages.append('User %s is not a packager' % user) + + # Check who updated the fedora-review flag to + + for flag in bug.flags: + if flag['name'] == 'fedora-review' and flag['status'] == '+': + if not is_packager(flag['setter']): + messages.append( + 'User %s is not a packager but set the fedora-review ' + 'flag to `+`' % flag['setter']) + + return messages

1 0

[packagedb-cli/pkgdb_admin: 21/37] Add a utility method to check if a specified email belongs to a packager
by Pierre-YvesChibon 24 Nov '14

24 Nov '14

commit 068e5326f61f6de17fc2fe58423690eae10850be Author: Pierre-Yves Chibon <pingou(a)pingoured.fr> Date: Thu Oct 9 17:24:21 2014 +0200 Add a utility method to check if a specified email belongs to a packager pkgdb2client/utils.py | 33 +++++++++++++++++++++++++++++++++ 1 files changed, 33 insertions(+), 0 deletions(-) --- diff --git a/pkgdb2client/utils.py b/pkgdb2client/utils.py index cd82ae0..1e4d5ec 100644 --- a/pkgdb2client/utils.py +++ b/pkgdb2client/utils.py @@ -85,3 +85,36 @@ def get_users_in_bug(bugid): users.add(bugbz.creator) return users + + +def __get_fas_user_by_email(email_address): + ''' For a provided email_address returned the associated FAS user. + The email_address can be either the FAS email address or the one used + in bugzilla. + + :arg email_address: the email address of the user to retrieve in FAS. + + ''' + if email_address in FASCLIENT._AccountSystem__alternate_email: + user = FASCLIENT.person_by_id( + FASCLIENT._AccountSystem__alternate_email[email_address]) + else: + user = FASCLIENT.people_by_key('email', email_address) + + return user + + +def is_packager(email_address): + ''' For a provided email_address returned whether associated FAS user + is a packager or not. + The email_address can be either the FAS email address or the one used + in bugzilla. + + :arg email_address: the email address of the user to retrieve in FAS. + + ''' + user = __get_fas_user_by_email(email_address.strip()) + + return user \ + and 'packager' in user['group_roles'] \ + and user['group_roles']['packager']['role_status'] == 'approved'

1 0

[packagedb-cli/pkgdb_admin: 20/37] Add utility method to find out all the users that commented on a given bug
by Pierre-YvesChibon 24 Nov '14

24 Nov '14

commit 1ed9a888af4a39c2c91515f96f235cc5773b69f9 Author: Pierre-Yves Chibon <pingou(a)pingoured.fr> Date: Thu Oct 9 17:23:55 2014 +0200 Add utility method to find out all the users that commented on a given bug pkgdb2client/utils.py | 20 ++++++++++++++++++++ 1 files changed, 20 insertions(+), 0 deletions(-) --- diff --git a/pkgdb2client/utils.py b/pkgdb2client/utils.py index 35b7934..cd82ae0 100644 --- a/pkgdb2client/utils.py +++ b/pkgdb2client/utils.py @@ -65,3 +65,23 @@ def get_bug(bugid, login=False): bz_login() return BZCLIENT.getbug(bugid) + + +def get_users_in_bug(bugid): + ''' Return the list of open bugs reported against a package. + + :arg bugid: either the identifier of the bug to retrieve or directly + the bug object + :returns: the list of the people (their email address) that commented + on the specified ticket + + ''' + + if isinstance(bugid, (int, basestring)): + bugbz = get_bug(bugid, login=True) + else: + bugbz = bugid + users = set([com['author'] for com in bugbz.comments]) + users.add(bugbz.creator) + + return users

1 0

[packagedb-cli/pkgdb_admin: 19/37] Add utility method to retrieve a specified bug off bugzilla
by Pierre-YvesChibon 24 Nov '14

24 Nov '14

commit 02a4b3291232dbf82408243e1a7548fcdcd783c6 Author: Pierre-Yves Chibon <pingou(a)pingoured.fr> Date: Thu Oct 9 17:23:18 2014 +0200 Add utility method to retrieve a specified bug off bugzilla pkgdb2client/utils.py | 17 +++++++++++++++++ 1 files changed, 17 insertions(+), 0 deletions(-) --- diff --git a/pkgdb2client/utils.py b/pkgdb2client/utils.py index 39f99b7..35b7934 100644 --- a/pkgdb2client/utils.py +++ b/pkgdb2client/utils.py @@ -48,3 +48,20 @@ def get_bugz(pkg_name): 'component': pkg_name}) return bugbz + + +def get_bug(bugid, login=False): + ''' Return the bug with the specified identifier. + + :arg bugid: the identifier of the bug to retrieve + :kwarg login: a boolean specifying whether to retrieve the information + about this bug with a user logged in or not. + :returns: the list of the people (their email address) that commented + on the specified ticket + + ''' + + if login and not BZCLIENT.logged_in: + bz_login() + + return BZCLIENT.getbug(bugid)

1 0

[packagedb-cli/pkgdb_admin: 18/37] Add method to login against bugzilla
by Pierre-YvesChibon 24 Nov '14

24 Nov '14

commit edcfbc92c5ae7190462d43733cd9cc4df8ca7de5 Author: Pierre-Yves Chibon <pingou(a)pingoured.fr> Date: Thu Oct 9 17:22:53 2014 +0200 Add method to login against bugzilla pkgdb2client/utils.py | 18 ++++++++++++++++-- 1 files changed, 16 insertions(+), 2 deletions(-) --- diff --git a/pkgdb2client/utils.py b/pkgdb2client/utils.py index ab29c35..39f99b7 100644 --- a/pkgdb2client/utils.py +++ b/pkgdb2client/utils.py @@ -15,11 +15,25 @@ # license. """ -from bugzilla.rhbugzilla import RHBugzilla +import getpass +from bugzilla import Bugzilla +from fedora.client import AccountSystem, AuthError + +import pkgdb2client RH_BZ_API = 'https://bugzilla.redhat.com/xmlrpc.cgi' -BZCLIENT = RHBugzilla(url=RH_BZ_API) +BZCLIENT = Bugzilla(url=RH_BZ_API) +FASCLIENT = AccountSystem('https://admin.fedoraproject.org/accounts') + + +def bz_login(): + ''' Login on bugzilla. ''' + print 'To keep going, we need to authenticate against bugzilla' \ + ' at {0}'.format(RH_BZ_API) + username = raw_input("Bugzilla user: ") + password = getpass.getpass("Bugzilla password: ") + BZCLIENT.login(username, password) def get_bugz(pkg_name):

1 0

[packagedb-cli/pkgdb_admin: 17/37] Drop the call for FAS since we do not use it anywhere
by Pierre-YvesChibon 24 Nov '14

24 Nov '14

commit 72b6b67206c07f3f232e5b72f022da02eb6cbb6d Author: Pierre-Yves Chibon <pingou(a)pingoured.fr> Date: Thu Oct 9 15:03:06 2014 +0200 Drop the call for FAS since we do not use it anywhere pkgdb2client/admin.py | 8 ++------ pkgdb2client/cli.py | 8 ++------ 2 files changed, 4 insertions(+), 12 deletions(-) --- diff --git a/pkgdb2client/admin.py b/pkgdb2client/admin.py index 5ff4f34..2e0465e 100644 --- a/pkgdb2client/admin.py +++ b/pkgdb2client/admin.py @@ -15,7 +15,7 @@ # license. """ -from fedora.client import (AccountSystem, AppError, ServerError) +from fedora.client import (AppError, ServerError) import argparse import requests @@ -29,7 +29,6 @@ import pkgdb2client pkgdbclient = PkgDB('https://admin.fedoraproject.org/pkgdb', login_callback=pkgdb2client.ask_password) -fasclient = AccountSystem('https://admin.fedoraproject.org/accounts') BOLD = "\033[1m" RED = "\033[0;31m" RESET = "\033[0;0m" @@ -260,11 +259,8 @@ def main(): LOG.setLevel(logging.INFO) if arg.test: - global fasclient, pkgdbclient + global pkgdbclient print "Testing environment" - fasclient = AccountSystem( - 'https://admin.stg.fedoraproject.org/accounts', - insecure=True) pkgdbclient = PkgDB( #'https://admin.stg.fedoraproject.org/pkgdb', 'http://209.132.184.188/', diff --git a/pkgdb2client/cli.py b/pkgdb2client/cli.py index d771b5b..de03bc6 100644 --- a/pkgdb2client/cli.py +++ b/pkgdb2client/cli.py @@ -15,7 +15,7 @@ # license. """ -from fedora.client import (AccountSystem, AppError, ServerError) +from fedora.client import (AppError, ServerError) import argparse import requests @@ -31,7 +31,6 @@ KOJI_HUB = 'http://koji.fedoraproject.org/kojihub' pkgdbclient = PkgDB('https://admin.fedoraproject.org/pkgdb', login_callback=pkgdb2client.ask_password) -fasclient = AccountSystem('https://admin.fedoraproject.org/accounts') BOLD = "\033[1m" RED = "\033[0;31m" RESET = "\033[0;0m" @@ -756,11 +755,8 @@ def main(): LOG.setLevel(logging.INFO) if arg.test: - global fasclient, pkgdbclient + global pkgdbclient print "Testing environment" - fasclient = AccountSystem( - 'https://admin.stg.fedoraproject.org/accounts', - insecure=True) pkgdbclient = PkgDB( 'https://admin.stg.fedoraproject.org/pkgdb', login_callback=pkgdb2client.ask_password,

1 0

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

packagedb-cli-commits November 2014