packagedb-cli-commits March 2014

packagedb-cli-commits@lists.stg.fedorahosted.org

1 participants
188 discussions

[packagedb-cli/pkgdb2] Remove the username argument from the constructor as we do not use it anywhere
by Pierre-YvesChibon 24 Mar '14

24 Mar '14

commit ab8bea1a39ddecd289dfd78f610464923151386b Author: Pierre-Yves Chibon <pingou(a)pingoured.fr> Date: Mon Mar 24 21:19:58 2014 +0100 Remove the username argument from the constructor as we do not use it anywhere pkgdb2.py | 6 +----- 1 files changed, 1 insertions(+), 5 deletions(-) --- diff --git a/pkgdb2.py b/pkgdb2.py index 467c920..1a2e68e 100644 --- a/pkgdb2.py +++ b/pkgdb2.py @@ -66,15 +66,12 @@ class PkgDB(object): ''' - def __init__(self, url=PKGDB_URL, username=None, insecure=False): + def __init__(self, url=PKGDB_URL, insecure=False): ''' Constructor for the PkgDB object used to query the package database. :kwarg url: the basic url to the package DB instance to query :type url: str - :kwarg username: the FAS username of the user performing the - actions - :type username: str or None :kwarg insecure: If :data:`True` then the connection to the server is not checked to be sure that any SSL certificate information is valid. That means that a remote host can lie about who it @@ -85,7 +82,6 @@ class PkgDB(object): ''' self.url = url self.session = requests.session() - self.username = username self.insecure = insecure self.__logged_in = False

1 0

[packagedb-cli/pkgdb2] Change pkgdb-cli branch to pkgdb-cli branches to be consistent with pkgdb-cli v1
by Pierre-YvesChibon 24 Mar '14

24 Mar '14

commit d73e68d9ee42540b452c1443dcd5de37004a74e2 Author: Pierre-Yves Chibon <pingou(a)pingoured.fr> Date: Thu Mar 20 13:28:35 2014 +0100 Change pkgdb-cli branch to pkgdb-cli branches to be consistent with pkgdb-cli v1 pkgdb2_cli.py | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) --- diff --git a/pkgdb2_cli.py b/pkgdb2_cli.py index acec9f9..baab7fb 100644 --- a/pkgdb2_cli.py +++ b/pkgdb2_cli.py @@ -353,7 +353,7 @@ def setup_parser(): ## Collections parser_branch = subparsers.add_parser( - 'branch', + 'branches', help='List the active branches') parser_branch.add_argument( '--all', action="store_true", default=False,

1 0

[packagedb-cli/pkgdb2] Fix the get_collections call for pkgdb-cli branch
by Pierre-YvesChibon 20 Mar '14

20 Mar '14

commit 0fb13b2af9d0e6316fc2fc015f1338c4edd20a10 Author: Pierre-Yves Chibon <pingou(a)pingoured.fr> Date: Thu Mar 20 13:26:00 2014 +0100 Fix the get_collections call for pkgdb-cli branch pkgdb2_cli.py | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) --- diff --git a/pkgdb2_cli.py b/pkgdb2_cli.py index 0832540..acec9f9 100644 --- a/pkgdb2_cli.py +++ b/pkgdb2_cli.py @@ -619,7 +619,7 @@ def do_branch(args): branches = pkgdbclient.get_collections() else: branches = pkgdbclient.get_collections( - status='Active,Under Development') + clt_status=['Active', 'Under Development']) cnt = 0 for pkg in branches['collections']: name = '{0} {1}'.format(pkg['name'], pkg['version'])

1 0

[packagedb-cli/pkgdb2] Add tests for the poc and count argument of get_packager_acls
by Pierre-YvesChibon 17 Mar '14

17 Mar '14

commit f0627cb8528c7706e44e8af4cbfc3f424a5989ac Author: Pierre-Yves Chibon <pingou(a)pingoured.fr> Date: Mon Mar 17 12:24:07 2014 +0100 Add tests for the poc and count argument of get_packager_acls Adjust the other tests as well. test.py | 31 ++++++++++++++++++++++++++----- 1 files changed, 26 insertions(+), 5 deletions(-) --- diff --git a/test.py b/test.py index af55e8a..a47a40f 100644 --- a/test.py +++ b/test.py @@ -63,7 +63,7 @@ class TestPkgdDB(unittest.TestCase): sorted(out.keys()), ['output', 'packages']) self.assertEqual(out['output'], 'ok') - self.assertEqual(len(out['packages']), 15) + self.assertEqual(len(out['packages']), 4) self.assertEqual( out['packages'][0]['collection']['branchname'], 'devel') self.assertEqual( @@ -105,21 +105,42 @@ class TestPkgdDB(unittest.TestCase): sorted(out.keys()), ['acls', 'output', 'page', 'page_total']) self.assertEqual(len(out['acls']), 250) - self.assertEqual(out['page_total'], 12) + self.assertEqual(out['page_total'], 5) out = self.pkgdb.get_packager_acls('pingou', acls=['approveacls']) self.assertEqual( sorted(out.keys()), ['acls', 'output', 'page', 'page_total']) - self.assertEqual(len(out['acls']), 250) - self.assertEqual(out['page_total'], 2) + self.assertEqual(len(out['acls']), 237) + self.assertEqual(out['page_total'], 1) out = self.pkgdb.get_packager_acls('pingou', page=3) self.assertEqual( sorted(out.keys()), ['acls', 'output', 'page', 'page_total']) self.assertEqual(len(out['acls']), 250) - self.assertEqual(out['page_total'], 12) + self.assertEqual(out['page_total'], 5) + + out = self.pkgdb.get_packager_acls('pingou', count=True) + self.assertEqual( + sorted(out.keys()), + ['acls_count', 'output', 'page', 'page_total']) + self.assertEqual(out['acls_count'], 1035) + self.assertEqual(out['page_total'], 1) + + out = self.pkgdb.get_packager_acls('pingou', poc=True, count=True) + self.assertEqual( + sorted(out.keys()), + ['acls_count', 'output', 'page', 'page_total']) + self.assertEqual(out['acls_count'], 800) + self.assertEqual(out['page_total'], 1) + + out = self.pkgdb.get_packager_acls('pingou', poc=False, count=True) + self.assertEqual( + sorted(out.keys()), + ['acls_count', 'output', 'page', 'page_total']) + self.assertEqual(out['acls_count'], 235) + self.assertEqual(out['page_total'], 1) def test_get_packager_stats(self): ''' Test the get_packager_stats function. '''

1 0

[packagedb-cli/pkgdb2] Add the poc argument to the get_packager_acls method in the pkgdb2 module
by Pierre-YvesChibon 17 Mar '14

17 Mar '14

commit d5ade1910930277893fe8836d5bd7fadc2b18c01 Author: Pierre-Yves Chibon <pingou(a)pingoured.fr> Date: Mon Mar 17 12:23:41 2014 +0100 Add the poc argument to the get_packager_acls method in the pkgdb2 module The poc arguments allows to filter the ACLs retrieved based on the point of contact of the packages. If poc is None (default), then all ACLs of the packager are retrieved. If poc is True, then only the ACLs of the packager for the packages on which he/she is point of contact are retrieved. If poc is False, then only the ACLs of the packager for the packages on which he/she is not point of contact are retrieved. pkgdb2.py | 15 ++++++++++++++- 1 files changed, 14 insertions(+), 1 deletions(-) --- diff --git a/pkgdb2.py b/pkgdb2.py index 35fb56f..467c920 100644 --- a/pkgdb2.py +++ b/pkgdb2.py @@ -383,7 +383,8 @@ class PkgDB(object): return output def get_packager_acls( - self, packagername, acls=None, eol=False, page=1, count=False): + self, packagername, acls=None, eol=False, poc=None, + page=1, count=False): ''' Return the list of ACL for the packager matching the provided criterias. @@ -403,6 +404,16 @@ class PkgDB(object): EOL). If False, it will return results only for non-EOL collections. :type page: boolean + :kwarg poc: a boolean specifying whether the results should be + restricted to ACL for which the provided packager is the point + of contact or not. Defaults to None. + If ``None`` it will not filter the ACLs returned based on the + point of contact of the package (thus every packages is returned). + If ``True`` it will only return ACLs for packages on which the + provided packager is point of contact. + If ``False`` it will only return ACLs for packages on which the + provided packager is not the point of contact. + :type poc: boolean or None :kwarg page: The page number to retrieve. If page is 0 or lower or equal to ``all`` then all pages are returned. Defaults to 0. :type page: int or ``all`` @@ -431,6 +442,8 @@ class PkgDB(object): args['count'] = count if eol is True: args['eol'] = eol + if poc is not None: + args['poc'] = poc req = self.__send_request( url='{0}/api/packager/acl/'.format(self.url),

1 0

[packagedb-cli/pkgdb2] pep8 fixes
by Pierre-YvesChibon 17 Mar '14

17 Mar '14

commit 322dc1fd5ab608d61e7e0605ea105530cdb1e0c9 Author: Pierre-Yves Chibon <pingou(a)pingoured.fr> Date: Mon Mar 17 12:03:19 2014 +0100 pep8 fixes test.py | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) --- diff --git a/test.py b/test.py index d9a621a..af55e8a 100644 --- a/test.py +++ b/test.py @@ -49,7 +49,8 @@ class TestPkgdDB(unittest.TestCase): sorted(out.keys()), ['collections', 'output']) - out = self.pkgdb.get_collections(clt_status=['EOL', 'Under Development']) + out = self.pkgdb.get_collections( + clt_status=['EOL', 'Under Development']) self.assertEqual( sorted(out.keys()), ['collections', 'output']) @@ -386,7 +387,6 @@ class TestPkgdDBAuth(unittest.TestCase): def test_7_update_acl(self): ''' Test the update_acl function. ''' - out = self.pkgdb.update_acl( 'guake', ['devel', 'EL-6'], 'commit', 'Awaiting Review', 'Ralph')

1 0

[packagedb-cli/pkgdb2: 94/94] Specify that the update_acl method can be used to request or set ACLs as well
by Pierre-YvesChibon 14 Mar '14

14 Mar '14

commit ed34436757b545f8baa6b3e8105f0e79c2dbbdee Author: Pierre-Yves Chibon <pingou(a)pingoured.fr> Date: Fri Mar 14 18:54:28 2014 +0100 Specify that the update_acl method can be used to request or set ACLs as well pkgdb2.py | 6 +++++- 1 files changed, 5 insertions(+), 1 deletions(-) --- diff --git a/pkgdb2.py b/pkgdb2.py index 7dede3d..35fb56f 100644 --- a/pkgdb2.py +++ b/pkgdb2.py @@ -780,7 +780,11 @@ class PkgDB(object): def update_acl(self, pkgname, branches, acls, status, user): ''' Update the specified ACLs, on the specified Branches of the - specified package + specified package. + + This method can also be used to request or set new ACLs on a + package. For example if you want to requrest ACLs on a package or + if you want to grant ACLs to someone. :arg pkgname: The package name of the package whom ACLs to update :type pkgname: str

1 0

[packagedb-cli/pkgdb2: 93/94] Add support for the eol argument for the API endpoints that have it
by Pierre-YvesChibon 14 Mar '14

14 Mar '14

commit 913ced95229799ca03474f82babd2fdd0ff691e4 Author: Pierre-Yves Chibon <pingou(a)pingoured.fr> Date: Thu Mar 13 17:59:15 2014 +0100 Add support for the eol argument for the API endpoints that have it pkgdb2.py | 36 +++++++++++++++++++++++++++++++++--- 1 files changed, 33 insertions(+), 3 deletions(-) --- diff --git a/pkgdb2.py b/pkgdb2.py index c8214f9..7dede3d 100644 --- a/pkgdb2.py +++ b/pkgdb2.py @@ -342,7 +342,7 @@ class PkgDB(object): return output - def get_package(self, pkgname, branches=None): + def get_package(self, pkgname, branches=None, eol=False): ''' Return the information of a package matching the provided criterias. @@ -350,6 +350,12 @@ class PkgDB(object): :type pkgname: str :kwarg branches: The branches to retrieve information for :type branch: str or list + :kwarg eol: a boolean to specify whether to include results for + EOL collections or not. Defaults to ``False``. + If True, it will return results for all collections (including + EOL). + If False, it will return results only for non-EOL collections. + :type page: boolean :return: the json object returned by the API :rtype: dict :raise PkgDBException: if the API call does not return a http code @@ -360,6 +366,8 @@ class PkgDB(object): 'pkgname': pkgname, 'branches': branches, } + if eol is True: + args['eol'] = eol req = self.__send_request( url='{0}/api/package/'.format(self.url), @@ -375,10 +383,13 @@ class PkgDB(object): return output def get_packager_acls( - self, packagername, acls=None, page=1, count=False): + self, packagername, acls=None, eol=False, page=1, count=False): ''' Return the list of ACL for the packager matching the provided criterias. + To get information about what packages a user is poc on, you also + want to call ``get_packages``. + :arg packagername: The FAS username of the packager to retrieve the ACLs for :type packagername: str @@ -386,6 +397,12 @@ class PkgDB(object): Options are: ``approveacls``, ``commit``, ``watchbugzilla``, ``watchcommits``. :type acls: str or list or None + :kwarg eol: a boolean to specify whether to include results for + EOL collections or not. Defaults to ``False``. + If True, it will return results for all collections (including + EOL). + If False, it will return results only for non-EOL collections. + :type page: boolean :kwarg page: The page number to retrieve. If page is 0 or lower or equal to ``all`` then all pages are returned. Defaults to 0. :type page: int or ``all`` @@ -412,6 +429,8 @@ class PkgDB(object): } if count is True: args['count'] = count + if eol is True: + args['eol'] = eol req = self.__send_request( url='{0}/api/packager/acl/'.format(self.url), @@ -508,9 +527,12 @@ class PkgDB(object): def get_packages( self, pattern='*', branches=None, poc=None, status=None, - orphaned=False, acls=False, page=1, count=False): + orphaned=False, acls=False, eol=False, page=1, count=False): ''' Return the list of packages matching the provided criterias. + To get information about what packages a person has acls on, you + also need to call ``get_packager_acls``. + :kwarg pattern: The pattern to match against the name of the packages :type pattern: str @@ -530,6 +552,12 @@ class PkgDB(object): Beware, this may slow down you call considerably, maybe even leading to a timeout :type acls: bool + :kwarg eol: a boolean to specify whether to include results for + EOL collections or not. Defaults to ``False``. + If True, it will return results for all collections (including + EOL). + If False, it will return results only for non-EOL collections. + :type page: boolean :kwarg page: The page number to retrieve. If page is 0 or lower or equal to ``all`` then all pages are returned. Defaults to 0. :type page: int or ``all`` @@ -562,6 +590,8 @@ class PkgDB(object): args['acls'] = acls if orphaned is True: args['orphaned'] = orphaned + if eol is True: + args['eol'] = eol req = self.__send_request( url='{0}/api/packages/'.format(self.url),

1 0

[packagedb-cli/pkgdb2: 92/94] Specify in get_packagers which packagers are returned (vs what FAS provides)
by Pierre-YvesChibon 14 Mar '14

14 Mar '14

commit 06d32b0e2f76b51a703c5f80000995db7a6339a7 Author: Pierre-Yves Chibon <pingou(a)pingoured.fr> Date: Thu Mar 13 16:26:30 2014 +0100 Specify in get_packagers which packagers are returned (vs what FAS provides) pkgdb2.py | 5 +++++ 1 files changed, 5 insertions(+), 0 deletions(-) --- diff --git a/pkgdb2.py b/pkgdb2.py index e0ab401..c8214f9 100644 --- a/pkgdb2.py +++ b/pkgdb2.py @@ -476,6 +476,11 @@ class PkgDB(object): def get_packagers(self, pattern='*'): ''' Return the list of packagers matching the provided criterias. + Only packagers having at least commit right on one package are + returned (on the contrary to querying + `FAS <https://admin.fedorapoject.org/accounts>`_ for the members of + the packager group). + :kwarg pattern: The pattern to query the usernames of the packager :type pattern: str :return: the json object returned by the API

1 0

[packagedb-cli/pkgdb2: 91/94] Fix typo in the doc, thanks @abadger
by Pierre-YvesChibon 14 Mar '14

14 Mar '14

commit d06c0d928e11b1e5894ec59d130f788a67514d80 Author: Pierre-Yves Chibon <pingou(a)pingoured.fr> Date: Thu Mar 13 16:18:07 2014 +0100 Fix typo in the doc, thanks @abadger pkgdb2.py | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) --- diff --git a/pkgdb2.py b/pkgdb2.py index d826738..e0ab401 100644 --- a/pkgdb2.py +++ b/pkgdb2.py @@ -449,7 +449,7 @@ class PkgDB(object): :arg packagername: The FAS username of the user for which to retrieve the statistics - :type username: str + :type packagername: str :return: the json object returned by the API :rtype: dict :raise PkgDBException: if the API call does not return a http code

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

packagedb-cli-commits March 2014