packagedb-cli-commits August 2014

packagedb-cli-commits@lists.stg.fedorahosted.org

1 participants
7 discussions

[packagedb-cli: 4/4] Merge pull request #17 from fedora-infra/dead_package
by Pierre-YvesChibon 07 Aug '14

07 Aug '14

commit f1a0b5c314ed297c88a5bab32eeb9c2b6795b4bd Merge: 468f48d 4ab982b Author: Pierre-Yves Chibon <pingou(a)pingoured.fr> Date: Thu Aug 7 14:35:10 2014 +0200 Merge pull request #17 from fedora-infra/dead_package Dead package pkgdb2client/cli.py | 11 +++++++++++ 1 files changed, 11 insertions(+), 0 deletions(-) ---

1 0

[packagedb-cli] (4 commits) ...Merge pull request #17 from fedora-infra/dead_package
by Pierre-YvesChibon 07 Aug '14

07 Aug '14

Summary of changes: 455473a... Prevent user from retiring packages that have no dead.packa (*) f912ee5... Use http status code rather than the content of the dead.pa (*) 4ab982b... Let's fail the retire if the dead.package file is empty (*) f1a0b5c... Merge pull request #17 from fedora-infra/dead_package (*) This commit already existed in another branch; no separate mail sent

1 0

[packagedb-cli/dead_package] Let's fail the retire if the dead.package file is empty
by Pierre-YvesChibon 07 Aug '14

07 Aug '14

commit 4ab982b00a3b449d7ac6b65e9a10f76076112a3e Author: Pierre-Yves Chibon <pingou(a)pingoured.fr> Date: Thu Aug 7 14:17:22 2014 +0200 Let's fail the retire if the dead.package file is empty pkgdb2client/cli.py | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) --- diff --git a/pkgdb2client/cli.py b/pkgdb2client/cli.py index ce73f9c..d90a40e 100644 --- a/pkgdb2client/cli.py +++ b/pkgdb2client/cli.py @@ -562,7 +562,7 @@ def do_orphan(args): 'http://pkgs.fedoraproject.org/cgit/{0}.git/plain/'\ 'dead.package?h={1}'.format(pkg_name, pkg_branch) req = requests.get(dead_url) - if req.status_code != 200: + if req.status_code != 200 or not req.text.strip(): print 'No `dead.package` for %s on %s, please use '\ '`fedpkg retire`' % (pkg_name, pkg_branch) return

1 0

[packagedb-cli/dead_package: 2/2] Use http status code rather than the content of the dead.package file/output
by Pierre-YvesChibon 07 Aug '14

07 Aug '14

commit f912ee529cfd66944b29c496a339cbf5fa70d57b Author: Pierre-Yves Chibon <pingou(a)pingoured.fr> Date: Thu Aug 7 11:52:05 2014 +0200 Use http status code rather than the content of the dead.package file/output pkgdb2client/cli.py | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) --- diff --git a/pkgdb2client/cli.py b/pkgdb2client/cli.py index 236ef43..ce73f9c 100644 --- a/pkgdb2client/cli.py +++ b/pkgdb2client/cli.py @@ -561,8 +561,8 @@ def do_orphan(args): dead_url = \ 'http://pkgs.fedoraproject.org/cgit/{0}.git/plain/'\ 'dead.package?h={1}'.format(pkg_name, pkg_branch) - dead = requests.get(dead_url).text.strip() - if not dead: + req = requests.get(dead_url) + if req.status_code != 200: print 'No `dead.package` for %s on %s, please use '\ '`fedpkg retire`' % (pkg_name, pkg_branch) return

1 0

[packagedb-cli/dead_package: 1/2] Prevent user from retiring packages that have no dead.package file
by Pierre-YvesChibon 07 Aug '14

07 Aug '14

commit 455473a89512d707cb901808b48c03779097dddc Author: Pierre-Yves Chibon <pingou(a)pingoured.fr> Date: Thu Aug 7 11:49:41 2014 +0200 Prevent user from retiring packages that have no dead.package file pkgdb2client/cli.py | 11 +++++++++++ 1 files changed, 11 insertions(+), 0 deletions(-) --- diff --git a/pkgdb2client/cli.py b/pkgdb2client/cli.py index ba605cf..236ef43 100644 --- a/pkgdb2client/cli.py +++ b/pkgdb2client/cli.py @@ -20,6 +20,7 @@ from bugzilla.rhbugzilla import RHBugzilla from pkgdb2client import PkgDB, PkgDBException, __version__ import pkgdb2client import argparse +import requests import logging import koji @@ -555,6 +556,16 @@ def do_orphan(args): pkgdbclient.username = args.username if args.retire is True: + for pkg_name, pkg_branch in itertools.product( + pkgnames, branches): + dead_url = \ + 'http://pkgs.fedoraproject.org/cgit/{0}.git/plain/'\ + 'dead.package?h={1}'.format(pkg_name, pkg_branch) + dead = requests.get(dead_url).text.strip() + if not dead: + print 'No `dead.package` for %s on %s, please use '\ + '`fedpkg retire`' % (pkg_name, pkg_branch) + return output = pkgdbclient.retire_packages(pkgs, branches) else: output = pkgdbclient.orphan_packages(pkgs, branches)

1 0

[packagedb-cli] (2 commits) Created branch dead_package
by Pierre-YvesChibon 07 Aug '14

07 Aug '14

The branch 'dead_package' was created. Summary of new commits: 455473a... Prevent user from retiring packages that have no dead.packa f912ee5... Use http status code rather than the content of the dead.pa

1 0

[packagedb-cli] Do one API call for `orphan --retire`
by Pierre-YvesChibon 03 Aug '14

03 Aug '14

commit 468f48daef9630afadc596ffc1aa09ea6d9233fe Author: Pierre-Yves Chibon <pingou(a)pingoured.fr> Date: Sun Aug 3 16:23:17 2014 +0200 Do one API call for `orphan --retire` This will prevent the situation where the user orphans a package and then try to retire it which leads to two API calls while when calling the retire package endpoint we achieve the same result in only one call. pkgdb2client/cli.py | 11 +++++------ 1 files changed, 5 insertions(+), 6 deletions(-) --- diff --git a/pkgdb2client/cli.py b/pkgdb2client/cli.py index 592c47c..ba605cf 100644 --- a/pkgdb2client/cli.py +++ b/pkgdb2client/cli.py @@ -554,14 +554,13 @@ def do_orphan(args): pkgdbclient.username = args.username - output = pkgdbclient.orphan_packages(pkgs, branches) - for msg in output.get('messages', []): - print msg - if args.retire is True: output = pkgdbclient.retire_packages(pkgs, branches) - for msg in output.get('messages', []): - print msg + else: + output = pkgdbclient.orphan_packages(pkgs, branches) + + for msg in output.get('messages', []): + print msg def do_unorphan(args):

1 0

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

packagedb-cli-commits August 2014