packagedb-cli-commits May 2016

packagedb-cli-commits@lists.stg.fedorahosted.org

1 participants
18 discussions

[packagedb-cli] Created tag 2.13
by Pierre-YvesChibon 12 May '16

12 May '16

The signed tag '2.13' was created. Tagger: Pierre-Yves Chibon <pingou(a)pingoured.fr> Date: Thu May 12 12:49:29 2016 +0200 Release 2.13 Changes since the last tag '2.12': Pierre-Yves Chibon (11): Merge pull request #81 from tyll/utf8_summary Check if there is a pattern before checking what is in it Merge pull request #83 from fedora-infra/fix_list Merge pull request #86 from tyll/variable_typo Merge pull request #87 from tyll/autoapprove_branch Generalize __get_namespace to allow checking for other arguments Replace the call to `hasattr` by a try/except block Merge pull request #85 from fedora-infra/generalize_namespace If we get an invalid monitoring status, use the default when processing a request Merge pull request #96 from fedora-infra/fix_invalid_monitoring Release 2.13 Ralph Bean (4): Allow bzurl to be more flexible. Merge pull request #90 from fedora-infra/bz-url No retries, thank you. Merge pull request #92 from fedora-infra/no-retries-thankyou Till Maas (9): Fix UnicodeDecode error with bug.summary Fix PKGDBCLIENT variable name Auto approve branch requests by package admins Move action approve/deny code to own functions Add initial unretirement support Fix message about unsupported actions Do not assign unused variable Fix line length Merge pull request #88 from tyll/unretirerequests

1 0

[packagedb-cli] Release 2.13
by Pierre-YvesChibon 12 May '16

12 May '16

commit 82f0f136c34a02594eb772ea3daf1b81ad65b3a5 Author: Pierre-Yves Chibon <pingou(a)pingoured.fr> Date: Thu May 12 12:48:45 2016 +0200 Release 2.13 README.rst | 4 ++-- setup.py | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) --- diff --git a/README.rst b/README.rst index dce61b1..4249971 100644 --- a/README.rst +++ b/README.rst @@ -4,8 +4,8 @@ Fedora PackageDB-cli :Author: Pierre-Yves Chibon :Contact: pingou(a)fedoraproject.org -:Date: Thu Mar 03 2016 -:Version: 2.12 +:Date: Thu May 12 2016 +:Version: 2.13 The `PackageDB-cli` is a commande line interface to the PackageDB of Fedora. diff --git a/setup.py b/setup.py index 1a30a7d..e403231 100644 --- a/setup.py +++ b/setup.py @@ -8,7 +8,7 @@ from setuptools import setup setup( name='packagedb-cli', description='A command line tool to access the Fedora Package Database.', - version='2.12', + version='2.13', license='GPLv2+', download_url='https://fedorahosted.org/releases/p/a/packagedb-cli/', url='https://fedorahosted.org/packagedb-cli/',

1 0

[packagedb-cli: 15/15] Merge pull request #96 from fedora-infra/fix_invalid_monitoring
by Pierre-YvesChibon 12 May '16

12 May '16

commit a683175ae41842c4b393835072b6b16eaec15d92 Merge: 864018e ce94e45 Author: Pierre-Yves Chibon <pingou(a)pingoured.fr> Date: Fri May 6 11:08:14 2016 +0200 Merge pull request #96 from fedora-infra/fix_invalid_monitoring If we get an invalid monitoring status, use the default when processing a request pkgdb2client/admin.py | 8 +++++++- 1 files changed, 7 insertions(+), 1 deletions(-) ---

1 0

[packagedb-cli: 14/15] If we get an invalid monitoring status, use the default when processing a request
by Pierre-YvesChibon 12 May '16

12 May '16

commit ce94e451158ab505960322b3c3d266b171733120 Author: Pierre-Yves Chibon <pingou(a)pingoured.fr> Date: Sun Apr 24 19:45:47 2016 +0200 If we get an invalid monitoring status, use the default when processing a request pkgdb2client/admin.py | 8 +++++++- 1 files changed, 7 insertions(+), 1 deletions(-) --- diff --git a/pkgdb2client/admin.py b/pkgdb2client/admin.py index 440697f..0a21eae 100644 --- a/pkgdb2client/admin.py +++ b/pkgdb2client/admin.py @@ -316,6 +316,12 @@ def __handle_request_package(actionid, action): upstream = action['info'].get('pkg_upstream_url', None) if upstream: upstream = upstream.encode('utf-8') + + monitoring_status = action['info'].get('monitoring_status', True) + # If we get an invalid monitoring status, use the default + if str(monitoring_status) not in ['True', 'False', 'nobuild']: + monitoring_status = True + data = PKGDBCLIENT.create_package( pkgname=action['info']['pkg_name'].encode('utf-8'), summary=action['info']['pkg_summary'].encode('utf-8'), @@ -328,7 +334,7 @@ def __handle_request_package(actionid, action): upstream_url=upstream, critpath=action['info']['pkg_critpath'], namespace=action['info']['pkg_namespace'], - monitoring_status=action['info'].get('monitoring_status', True), + monitoring_status=monitoring_status, koschei=action['info'].get('koschei', False), )

1 0

[packagedb-cli: 13/15] Merge pull request #88 from tyll/unretirerequests
by Pierre-YvesChibon 12 May '16

12 May '16

commit 864018e170e7e5267c114745b1794e559a119ad2 Merge: eb0bca9 a54b66e Author: Till Maas <opensource(a)till.name> Date: Thu Apr 14 23:45:13 2016 +0200 Merge pull request #88 from tyll/unretirerequests Thank you pkgdb2client/admin.py | 125 +++++++++++++++++++++++++++++++++---------------- 1 files changed, 84 insertions(+), 41 deletions(-) ---

1 0

[packagedb-cli: 12/15] Fix line length
by Pierre-YvesChibon 12 May '16

12 May '16

commit a54b66e5932423194b83823053ea200543c4afa7 Author: Till Maas <opensource(a)till.name> Date: Sun Apr 10 22:45:14 2016 +0200 Fix line length pkgdb2client/admin.py | 6 ++++-- 1 files changed, 4 insertions(+), 2 deletions(-) --- diff --git a/pkgdb2client/admin.py b/pkgdb2client/admin.py index 99a2588..43d32a2 100644 --- a/pkgdb2client/admin.py +++ b/pkgdb2client/admin.py @@ -346,9 +346,11 @@ def __handle_request_package(actionid, action): approve_action(actionid) - ns = '%s/' % action['info'].get('pkg_namespace', 'rpms') + url = "{0}/package/{1}/{2}".format( + PKGDBCLIENT.base_url, + action['info'].get('pkg_namespace', 'rpms'), + action['info']['pkg_name']) - url = PKGDBCLIENT.base_url + '/package/' + ns + action['info']['pkg_name'] utils.comment_on_bug( bugid, 'Package request has been approved: %s' % url

1 0

[packagedb-cli: 11/15] Do not assign unused variable
by Pierre-YvesChibon 12 May '16

12 May '16

commit 2dd73576303cdaa2c15c769d11fbf68c11474a12 Author: Till Maas <opensource(a)till.name> Date: Sun Apr 10 22:23:36 2016 +0200 Do not assign unused variable pkgdb2client/admin.py | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) --- diff --git a/pkgdb2client/admin.py b/pkgdb2client/admin.py index 491c048..99a2588 100644 --- a/pkgdb2client/admin.py +++ b/pkgdb2client/admin.py @@ -335,7 +335,7 @@ def __handle_request_package(actionid, action): comaintainers = action['info'].get('co-maintainers') if comaintainers: for user in comaintainers.split(','): - output = PKGDBCLIENT.update_acl( + PKGDBCLIENT.update_acl( action['info']['pkg_name'], branches=action['info']['pkg_collection'], acls=['commit', 'watchbugzilla', 'watchcommits'],

1 0

[packagedb-cli: 10/15] Fix message about unsupported actions
by Pierre-YvesChibon 12 May '16

12 May '16

commit b23f6b3772c42bfab2b5585f1e704e6473df8c4e Author: Till Maas <opensource(a)till.name> Date: Sun Apr 10 22:17:31 2016 +0200 Fix message about unsupported actions The tool is pkgdb-admin pkgdb2client/admin.py | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) --- diff --git a/pkgdb2client/admin.py b/pkgdb2client/admin.py index 894d47f..491c048 100644 --- a/pkgdb2client/admin.py +++ b/pkgdb2client/admin.py @@ -524,7 +524,8 @@ def do_process(args): elif action['action'] == 'request.unretire': data = __handle_request_unretire(actionid, action) else: - print('Action %s not supported by pkgdb-cli' % action['action']) + print('Action {0} not supported by pkgdb-admin'.format( + action['action'])) continue for msg in data.get('messages', []):

1 0

[packagedb-cli: 9/15] Add initial unretirement support
by Pierre-YvesChibon 12 May '16

12 May '16

commit e8ab903f73f11f8097fe059d5db9b31091e9b281 Author: Till Maas <opensource(a)till.name> Date: Sat Apr 9 18:01:09 2016 +0200 Add initial unretirement support pkgdb2client/admin.py | 47 +++++++++++++++++++++++++++++++++++++++++++++++ 1 files changed, 47 insertions(+), 0 deletions(-) --- diff --git a/pkgdb2client/admin.py b/pkgdb2client/admin.py index 7f65417..894d47f 100644 --- a/pkgdb2client/admin.py +++ b/pkgdb2client/admin.py @@ -426,6 +426,51 @@ def __handle_request_branch(actionid, action, package): return data +def __handle_request_unretire(actionid, action): + ''' Handle unretirement requests. Do the same checks as done for new + package requests and ask the admin to do the necessary steps by hand. ''' + + bugid = action['info']['pkg_review_url'].rsplit('/', 1)[1] + if '=' in bugid: + bugid = bugid.split('=', 1)[1] + + # Add valuees to info that pkgdb adds to new package actions + action['info']['pkg_name'] = action['package']['name'] + action['info']['pkg_summary'] = action['package']['summary'] + action['info']['pkg_collection'] = action['collection'][ + 'branchname'] + action['info']['pkg_poc'] = action['user'] + # FIXME : Does not need to use .get() once + # https://github.com/fedora-infra/pkgdb2/pull/333 + # is deployed. + action['info']['pkg_namespace'] = action['package'].get( + 'namespace', 'rpms') + + msgs = utils.check_package_creation( + action['info'], bugid, PKGDBCLIENT, action['user']) + + bugid = utils.get_bug_id_from_url(action['info']['pkg_review_url']) + decision = _ask_what_to_do(msgs) + + if decision in ('a', 'approve'): + cmd = ("pkgdb-cli", "unorphan", "--poc", action['info']['pkg_poc'], + action['info']['pkg_name'], action['info']['pkg_collection']) + input("Please run the following command (confirm with any key): " + + " ".join(cmd)) + input("Please make sure the package is properly unblocked in koji. " + "(Confirm with any key)") + + data = approve_action(actionid) + + elif decision in ('deny', 'd'): + data, _ = deny_action(actionid) + else: + data = { + 'messages': ['Action {0} un-touched'.format(actionid)] + } + return data + + def do_process(args): ''' Process a specific admin action. @@ -476,6 +521,8 @@ def do_process(args): data = __handle_request_package(actionid, action) elif action['action'] == 'request.branch': data = __handle_request_branch(actionid, action, package) + elif action['action'] == 'request.unretire': + data = __handle_request_unretire(actionid, action) else: print('Action %s not supported by pkgdb-cli' % action['action']) continue

1 0

[packagedb-cli: 8/15] Merge pull request #92 from fedora-infra/no-retries-thankyou
by Pierre-YvesChibon 12 May '16

12 May '16

commit eb0bca934c091e1eab72e8350972127b1aff4639 Merge: ae62dec 32863b3 Author: Ralph Bean <rbean(a)redhat.com> Date: Tue Apr 12 13:20:16 2016 -0400 Merge pull request #92 from fedora-infra/no-retries-thankyou No retries, thank you. pkgdb2client/__init__.py | 3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) ---

1 0

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

packagedb-cli-commits May 2016