commit 727be75caa39090821864bf638ea55a33eb8696a Author: Pierre-Yves Chibon pingou@pingoured.fr Date: Mon May 4 10:13:19 2015 +0200

Report an error if the fedora-review flag is not set to `+`

The fedora-review flag must be set as `+` for a new package to be added to pkgdb. So far we were checking who set the flag to `+` but not *if* it has been set to this status.

This commit fixes this situation

pkgdb2client/utils.py | 4 ++++ 1 files changed, 4 insertions(+), 0 deletions(-) --- diff --git a/pkgdb2client/utils.py b/pkgdb2client/utils.py index 9747f82..63d1c71 100644 --- a/pkgdb2client/utils.py +++ b/pkgdb2client/utils.py @@ -204,6 +204,10 @@ def check_package_creation(info, bugid, pkgdbclient): messages.append( ' ! User {0} is not a packager but set the ' 'fedora-review flag to `+`'.format(flag['setter'])) + elif flag['name'] == 'fedora-review' and flag['status'] != '+': + messages.append( + ' ! fedora-review flag is no `+` but is still `%s`' % + flag['status'])

msgs2 = check_branch_creation( pkgdbclient,