I opened a bug on this here:
https://bugzilla.redhat.com/show_bug.cgi?id=1411037
I received an update to the weather-widget and am getting this error now when
I try to rebuild:
FAILED: ? tag-invalid : <icon> not allowed in appdata ? tag-invalid : stock icon is not valid [weather-widget] Validation of files failed
My understanding was that the desktop entry spec file was used to generate the desktop and xml files. Both are generated to include the icon tag - but now according to appstream-util this isn't allowed in the xml file any longer. I checked in /usr/share/appdata and did a random check on org.kde.plasma.colorpicker.appdata.xml among others and they also have the <icon> tag and also now fail.
I also looked here:https://www.freedesktop.org/software/appstream/docs https://www.freedesktop.org/software/appstream/docs/chap-CollectionData.html#sect-AppStream-XML
and it appears that the <icon> tag is valid./chap-CollectionData.html#sect-AppStream-XML https://www.freedesktop.org/software/appstream/docs/chap-CollectionData.html#sect-AppStream-XML
So it appears that we have an error in either the process which is autogenerating the appdata file or the validation program has a bug.
I can certainly hack around this, but would prefer not.
On 10 January 2017 at 23:29, Gerald B. Cox gbcox@bzb.us wrote:
I checked in /usr/share/appdata and did a random check on org.kde.plasma.colorpicker.appdata.xml among others and they also have the <icon> tag and also now fail.
I think appstream-util has always forbidden <icon> in appdata files, although that should have been restricted to desktop-type appdata components, not the 'generic' type that plasma uses.
I've fixed that in https://github.com/hughsie/appstream-glib/commit/5b6fd6c9c90e5dc4533388183fc...
So it appears that we have an error in either the process which is autogenerating the appdata file or the validation program has a bug.
Note: this is still a valid validation failure:
• tag-invalid : stock icon is not valid [color-picker]
...color-picker is not a stock icon name. I think removing the "type=stock" upstream will make the validator pass, and also the appstream-builder happier.
Richard
packaging@lists.fedoraproject.org