Do we want to treat the "gnome-shell-extension-common" package as an "artificial filesystem" package to be required by all gnome-shell-extension-* packages to get directory ownership right?
https://fedoraproject.org/wiki/Packaging:Guidelines#The_directory_is_owned_b...
[...]
Inspite of its package name not ending with "-filesystem" (would that be a MUST?), the package description suggests that it serves as a filesystem package:
$ rpm -qi gnome-shell-extension-common|tail -2 optional functionality to GNOME Shell. Common files and directories needed by extensions are provided here.
It's only a single directory, and the "gnome-shell" parent dir is pulled in via a dependency:
$ rpmls gnome-shell-extension-common|grep ^d drwxr-xr-x /usr/share/doc/gnome-shell-extension-common drwxr-xr-x /usr/share/gnome-shell/extensions
$ rpm -qR gnome-shell-extension-common|grep -v ^rpm gnome-shell >= 3.17.4
[...]
It has been pointed out during review that the package is not '''an "official" filesystem-package'''. And packagers happily take existing packages as example. A single gnome-shell-extension package by somebody from Red Hat owns the directory instead, giving the excuse to do it like that, too. All other extension packages add a dependency on that "artificial filesystem" package.
It would be good, if the gnome shell extensions addon package guidelines commented on this.
Unless we don't care about such directory ownership issues at all anymore. Then everybody is free to add "multiple ownership" in random ways. But so many complex guidelines -- for what?
That there are filesystem packages such as "hicolor-icon-theme" is not pretty already. What other filesystem packages are not named -filesystem?
Trying to explain that to [new] packagers can become quite a task.
[...]
https://fedoraproject.org/wiki/Packaging:NamingGuidelines#Addon_Packages_.28...
Addon Packages (gnome shell extensions)
Packages that extend gnome shell should begin with the prefix gnome-shell-extension-. In particular, this prefix should not be pluralized (ie: it should not be gnome-shell-extensions).
On 08/19/2015 12:45 PM, Michael Schwendt wrote:
Do we want to treat the "gnome-shell-extension-common" package as an "artificial filesystem" package to be required by all gnome-shell-extension-* packages to get directory ownership right?
https://fedoraproject.org/wiki/Packaging:Guidelines#The_directory_is_owned_b...
[...]
Inspite of its package name not ending with "-filesystem" (would that be a MUST?), the package description suggests that it serves as a filesystem package:
$ rpm -qi gnome-shell-extension-common|tail -2 optional functionality to GNOME Shell. Common files and directories needed by extensions are provided here.
It's only a single directory, and the "gnome-shell" parent dir is pulled in via a dependency:
$ rpmls gnome-shell-extension-common|grep ^d drwxr-xr-x /usr/share/doc/gnome-shell-extension-common drwxr-xr-x /usr/share/gnome-shell/extensions
$ rpm -qR gnome-shell-extension-common|grep -v ^rpm gnome-shell >= 3.17.4
[...]
It has been pointed out during review that the package is not '''an "official" filesystem-package'''. And packagers happily take existing packages as example. A single gnome-shell-extension package by somebody from Red Hat owns the directory instead, giving the excuse to do it like that, too. All other extension packages add a dependency on that "artificial filesystem" package.
gnome-shell-extension-common is an internal subpackage for the gnome-shell-extensions source package. Please don't make other packages that come from different source packages depend on it.
-common is only split out because it contains translations shared by all the extensions that come from the gnome-shell-extensions source package.
I went ahead and added an empty extensions directory (and search-providers directory) to gnome-shell itself, http://pkgs.fedoraproject.org/cgit/gnome-shell.git/commit/?id=a5548a25bf3aaa...
That should make it easier for extensions packages - just use 'Requires: gnome-shell' and the directory gets created along with gnome-shell.
On Wed, 19 Aug 2015 13:11:42 +0200, Kalev Lember wrote:
gnome-shell-extension-common is an internal subpackage for the gnome-shell-extensions source package. Please don't make other packages that come from different source packages depend on it.
Could the package description reflect that then, too?
| Common files and directories needed by | extensions are provided here.
is very general, given that we still need to "Requires: hicolor-icon-theme" as a filesystem package, too.
I went ahead and added an empty extensions directory (and search-providers directory) to gnome-shell itself, http://pkgs.fedoraproject.org/cgit/gnome-shell.git/commit/?id=a5548a25bf3aaa...
That should make it easier for extensions packages - just use 'Requires: gnome-shell' and the directory gets created along with gnome-shell.
The closer look at this issue is that other extension packages don't own /usr/share/gnome-shell/extensions/ so far. It's good if gnome-shell provides that dir. Thanks!
On 08/19/2015 01:21 PM, Michael Schwendt wrote:
Could the package description reflect that then, too?
| Common files and directories needed by | extensions are provided here.
I pushed http://pkgs.fedoraproject.org/cgit/gnome-shell-extensions.git/commit/?id=74d... that drops the extension directory ownership from -common and updates the package description. Is it better now?
On Wed, 19 Aug 2015 13:36:30 +0200, Kalev Lember wrote:
I pushed http://pkgs.fedoraproject.org/cgit/gnome-shell-extensions.git/commit/?id=74d... that drops the extension directory ownership from -common and updates the package description. Is it better now?
Yes. Thanks again!
packaging@lists.fedoraproject.org
-
Kalev Lember -
Michael Schwendt