requests dependency missing from setup.py/setup.cfg; bugzilla cli/modules fail to import on machines without requests package
Hello! I recently did a pip install of python-bugzilla, which installed 1.1.0, and when I tried running the bugzilla command it failed to execute because the requests module wasn't installed on my machine. Replacing requirements.txt with the following lines in setup.py should work:
install_requires=[ 'requests', ]
Also, if python-bugzilla depends on certain API versions of requests, it might be a good idea to do some sort of version checking; I know that the latest version of the requests package is not backwards compatible in many ways with the new one. Thanks! -Garrett
On Thu, 2014-09-11 at 14:36 -0700, Garrett Cooper wrote:
Hello! I recently did a pip install of python-bugzilla, which installed 1.1.0, and when I tried running the bugzilla command it failed to execute because the requests module wasn't installed on my machine. Replacing requirements.txt with the following lines in setup.py should work:
install_requires=[ 'requests', ]
This might be the easiest fix for this. But this would mean we will have to keep *requirements.txt in sync with setup.py (not too big a deal).
We could also do something like this, https://github.com/abn/python-bugzilla/commit/b66ba937bbc182476d0d59d4fbdf36... (might be over kill considering we do not depend on much).
The only real reason why we use *requirements.txt is to allow for setting up dev environments easily.
Neither of these changes should interfere with rpms. Not sure which is preferred.
Also, if python-bugzilla depends on certain API versions ofrequests, it might be a good idea to do some sort of version checking; I know that the latest version of the requests package is not backwards compatible in many ways with the new one.
This was intentionally left out as there are no known issues with backwards compatibility for the requests features we use, at least the ones that gets used in the tests and using requests==2.4.1.
If we were to require a lower version bound, then requests>=1.1.0 might be the one to use as this is the version shipped in epel-6 and this is known to work.
hth
-arun
Thanks! -Garrett _______________________________________________ python-bugzilla mailing list python-bugzilla@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/python-bugzilla
On Thu, Sep 11, 2014 at 10:04 PM, Arun Babu Neelicattu abn@redhat.com wrote:
On Thu, 2014-09-11 at 14:36 -0700, Garrett Cooper wrote:
Hello! I recently did a pip install of python-bugzilla, which installed 1.1.0, and when I tried running the bugzilla command it failed to execute because the requests module wasn't installed on my machine. Replacing requirements.txt with the following lines in setup.py should work:
install_requires=[ 'requests', ]This might be the easiest fix for this. But this would mean we will have to keep *requirements.txt in sync with setup.py (not too big a deal).
We could also do something like this, https://github.com/abn/python-bugzilla/commit/b66ba937bbc182476d0d59d4fbdf36... (might be over kill considering we do not depend on much).
The only real reason why we use *requirements.txt is to allow for setting up dev environments easily.
Neither of these changes should interfere with rpms. Not sure which is preferred.
Also, if python-bugzilla depends on certain API versions ofrequests, it might be a good idea to do some sort of version checking; I know that the latest version of the requests package is not backwards compatible in many ways with the new one.
This was intentionally left out as there are no known issues with backwards compatibility for the requests features we use, at least the ones that gets used in the tests and using requests==2.4.1.
If we were to require a lower version bound, then requests>=1.1.0 might be the one to use as this is the version shipped in epel-6 and this is known to work.
Hi Arun! LGTM -- thanks so much for the quick fix :)! Cheers, -Garrett
Garrett, np! I haven't submitted the patch yet. Will wait to see what Cole thinks.
-arun
----- Original Message -----
From: "Garrett Cooper" yanegomi@gmail.com To: "Arun Babu Neelicattu" abn@redhat.com Cc: python-bugzilla@lists.fedorahosted.org Sent: Friday, September 12, 2014 3:08:41 PM Subject: Re: [python-bugzilla] requests dependency missing from setup.py/setup.cfg; bugzilla cli/modules fail to import on machines without requests package
On Thu, Sep 11, 2014 at 10:04 PM, Arun Babu Neelicattu abn@redhat.com wrote:
On Thu, 2014-09-11 at 14:36 -0700, Garrett Cooper wrote:
Hello! I recently did a pip install of python-bugzilla, which installed 1.1.0, and when I tried running the bugzilla command it failed to execute because the requests module wasn't installed on my machine. Replacing requirements.txt with the following lines in setup.py should work:
install_requires=[ 'requests', ]This might be the easiest fix for this. But this would mean we will have to keep *requirements.txt in sync with setup.py (not too big a deal).
We could also do something like this, https://github.com/abn/python-bugzilla/commit/b66ba937bbc182476d0d59d4fbdf36... (might be over kill considering we do not depend on much).
The only real reason why we use *requirements.txt is to allow for setting up dev environments easily.
Neither of these changes should interfere with rpms. Not sure which is preferred.
Also, if python-bugzilla depends on certain API versions ofrequests, it might be a good idea to do some sort of version checking; I know that the latest version of the requests package is not backwards compatible in many ways with the new one.
This was intentionally left out as there are no known issues with backwards compatibility for the requests features we use, at least the ones that gets used in the tests and using requests==2.4.1.
If we were to require a lower version bound, then requests>=1.1.0 might be the one to use as this is the version shipped in epel-6 and this is known to work.
Hi Arun! LGTM -- thanks so much for the quick fix :)! Cheers, -Garrett
On 09/12/2014 01:15 AM, Arun Babu Neelicattu wrote:
Garrett, np! I haven't submitted the patch yet. Will wait to see what Cole thinks.
That example fix looks fine with me, please send-email it and I'll apply. Thanks Arun!
- Cole
----- Original Message -----
From: "Garrett Cooper" yanegomi@gmail.com To: "Arun Babu Neelicattu" abn@redhat.com Cc: python-bugzilla@lists.fedorahosted.org Sent: Friday, September 12, 2014 3:08:41 PM Subject: Re: [python-bugzilla] requests dependency missing from setup.py/setup.cfg; bugzilla cli/modules fail to import on machines without requests package
On Thu, Sep 11, 2014 at 10:04 PM, Arun Babu Neelicattu abn@redhat.com wrote:
On Thu, 2014-09-11 at 14:36 -0700, Garrett Cooper wrote:
Hello! I recently did a pip install of python-bugzilla, which installed 1.1.0, and when I tried running the bugzilla command it failed to execute because the requests module wasn't installed on my machine. Replacing requirements.txt with the following lines in setup.py should work:
install_requires=[ 'requests', ]This might be the easiest fix for this. But this would mean we will have to keep *requirements.txt in sync with setup.py (not too big a deal).
We could also do something like this, https://github.com/abn/python-bugzilla/commit/b66ba937bbc182476d0d59d4fbdf36... (might be over kill considering we do not depend on much).
The only real reason why we use *requirements.txt is to allow for setting up dev environments easily.
Neither of these changes should interfere with rpms. Not sure which is preferred.
Also, if python-bugzilla depends on certain API versions ofrequests, it might be a good idea to do some sort of version checking; I know that the latest version of the requests package is not backwards compatible in many ways with the new one.
This was intentionally left out as there are no known issues with backwards compatibility for the requests features we use, at least the ones that gets used in the tests and using requests==2.4.1.
If we were to require a lower version bound, then requests>=1.1.0 might be the one to use as this is the version shipped in epel-6 and this is known to work.
Hi Arun! LGTM -- thanks so much for the quick fix :)! Cheers, -Garrett
python-bugzilla mailing list python-bugzilla@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/python-bugzilla
On Fri, Sep 12, 2014 at 03:04:31PM +1000, Arun Babu Neelicattu wrote:
On Thu, 2014-09-11 at 14:36 -0700, Garrett Cooper wrote:
Hello! I recently did a pip install of python-bugzilla, which installed 1.1.0, and when I tried running the bugzilla command it failed to execute because the requests module wasn't installed on my machine. Replacing requirements.txt with the following lines in setup.py should work:
install_requires=[ 'requests', ]This might be the easiest fix for this. But this would mean we will have to keep *requirements.txt in sync with setup.py (not too big a deal).
We could also do something like this, https://github.com/abn/python-bugzilla/commit/b66ba937bbc182476d0d59d4fbdf36... (might be over kill considering we do not depend on much).
I just wanted to point out a possible other way to do it: https://github.com/fedora-infra/pkgdb2/blob/master/setup.py#L15
Pierre
On Sep 13, 2014, at 0:48, Pierre-Yves Chibon pingou@pingoured.fr wrote:
On Fri, Sep 12, 2014 at 03:04:31PM +1000, Arun Babu Neelicattu wrote:
On Thu, 2014-09-11 at 14:36 -0700, Garrett Cooper wrote:
Hello! I recently did a pip install of python-bugzilla, which installed 1.1.0, and when I tried running the bugzilla command it failed to execute because the requests module wasn't installed on my machine. Replacing requirements.txt with the following lines in setup.py should work:
install_requires=[ 'requests', ]
This might be the easiest fix for this. But this would mean we will have to keep *requirements.txt in sync with setup.py (not too big a deal).
We could also do something like this, https://github.com/abn/python-bugzilla/commit/b66ba937bbc182476d0d59d4fbdf36... (might be over kill considering we do not depend on much).
I just wanted to point out a possible other way to do it: https://github.com/fedora-infra/pkgdb2/blob/master/setup.py#L15
I added a comment to the commit: https://github.com/fedora-infra/pkgdb2/commit/69a724312e44737d0ad7567e7f6d6b... . Thank you, -Garrett
I'd prefer to use the initial implementation for this. The reason being that the requirement files can be more complex than just a list of requirements with comments [1]. It is easier to let the pip requirements parser handle all these intricacies than worry about keeping things up-to-date just to be future safe.
-arun
[1] http://pip.readthedocs.org/en/latest/reference/pip_install.html#requirements...
----- Original Message -----
From: "Pierre-Yves Chibon" pingou@pingoured.fr To: "Arun Babu Neelicattu" abn@redhat.com Cc: "Garrett Cooper" yanegomi@gmail.com, python-bugzilla@lists.fedorahosted.org Sent: Saturday, September 13, 2014 5:48:43 PM Subject: Re: [python-bugzilla] requests dependency missing from setup.py/setup.cfg; bugzilla cli/modules fail to import on machines without requests package
On Fri, Sep 12, 2014 at 03:04:31PM +1000, Arun Babu Neelicattu wrote:
On Thu, 2014-09-11 at 14:36 -0700, Garrett Cooper wrote:
Hello! I recently did a pip install of python-bugzilla, which installed 1.1.0, and when I tried running the bugzilla command it failed to execute because the requests module wasn't installed on my machine. Replacing requirements.txt with the following lines in setup.py should work:
install_requires=[ 'requests', ]This might be the easiest fix for this. But this would mean we will have to keep *requirements.txt in sync with setup.py (not too big a deal).
We could also do something like this, https://github.com/abn/python-bugzilla/commit/b66ba937bbc182476d0d59d4fbdf36... (might be over kill considering we do not depend on much).
I just wanted to point out a possible other way to do it: https://github.com/fedora-infra/pkgdb2/blob/master/setup.py#L15
Pierre
python-bugzilla@lists.stg.fedorahosted.org
-
Arun Babu Neelicattu -
Cole Robinson -
Garrett Cooper -
Pierre-Yves Chibon