-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-fedoraserver.rhcloud.com/r/92/
-----------------------------------------------------------
Review request for RoleKit Mailing List, Miloslav Trmac, Stephen Gallagher, and Thomas Woerner.
Repository: rolekit
Description
-------
Fixes https://fedorahosted.org/rolekit/ticket/23
Diffs
-----
src/rolekit/server/dbusrole.py fcdb175f49c4320c9817ca430727cfd6d3db4466
Diff: http://reviewboard-fedoraserver.rhcloud.com/r/92/diff/
Testing
-------
Thanks,
Thomas Woerner
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-fedoraserver.rhcloud.com/r/91/
-----------------------------------------------------------
Review request for RoleKit Mailing List, Miloslav Trmac, Stephen Gallagher, and Thomas Woerner.
Repository: rolekit
Description
-------
The following command will notify roled that there is could be an error:
dbus-send --system --dest=org.fedoraproject.rolekit1 \
/org/fedoraproject/rolekit1 \
org.fedoraproject.rolekit1.NotifyUnitFailed? \
string:'rolename' \
string:'instancename'
roled verifies if there is an error by getting the state from the unit target and moves the instance into error state in this case.
Also fixes the dbus-send call to use the --system option. Otherwise the session bus will be used.
New target_unit_state in dbus_utils to get the state form a target unit.
Diffs
-----
src/rolekit/dbus_utils.py 38aede076ca9c510c9c5853acfb11ec7673dbf06
src/rolekit/server/io/systemd.py 28b2591b21467eb0bd91483a610cbb7a592a4b27
src/rolekit/server/rolebase.py 909fdf5151820e09843ae3eb54a40ff7f0c03233
src/rolekit/server/roled.py 664c2873e8cc9c181c28806cfbc0d44d285b3693
Diff: http://reviewboard-fedoraserver.rhcloud.com/r/91/diff/
Testing
-------
Thanks,
Thomas Woerner
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-fedoraserver.rhcloud.com/r/90/
-----------------------------------------------------------
Review request for RoleKit Mailing List, Miloslav Trmac, Stephen Gallagher, and Thomas Woerner.
Repository: rolekit
Description
-------
If the role was running and the systemd target unit is inactive at roled wakeup, the instance will be moved into error state.
Diffs
-----
src/rolekit/dbus_utils.py 018e5fb4c878c7d61e89fff2559d42e4bc3c984c
src/rolekit/server/rolebase.py f9596e0bf15840d21869d434ae45ffa00dc53632
Diff: http://reviewboard-fedoraserver.rhcloud.com/r/90/diff/
Testing
-------
Thanks,
Thomas Woerner
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-fedoraserver.rhcloud.com/r/89/
-----------------------------------------------------------
(Updated Oct. 13, 2014, 2:21 p.m.)
Review request for RoleKit Mailing List, Miloslav Trmac, Stephen Gallagher, and Thomas Woerner.
Repository: rolekit
Description
-------
New package and group installation during role deployment
Diffs
-----
src/rolekit/server/rolebase.py f9596e0bf15840d21869d434ae45ffa00dc53632
config/roles/testrole/role.py 368e5d977d249042dbe453b9a636c24a93df6f55
Diff: http://reviewboard-fedoraserver.rhcloud.com/r/89/diff/
Testing
-------
Thanks,
Thomas Woerner
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-fedoraserver.rhcloud.com/r/89/
-----------------------------------------------------------
Review request for RoleKit Mailing List, Miloslav Trmac, Stephen Gallagher, and Thomas Woerner.
Repository: rolekit
Description
-------
New package and group installation during role deployment
Diffs
-----
config/roles/testrole/role.py 368e5d977d249042dbe453b9a636c24a93df6f55
src/rolekit/server/rolebase.py f9596e0bf15840d21869d434ae45ffa00dc53632
Diff: http://reviewboard-fedoraserver.rhcloud.com/r/89/diff/
Testing
-------
Thanks,
Thomas Woerner
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-fedoraserver.rhcloud.com/r/88/
-----------------------------------------------------------
Review request for RoleKit Mailing List, Miloslav Trmac, Stephen Gallagher, and Thomas Woerner.
Repository: rolekit
Description
-------
This also moves the default implementation of start() and stop()
into RoleBase. It can be overridden by the roles if they need to
perform additional operations.
Diffs
-----
config/roles/domaincontroller/role.py 4074bc946e9571de18ac0ec16ffe8d0aef6983bf
config/roles/testrole/role.py 211e26819134d0ddf8031aeba2bad432e83bbfc5
src/rolekit/server/rolebase.py 7765323d0c0ab4fab5c7a0dafd8ded8ffbb891b4
Diff: http://reviewboard-fedoraserver.rhcloud.com/r/88/diff/
Testing
-------
Thanks,
Stephen Gallagher
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-fedoraserver.rhcloud.com/r/87/
-----------------------------------------------------------
Review request for RoleKit Mailing List, Miloslav Trmac, Stephen Gallagher, and Thomas Woerner.
Repository: rolekit
Description
-------
Support target in testrole
Diffs
-----
config/roles/testrole/role.py 211e26819134d0ddf8031aeba2bad432e83bbfc5
Diff: http://reviewboard-fedoraserver.rhcloud.com/r/87/diff/
Testing
-------
Thanks,
Stephen Gallagher
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-fedoraserver.rhcloud.com/r/86/
-----------------------------------------------------------
Review request for RoleKit Mailing List, Miloslav Trmac, Stephen Gallagher, and Thomas Woerner.
Repository: rolekit
Description
-------
RoleBase: Handle NULL types
Diffs
-----
src/rolekit/server/rolebase.py 7765323d0c0ab4fab5c7a0dafd8ded8ffbb891b4
Diff: http://reviewboard-fedoraserver.rhcloud.com/r/86/diff/
Testing
-------
Thanks,
Stephen Gallagher
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-fedoraserver.rhcloud.com/r/85/
-----------------------------------------------------------
Review request for RoleKit Mailing List, Miloslav Trmac, Stephen Gallagher, and Thomas Woerner.
Repository: rolekit
Description
-------
Also renames setup_dns to serve_dns to better reflect the role
rather than just the installation command.
Diffs
-----
config/roles/domaincontroller/role.py 4074bc946e9571de18ac0ec16ffe8d0aef6983bf
Diff: http://reviewboard-fedoraserver.rhcloud.com/r/85/diff/
Testing
-------
Thanks,
Stephen Gallagher
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-fedoraserver.rhcloud.com/r/82/
-----------------------------------------------------------
Review request for RoleKit Mailing List, Miloslav Trmac, Stephen Gallagher, and Thomas Woerner.
Repository: rolekit
Description
-------
This patch causes new systemd unit files to be generated when a
role is deployed.
Target: This unit file will ensure that all dependent services are
started when the role is launched.
Extension units: These units extend the existing dependent
services and provide the reverse of the above: they ensure that
stopping the role target stops all of the dependent processes. It
also guarantees that a failure of one of these processes updates
the rolekit state for the role.
Failure unit: This is a special unit that emits a DBUS message to
roled if one of the dependent services has failed.
Diffs
-----
config/roles/domaincontroller/role.py 4074bc946e9571de18ac0ec16ffe8d0aef6983bf
configure.ac 67b01d330aa08822e87eb0c8e8f086aeef756d78
src/Makefile.am 0a4193038be7aeac2bcc017fd2552e72dd501c2a
src/rolekit/config/__init__.py.in 3e71532fcb71fb34c3ae087c2d502ec1f55138f9
src/rolekit/server/io/systemd.py PRE-CREATION
src/rolekit/server/rolebase.py 7765323d0c0ab4fab5c7a0dafd8ded8ffbb891b4
Diff: http://reviewboard-fedoraserver.rhcloud.com/r/82/diff/
Testing
-------
Thanks,
Stephen Gallagher