-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-fedoraserver.rhcloud.com/r/124/
-----------------------------------------------------------
Review request for RoleKit Mailing List, Miloslav Trmac, Stephen Gallagher, Simo Sorce, and Thomas Woerner.
Repository: rolekit
Description
-------
Many server installers will automatically start their services as
soon as installation is complete (such as FreeIPA). This means that
the real state of the system will disagree with rolekit's view of
it. To be sure that we are aligned, it makes the most sense to just
ensure that all roles are deployed into the RUNNING state.
Diffs
-----
src/rolekit/server/rolebase.py 7f960bf41206c2552996936839a100325382e3be
Diff: http://reviewboard-fedoraserver.rhcloud.com/r/124/diff/
Testing
-------
Deployed a domain controller and verified that after deployment, 'rolectl status domaincontroller/teeceetwo.sgallagh.rht' reported "running" and 'systemctl status role-domaincontroller-teeceetwo.sgallagh.rht.target' reported "active".
Thanks,
Stephen Gallagher
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-fedoraserver.rhcloud.com/r/125/
-----------------------------------------------------------
Review request for RoleKit Mailing List, Miloslav Trmac, Stephen Gallagher, and Thomas Woerner.
Bugs: 34
https://fedorahosted.org/rolekit/ticket/34
Repository: rolekit
Description
-------
We apparently missed restart() when handling the start() and stop()
operations as asynchronous.
Diffs
-----
src/rolekit/server/rolebase.py 7f960bf41206c2552996936839a100325382e3be
Diff: http://reviewboard-fedoraserver.rhcloud.com/r/125/diff/
Testing
-------
Built it and verified that the restart actually succeeded instead of returning a python error.
Thanks,
Stephen Gallagher
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-fedoraserver.rhcloud.com/r/122/
-----------------------------------------------------------
Review request for RoleKit Mailing List, Miloslav Trmac, Stephen Gallagher, and Thomas Woerner.
Repository: rolekit
Description
-------
If _MAX_INSTANCES is defined in the role, then it will be used as the maximum
count of instances for this role. If is is not defined, the global
MAX_INSTANCES definition will be used.
To set a different maximum instance count, add _MAX_INSTANCES=X to the Role
definition in role.py next to _DEFAULTS and _READONLY_SETTINGS.
Diffs
-----
src/rolekit/server/dbusrole.py 5f978215a94e304ae76b410a59ec7f598219cedc
Diff: http://reviewboard-fedoraserver.rhcloud.com/r/122/diff/
Testing
-------
Thanks,
Thomas Woerner
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-fedoraserver.rhcloud.com/r/123/
-----------------------------------------------------------
Review request for RoleKit Mailing List, Miloslav Trmac, Stephen Gallagher, and Thomas Woerner.
Repository: rolekit
Description
-------
rolekit.roles.xml: Add more information to do_check_property method
Diffs
-----
doc/xml/rolekit.roles.xml 58733254f97a8b80cc04501a95543e9acb923836
Diff: http://reviewboard-fedoraserver.rhcloud.com/r/123/diff/
Testing
-------
Thanks,
Thomas Woerner
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-fedoraserver.rhcloud.com/r/121/
-----------------------------------------------------------
Review request for RoleKit Mailing List, Miloslav Trmac, Stephen Gallagher, and Thomas Woerner.
Repository: rolekit
Description
-------
The instance will be removed again if the verification of settings failed in
the check_values call.
This can not be done with the deploy call in the plugin easily, because it is
not known if the plugin already changed any system settings.
Diffs
-----
src/rolekit/server/rolebase.py 09e610114574f1d5a09cc2e1b80c940cb166ce48
Diff: http://reviewboard-fedoraserver.rhcloud.com/r/121/diff/
Testing
-------
Thanks,
Thomas Woerner
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-fedoraserver.rhcloud.com/r/111/
-----------------------------------------------------------
Review request for RoleKit Mailing List, Miloslav Trmac, Stephen Gallagher, and Thomas Woerner.
Repository: rolekit
Description
-------
docs: Updated global rolekit man page.
Diffs
-----
doc/xml/rolekit.xml ce3a709c84446534bac19d9ec2fce6a1133de241
doc/xml/transform-man.xsl.in 066644b61861a39e22eb7807e26417392eac2c8c
Diff: http://reviewboard-fedoraserver.rhcloud.com/r/111/diff/
Testing
-------
Thanks,
Thomas Woerner
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-fedoraserver.rhcloud.com/r/115/
-----------------------------------------------------------
Review request for RoleKit Mailing List, Miloslav Trmac, Stephen Gallagher, and Thomas Woerner.
Repository: rolekit
Description
-------
We don't want testrole on a real system, so we'll move it to %doc.
Diffs
-----
rolekit.spec 015ef12ae8462cd0025e2e6b71c338474e65329d
Diff: http://reviewboard-fedoraserver.rhcloud.com/r/115/diff/
Testing
-------
Thanks,
Stephen Gallagher
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-fedoraserver.rhcloud.com/r/117/
-----------------------------------------------------------
Review request for RoleKit Mailing List, Miloslav Trmac, Stephen Gallagher, and Thomas Woerner.
Repository: rolekit
Description
-------
The database server role hasn't been implemented yet. We should
avoid shipping it in packages until it has been.
Diffs
-----
rolekit.spec 015ef12ae8462cd0025e2e6b71c338474e65329d
Diff: http://reviewboard-fedoraserver.rhcloud.com/r/117/diff/
Testing
-------
Thanks,
Stephen Gallagher
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-fedoraserver.rhcloud.com/r/118/
-----------------------------------------------------------
Review request for RoleKit Mailing List, Miloslav Trmac, Stephen Gallagher, and Thomas Woerner.
Repository: rolekit
Description
-------
FreeIPA 4.1 will fix the bug making this option mandatory. We will
be shipping rolekit together with that release, so we should relax
this check.
This should not be pushed upstream until FreeIPA 4.1 is submitted for stable in Fedora.
Diffs
-----
config/roles/domaincontroller/role.py b36cb15b2890555f077cdb14d2d2240d8a882d9b
Diff: http://reviewboard-fedoraserver.rhcloud.com/r/118/diff/
Testing
-------
Installed the FreeIPA 4.1 testing packages and ran a deploy without **primary_ip** specified in the settings.json file.
Thanks,
Stephen Gallagher
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-fedoraserver.rhcloud.com/r/119/
-----------------------------------------------------------
Review request for RoleKit Mailing List, Miloslav Trmac, Stephen Gallagher, and Thomas Woerner.
Repository: rolekit
Description
-------
Domain Controller: reverse_zone can take multiple options
Diffs
-----
config/roles/domaincontroller/role.py b36cb15b2890555f077cdb14d2d2240d8a882d9b
doc/xml/rolekit.roles.domaincontroller.xml eb685a862ac29f07c2b9a51cae6d33f69148d18d
Diff: http://reviewboard-fedoraserver.rhcloud.com/r/119/diff/
Testing
-------
Thanks,
Stephen Gallagher