-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-fedoraserver.rhcloud.com/r/124/
-----------------------------------------------------------
Review request for RoleKit Mailing List, Miloslav Trmac, Stephen Gallagher, Simo Sorce, and Thomas Woerner.
Repository: rolekit
Description
-------
Many server installers will automatically start their services as
soon as installation is complete (such as FreeIPA). This means that
the real state of the system will disagree with rolekit's view of
it. To be sure that we are aligned, it makes the most sense to just
ensure that all roles are deployed into the RUNNING state.
Diffs
-----
src/rolekit/server/rolebase.py 7f960bf41206c2552996936839a100325382e3be
Diff: http://reviewboard-fedoraserver.rhcloud.com/r/124/diff/
Testing
-------
Deployed a domain controller and verified that after deployment, 'rolectl status domaincontroller/teeceetwo.sgallagh.rht' reported "running" and 'systemctl status role-domaincontroller-teeceetwo.sgallagh.rht.target' reported "active".
Thanks,
Stephen Gallagher
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-fedoraserver.rhcloud.com/r/125/
-----------------------------------------------------------
Review request for RoleKit Mailing List, Miloslav Trmac, Stephen Gallagher, and Thomas Woerner.
Bugs: 34
https://fedorahosted.org/rolekit/ticket/34
Repository: rolekit
Description
-------
We apparently missed restart() when handling the start() and stop()
operations as asynchronous.
Diffs
-----
src/rolekit/server/rolebase.py 7f960bf41206c2552996936839a100325382e3be
Diff: http://reviewboard-fedoraserver.rhcloud.com/r/125/diff/
Testing
-------
Built it and verified that the restart actually succeeded instead of returning a python error.
Thanks,
Stephen Gallagher