-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-fedoraserver.rhcloud.com/r/17/
-----------------------------------------------------------
Review request for RoleKit Mailing List, Stephen Gallagher and Thomas Woerner.
Repository: rolekit
Description
-------
Simplifies the role interface
Role cleanup by dropping "failonthis" setting
Diffs
-----
config/roles/testrole/role.py 2f077c62b4a8027e7783a2e08c84bc9c9715393e
src/rolekit/server/rolebase.py 50b5685a038789d02d3f3b0451f5edaecc187964
Diff: http://reviewboard-fedoraserver.rhcloud.com/r/17/diff/
Testing
-------
Thanks,
Thomas Woerner
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-fedoraserver.rhcloud.com/r/55/
-----------------------------------------------------------
Review request for RoleKit Mailing List, Stephen Gallagher and Thomas Woerner.
Repository: rolekit
Description
-------
Fixes https://fedorahosted.org/rolekit/ticket/3
Diffs
-----
src/rolekit/server/dbusrole.py 8a13ccccbb0c9d2940f485697d9d2ef644183b15
src/rolekit/server/roled.py 59d1523347325b20d666c99d8c2087c8ce486608
Diff: http://reviewboard-fedoraserver.rhcloud.com/r/55/diff/
Testing
-------
Thanks,
Thomas Woerner
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-fedoraserver.rhcloud.com/r/54/
-----------------------------------------------------------
Review request for RoleKit Mailing List, Stephen Gallagher and Thomas Woerner.
Repository: rolekit
Description
-------
Implement starting and stopping services, and use it in databaseserver.
Includes some work-in-progress edits to databaseserver, IMHO harmless enough but will split them if asked.
Now rereading this, should the StartUnit/StopUnit D-Bus calls be non-blocking as well? At this late hour I’m inclined to say that they are explicitly designed to be returning quickly, so it isn’t really necessary.
Diffs
-----
TODO 053560af7e811ae9d26b7eafff92ac2786af5408
config/roles/databaseserver/role.py b632321de63c331b3b3d0445d134fe1626e9944c
src/rolekit/dbus_utils.py fb21cec2681f60ec2ad30372c4caf285e8ba13a7
src/rolekit/server/rolebase.py d53c745352183944e307cca5259a58f058f81e27
Diff: http://reviewboard-fedoraserver.rhcloud.com/r/54/diff/
Testing
-------
starting/stopping postgres through d-feet.
Thanks,
Miloslav Trmac
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-fedoraserver.rhcloud.com/r/56/
-----------------------------------------------------------
Review request for RoleKit Mailing List, Stephen Gallagher and Thomas Woerner.
Repository: rolekit
Description
-------
This really does call for a decorator that allows us to just say
@dbus_service_method_async
def deploy_async(..., no_handlers_here):
yield None
but that’s for later.
Diffs
-----
src/rolekit/async.py 1e2b82eab5a4e6862594672f738c1935a83c2be5
src/rolekit/server/dbusrole.py 8a13ccccbb0c9d2940f485697d9d2ef644183b15
src/rolekit/server/decorators.py a0c8cf4a86a7391843c33b98e344532b564868e5
src/rolekit/server/rolebase.py d53c745352183944e307cca5259a58f058f81e27
Diff: http://reviewboard-fedoraserver.rhcloud.com/r/56/diff/
Testing
-------
Thanks,
Miloslav Trmac
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-fedoraserver.rhcloud.com/r/47/
-----------------------------------------------------------
Review request for RoleKit Mailing List, Stephen Gallagher and Thomas Woerner.
Repository: rolekit
Description
-------
Comments to the tune of
# Check values
self.check_values(values)
IMHO only make the code less readable. Drop them.
Diffs
-----
src/rolekit/server/rolebase.py b72071da1b0570f93dd31841747d0ea6967262da
Diff: http://reviewboard-fedoraserver.rhcloud.com/r/47/diff/
Testing
-------
Thanks,
Miloslav Trmac
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-fedoraserver.rhcloud.com/r/52/
-----------------------------------------------------------
Review request for RoleKit Mailing List, Stephen Gallagher and Thomas Woerner.
Repository: rolekit
Description
-------
Add d-bus service file to the RPM spec
Diffs
-----
rolekit.spec d1e88dc210fcd40534f21393d7fb27c9eec8c5e5
Diff: http://reviewboard-fedoraserver.rhcloud.com/r/52/diff/
Testing
-------
Thanks,
Stephen Gallagher
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-fedoraserver.rhcloud.com/r/58/
-----------------------------------------------------------
Review request for RoleKit Mailing List, Stephen Gallagher and Thomas Woerner.
Repository: rolekit
Description
-------
After the rolekit service has been started roled is active and is not terminating automatically again. Calling timeout_restart after start is activating the timer in slib.dbus which is taking care on this.
Diffs
-----
src/rolekit/server/roled.py 59d1523347325b20d666c99d8c2087c8ce486608
Diff: http://reviewboard-fedoraserver.rhcloud.com/r/58/diff/
Testing
-------
Thanks,
Thomas Woerner
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-fedoraserver.rhcloud.com/r/57/
-----------------------------------------------------------
Review request for RoleKit Mailing List, Stephen Gallagher and Thomas Woerner.
Repository: rolekit
Description
-------
roled: New persistent option for debugging
Diffs
-----
src/roled f24580ce2a9e845f74a2e4485c6f4dea2734527b
src/rolekit/server/dbusrole.py 8a13ccccbb0c9d2940f485697d9d2ef644183b15
src/rolekit/server/roled.py 59d1523347325b20d666c99d8c2087c8ce486608
src/rolekit/server/server.py c6b550d6d3605fe7847b678617eb96f4317c03f6
Diff: http://reviewboard-fedoraserver.rhcloud.com/r/57/diff/
Testing
-------
Thanks,
Thomas Woerner
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-fedoraserver.rhcloud.com/r/53/
-----------------------------------------------------------
Review request for RoleKit Mailing List, Stephen Gallagher and Thomas Woerner.
Repository: rolekit
Description
-------
Let’s keep them in sync from now on.
(Yeah, this is pretty much a pointless statement of intent. But sgallagh and me ended up with a similar commit, so let’s get it into the repo.)
Diffs
-----
config/roles/databaseserver/role.py b632321de63c331b3b3d0445d134fe1626e9944c
config/roles/domaincontroller/role.py b632321de63c331b3b3d0445d134fe1626e9944c
Diff: http://reviewboard-fedoraserver.rhcloud.com/r/53/diff/
Testing
-------
Thanks,
Miloslav Trmac
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-fedoraserver.rhcloud.com/r/51/
-----------------------------------------------------------
Review request for RoleKit Mailing List, Stephen Gallagher and Thomas Woerner.
Repository: rolekit
Description
-------
Adds --with-systemd-unitdir="$$dc_install_base"/$(prefix)/lib/systemd/system" to DISTCHECK_CONFIGURE_FLAGS in Makefile.am
Diffs
-----
Makefile.am 8f3982952d593f09666ff6dd4c9e9fa9b787b3df
configure.ac 0c2622c7391c88e700aeab97d8e0af6d974dd194
Diff: http://reviewboard-fedoraserver.rhcloud.com/r/51/diff/
Testing
-------
Thanks,
Thomas Woerner