rolekit-commits July 2014

rolekit-commits@lists.stg.fedorahosted.org

4 participants
79 discussions

Review Request 50: New org.fedoraproject.rolekit1.service for dbus activation
by Stephen Gallagher 28 Jul '14

28 Jul '14

----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-fedoraserver.rhcloud.com/r/50/ ----------------------------------------------------------- Review request for RoleKit Mailing List, Stephen Gallagher and Thomas Woerner. Repository: rolekit Description ------- pkg-config dbus-1 --variable=system_bus_services_dir is used in configure to get the default value of the system. New BuildRequires for dbus-devel to get the default directory. Diffs ----- config/Makefile.am 97787cfadeb49bf29265026789dcc6be0b6d3a5d config/org.fedoraproject.rolekit1.service PRE-CREATION configure.ac 0c2622c7391c88e700aeab97d8e0af6d974dd194 rolekit.spec 479b6c5e4fc367aad9749aa3aca4b9962e25dc1a Diff: http://reviewboard-fedoraserver.rhcloud.com/r/50/diff/ Testing ------- Thanks, Thomas Woerner

1 10

Review Request 41: Fix (make distcheck)
by Stephen Gallagher 28 Jul '14

28 Jul '14

----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-fedoraserver.rhcloud.com/r/41/ ----------------------------------------------------------- Review request for RoleKit Mailing List, Stephen Gallagher and Thomas Woerner. Repository: rolekit Description ------- Drop gsettings references when we don’t use gsettings at all; they break (make uninstall). Minimally fix role installation/uninstallation; really we should be using EXTRA_DIST ro something like that. Diffs ----- config/Makefile.am 9cf038785819caf150007508b1b14b8b76a6b86e configure.ac 9b939152c8a418d95dcbf3f9bdeb065deb1cd43c Diff: http://reviewboard-fedoraserver.rhcloud.com/r/41/diff/ Testing ------- Thanks, Miloslav Trmac

1 6

Review Request 49: Drop po/Makefile.in.in from git
by Stephen Gallagher 28 Jul '14

28 Jul '14

----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-fedoraserver.rhcloud.com/r/49/ ----------------------------------------------------------- Review request for RoleKit Mailing List, Stephen Gallagher and Thomas Woerner. Summary (updated) ----------------- Drop po/Makefile.in.in from git Repository: rolekit Description (updated) ------- It is generated same as */Makefile.in and should be treated equally. In practical terms, this being a symlink doesn’t work well across merges/rebases for me (tends to be replaced with a regular file that contains a path the symlink pointed to), and dropping it from git is I suppose a workaround. Diffs (updated) ----- po/.gitignore 2d5954523907190fccfc3ab81010015e7914057b po/Makefile.in.in e4713cf8444cd46d9c6f60bbfe6f42bcdd0455c8 Diff: http://reviewboard-fedoraserver.rhcloud.com/r/49/diff/ Testing ------- Thanks, Miloslav Trmac

1 3

Review Request 48: Convert start and stop methods to asynchronous
by Stephen Gallagher 28 Jul '14

28 Jul '14

----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-fedoraserver.rhcloud.com/r/48/ ----------------------------------------------------------- Review request for RoleKit Mailing List, Stephen Gallagher and Thomas Woerner. Repository: rolekit Description ------- Convert start and stop methods to asynchronous Prerequisite to actually implementing them, which will have to wait for next week. Diffs ----- config/roles/testrole/role.py 536fa28e0065b449330ac30f1a72d155000e98cb src/rolekit/server/rolebase.py b72071da1b0570f93dd31841747d0ea6967262da Diff: http://reviewboard-fedoraserver.rhcloud.com/r/48/diff/ Testing ------- None!! Thanks, Miloslav Trmac

1 4

Review Request 46: RoleBase.deploy_async: Use a single try/except block
by Stephen Gallagher 28 Jul '14

28 Jul '14

1 4

Review Request 45: Drop a @dbus_handle_exception wrapper.
by Stephen Gallagher 28 Jul '14

28 Jul '14

1 3

Review Request 44: Make rolebase.deploy() async-capable
by Stephen Gallagher 28 Jul '14

28 Jul '14

----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-fedoraserver.rhcloud.com/r/44/ ----------------------------------------------------------- Review request for RoleKit Mailing List, Stephen Gallagher and Thomas Woerner. Repository: rolekit Description ------- This patch passes two callbacks, reply_handler and error_handler into the deploy() methods. Long-waiting routines should then be coroutines using rolekit.async. RoleBase.deploy and RoleBase.do_deploy have correspondingly been renamed to RoleBase.deploy_async and RoleBase.do_deploy_async. Diffs ----- config/roles/testrole/role.py 536fa28e0065b449330ac30f1a72d155000e98cb src/rolekit/server/dbusrole.py 668ec95d9dc67052dcecc666588b8c00a94d52be src/rolekit/server/rolebase.py b72071da1b0570f93dd31841747d0ea6967262da Diff: http://reviewboard-fedoraserver.rhcloud.com/r/44/diff/ Testing ------- Thanks, Miloslav Trmac

1 7

Review Request 43: Add async utility code
by Stephen Gallagher 28 Jul '14

28 Jul '14

----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-fedoraserver.rhcloud.com/r/43/ ----------------------------------------------------------- Review request for RoleKit Mailing List, Stephen Gallagher and Thomas Woerner. Repository: rolekit Description ------- Also start a test suite. Diffs ----- .gitignore 5b99a1b0f870727292f4e489490a714564635f82 Makefile.am c77de8ad586806a95e0f8a0b975548754def4a1b src/Makefile.am 7909bef5adc47bca69b04f76cff574f4db00dd74 src/rolekit/async.py PRE-CREATION tests/.gitignore PRE-CREATION tests/async_test.py PRE-CREATION Diff: http://reviewboard-fedoraserver.rhcloud.com/r/43/diff/ Testing ------- Thanks, Miloslav Trmac

1 10

Review Request 42: Add .gitignore entries
by Stephen Gallagher 28 Jul '14

28 Jul '14

----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-fedoraserver.rhcloud.com/r/42/ ----------------------------------------------------------- Review request for RoleKit Mailing List, Stephen Gallagher and Thomas Woerner. Repository: rolekit Description ------- Ordinarily a builddir!=srcdir build would prevent us from having to specify most of these, but that is not practical when parts of the source tree are generated and Python insists on importing “rolekit” from either buiddir or srcdir but not both. Diffs ----- doc/graphics/.gitignore PRE-CREATION doc/html/.gitignore PRE-CREATION doc/man/man1/.gitignore PRE-CREATION doc/man/man5/.gitignore PRE-CREATION doc/xml/.gitignore PRE-CREATION po/.gitignore 9fa4fa3d593fa2ab615e857a6b0d387a31b9b911 Diff: http://reviewboard-fedoraserver.rhcloud.com/r/42/diff/ Testing ------- Thanks, Miloslav Trmac

1 6

Review Request 40: Remove an unused import.
by Stephen Gallagher 28 Jul '14

28 Jul '14

1 3

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

rolekit-commits July 2014