rolekit-commits July 2014

rolekit-commits@lists.stg.fedorahosted.org

4 participants
79 discussions

Review Request 39: Remove an unused variable.
by Stephen Gallagher 28 Jul '14

28 Jul '14

----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-fedoraserver.rhcloud.com/r/39/ ----------------------------------------------------------- Review request for RoleKit Mailing List, Stephen Gallagher and Thomas Woerner. Repository: rolekit Description ------- Remove an unused variable. Diffs ----- src/rolekit/server/decorators.py 213cf3c3c26dbe8c16c996bad5b3c91df644cd59 Diff: http://reviewboard-fedoraserver.rhcloud.com/r/39/diff/ Testing ------- Thanks, Miloslav Trmac

1 6

Review Request 38: Fix typos
by Stephen Gallagher 28 Jul '14

28 Jul '14

----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-fedoraserver.rhcloud.com/r/38/ ----------------------------------------------------------- Review request for RoleKit Mailing List, Stephen Gallagher and Thomas Woerner. Repository: rolekit Description ------- Fix typos Diffs ----- src/rolekit/server/decorators.py 213cf3c3c26dbe8c16c996bad5b3c91df644cd59 src/rolekit/server/rolebase.py b72071da1b0570f93dd31841747d0ea6967262da Diff: http://reviewboard-fedoraserver.rhcloud.com/r/38/diff/ Testing ------- Thanks, Miloslav Trmac

1 3

Review Request 37: Add docstrings
by Stephen Gallagher 28 Jul '14

28 Jul '14

----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-fedoraserver.rhcloud.com/r/37/ ----------------------------------------------------------- Review request for RoleKit Mailing List, Stephen Gallagher and Thomas Woerner. Repository: rolekit Description ------- Add docstrings Diffs ----- src/rolekit/server/dbusrole.py 668ec95d9dc67052dcecc666588b8c00a94d52be src/rolekit/server/rolebase.py b72071da1b0570f93dd31841747d0ea6967262da Diff: http://reviewboard-fedoraserver.rhcloud.com/r/37/diff/ Testing ------- Thanks, Miloslav Trmac

1 3

Review Request 36: Silence Eclipse about an undefined variable.
by Stephen Gallagher 28 Jul '14

28 Jul '14

----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-fedoraserver.rhcloud.com/r/36/ ----------------------------------------------------------- Review request for RoleKit Mailing List, Stephen Gallagher and Thomas Woerner. Repository: rolekit Description ------- Silence Eclipse about an undefined variable. Diffs ----- src/rolekit/functions.py 959954a1df2d6eea109c42e87e8026a29192cd48 Diff: http://reviewboard-fedoraserver.rhcloud.com/r/36/diff/ Testing ------- Thanks, Miloslav Trmac

1 3

Review Request 35: Make rolebase.deploy() async-capable
by Stephen Gallagher 28 Jul '14

28 Jul '14

----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-fedoraserver.rhcloud.com/r/35/ ----------------------------------------------------------- Review request for RoleKit Mailing List, Stephen Gallagher and Thomas Woerner. Repository: rolekit Description ------- (This is a replacement for #18 , updated against recent deploy() changes.) This patch passes two callbacks, reply_handler and error_handler into the deploy() methods. We can pass these handlers down into asynchronous functions to allow us to avoid blocking on long- waiting routines. This patch prepares the system for async operation but the call to do_deploy() in the rolebase is still synchronous. Diffs ----- src/rolekit/server/dbusrole.py 668ec95d9dc67052dcecc666588b8c00a94d52be src/rolekit/server/rolebase.py b72071da1b0570f93dd31841747d0ea6967262da Diff: http://reviewboard-fedoraserver.rhcloud.com/r/35/diff/ Testing ------- None Thanks, Miloslav Trmac

1 2

Review Request 18: Make rolebase.deploy() async-capable
by Stephen Gallagher 28 Jul '14

28 Jul '14

----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-fedoraserver.rhcloud.com/r/18/ ----------------------------------------------------------- Review request for RoleKit Mailing List, Miloslav Trmac, Stephen Gallagher, and Thomas Woerner. Repository: rolekit Description ------- This patch passes two callbacks, reply_handler and error_handler into the deploy() methods. We can pass these handlers down into asynchronous functions to allow us to avoid blocking on long- waiting routines. This patch prepares the system for async operation but the call to do_deploy() in the rolebase is still synchronous. Diffs ----- src/rolekit/server/dbusrole.py 6cef7cfeba6a7bbe396601c7ab31fe034757bc6a src/rolekit/server/rolebase.py 50b5685a038789d02d3f3b0451f5edaecc187964 Diff: http://reviewboard-fedoraserver.rhcloud.com/r/18/diff/ Testing ------- I used d-feet to test the deploy() method on the testrole. It behaves as it used to. Thanks, Stephen Gallagher

1 12

Review Request 33: Include role state diagram
by Stephen Gallagher 28 Jul '14

28 Jul '14

----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-fedoraserver.rhcloud.com/r/33/ ----------------------------------------------------------- Review request for RoleKit Mailing List, Stephen Gallagher and Thomas Woerner. Repository: rolekit Description ------- This patch adds a graphviz doc and a Makefile to turn it into a PNG visualization of the state diagram. It intentionally does not include the output in 'make install'. It can be used in the future to supplement documentation. Diffs ----- configure.ac 98336261c008397e54f6cffc359e69de22010222 doc/Makefile.am 57aba61935096629d68653d2396bbbe406ced8d0 doc/graphics/Makefile.am PRE-CREATION doc/graphics/server_role_states.dot PRE-CREATION Diff: http://reviewboard-fedoraserver.rhcloud.com/r/33/diff/ Testing ------- ran autogen.sh ran 'make' and verified that the server_role_states.png was generated. ran 'make clean' and verified that server_role_states.png was removed. ran 'make test-rpm' and verified that server_role_states.png was not included. Thanks, Stephen Gallagher

1 6

Re: Review Request 40: Remove an unused import.
by Stephen Gallagher 25 Jul '14

25 Jul '14

----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-fedoraserver.rhcloud.com/r/40/#review133 ----------------------------------------------------------- I am not generally happy with all the “import *” essentially nullifying modularity (note that “*” re-imports modules like ”os” as well!), but that’s for our collective copious spare time. - Miloslav Trmac On None, Miloslav Trmac wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviewboard-fedoraserver.rhcloud.com/r/40/ > ----------------------------------------------------------- > > Review request for RoleKit Mailing List, Stephen Gallagher and Thomas Woerner. > > > Repository: rolekit > > > Description > ------- > > Remove an unused import. > > > Diffs > ----- > > src/rolekit/server/io/rolesettings.py 7008126e5f6dc5058268e9cd85a0e7019ea715fa > > Diff: http://reviewboard-fedoraserver.rhcloud.com/r/40/diff/ > > > Testing > ------- > > > Thanks, > > Miloslav Trmac > >

1 1

Review Request 34: RoleBase: _check_property: Only raise MISSING_CHECK if prop is not catched
by Stephen Gallagher 22 Jul '14

22 Jul '14

----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-fedoraserver.rhcloud.com/r/34/ ----------------------------------------------------------- Review request for RoleKit Mailing List, Stephen Gallagher and Thomas Woerner. Repository: rolekit Description ------- RoleBase: _check_property: Only raise MISSING_CHECK if prop is not catched Diffs ----- src/rolekit/server/rolebase.py 50b5685a038789d02d3f3b0451f5edaecc187964 Diff: http://reviewboard-fedoraserver.rhcloud.com/r/34/diff/ Testing ------- Thanks, Thomas Woerner

1 3

Review Request 32: rolectl : Use json to decode values for --set option with deploy and redeploy
by Stephen Gallagher 22 Jul '14

22 Jul '14

----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-fedoraserver.rhcloud.com/r/32/ ----------------------------------------------------------- Review request for RoleKit Mailing List, Stephen Gallagher and Thomas Woerner. Repository: rolekit Description ------- Examples: rolectl deploy testrole --set custom_firewall=true rolectl redeploy testrole/1 --set firewall_zones='["work", "public"]' custom_firewall=false lease enter the commit message for your changes. Lines starting Diffs ----- src/rolectl 47044818ee66f0f12af4682ef19360f85db89180 Diff: http://reviewboard-fedoraserver.rhcloud.com/r/32/diff/ Testing ------- Thanks, Thomas Woerner

1 5

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

rolekit-commits July 2014