rolekit-commits July 2014

rolekit-commits@lists.stg.fedorahosted.org

4 participants
79 discussions

Review Request 10: Fixed states according to Stephens diagram to provide transitional states
by Stephen Gallagher 17 Jul '14

17 Jul '14

1 4

Review Request 5: Silence a warning about an undefined variable
by Stephen Gallagher 16 Jul '14

16 Jul '14

----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-fedoraserver.rhcloud.com/r/5/ ----------------------------------------------------------- Review request for RoleKit Mailing List, Stephen Gallagher and Thomas Woerner. Repository: rolekit Description ------- a = undefined_variable_name is way too obvious for static analysis tools to detect; if we want to raise an exception, use something rarer. This doesn’t change behavior of the test code; the log in /tmp/log handles both NameError and ZeroDivisionError in the same way. Eventually, we might end up just with an explicit raise SomeExceptionType but that’s a less realistic test code, so let’s not do it just now. Diffs ----- src/rolekit/logger.py 9ad2464b00daa748e87cd137b7dade2d160c9313 Diff: http://reviewboard-fedoraserver.rhcloud.com/r/5/diff/ Testing ------- Thanks, Miloslav Trma?

1 3

Review Request 6: Fix undefined references to b2u
by Stephen Gallagher 16 Jul '14

16 Jul '14

1 2

Review Request 9: Fix a copy/paste error, undefined symbol “x”
by Stephen Gallagher 16 Jul '14

16 Jul '14

1 2

Review Request 8: Fix a typo in Role[Kk]itError
by Stephen Gallagher 16 Jul '14

16 Jul '14

1 2

Review Request 7: Define MISSING_CHECK error type
by Stephen Gallagher 16 Jul '14

16 Jul '14

1 2

Review Request 4: Makefile.am: Fixed update-po target, updated po/POTFILES*, added po/rolekit.pot
by Stephen Gallagher 15 Jul '14

15 Jul '14

----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-fedoraserver.rhcloud.com/r/4/ ----------------------------------------------------------- Review request for RoleKit Mailing List, Stephen Gallagher and Thomas Woerner. Repository: rolekit Description ------- Makefile.am: Fixed update-po target, updated po/POTFILES*, added po/rolekit.pot Diffs ----- po/POTFILES.in f317ad9ff1c031391c2c75358469819bdc8e4289 po/rolekit.pot PRE-CREATION Makefile.am 81b0fde0de59bfc6267baa289ac94382a3fdff0b po/POTFILES 8a49596d4fcef46b3c3a7991a0666d6127200687 Diff: http://reviewboard-fedoraserver.rhcloud.com/r/4/diff/ Testing ------- Thanks, Thomas Woerner

1 5

Review Request 2: Add placeholders for Domain Controller and Database roles
by Stephen Gallagher 14 Jul '14

14 Jul '14

----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-fedoraserver.rhcloud.com/r/2/ ----------------------------------------------------------- Review request for RoleKit Mailing List, Stephen Gallagher and Thomas Woerner. Repository: rolekit Description ------- Add placeholders for Domain Controller and Database roles Diffs ----- config/Makefile.am 88f68818c877eeadf05e3c6bccea77e6693d428c config/roles/databaseserver/role.py PRE-CREATION config/roles/domaincontroller/role.py PRE-CREATION Diff: http://reviewboard-fedoraserver.rhcloud.com/r/2/diff/ Testing ------- Started up rolekit and examined with d-feet that the new roles were available and functioned equivalently to the testrole. Thanks, Stephen Gallagher

1 7

Review Request 310: improved testrole
by Thomas Woerner 11 Jul '14

11 Jul '14

----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://fedorahosted.org/reviewboard/r/310/ ----------------------------------------------------------- Review request for rolekit reviewers, Stephen Gallagher and Thomas Woerner. Repository: rolekit Description ------- - Added missing imports for dbus type conversion and possible method calls - Dropped "backup_paths" setting from _DEFAULS - Added own setting "myownsetting" altogether with an extended get_dbus_property method - Added not covered "failonthis" setting to show error message in the log with get_dbus_property calls Diffs ----- config/roles/testrole/role.py 5a47874456eaa3a1de5793b86e96f7c01a6d641d Diff: https://fedorahosted.org/reviewboard/r/310/diff/ Testing ------- Thanks, Thomas Woerner

2 2

Review Request 309: Fix DEFAULTS method in src/rolekit/server/dbusrole
by Thomas Woerner 11 Jul '14

11 Jul '14

----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://fedorahosted.org/reviewboard/r/309/ ----------------------------------------------------------- Review request for rolekit reviewers, Stephen Gallagher and Thomas Woerner. Repository: rolekit Description ------- - Fixed the name of the property method - Use try to not trace back for unknown properties Diffs ----- src/rolekit/server/dbusrole.py 272bde8acf8793155c7c6323d0aa3ffda45ceb74 Diff: https://fedorahosted.org/reviewboard/r/309/diff/ Testing ------- Thanks, Thomas Woerner

2 2

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

rolekit-commits July 2014