-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-fedoraserver.rhcloud.com/r/1/
-----------------------------------------------------------
Review request for RoleKit Developers.
Repository: rolekit
Description
-------
Update .reviewboardrc
Move to new ReviewBoard 2.0 server
Diffs
-----
.reviewboardrc 7b38d7b4edcc4e660da6a481e8fec0e68aaab490
Diff: http://reviewboard-fedoraserver.rhcloud.com/r/1/diff/
Testing
-------
Submitted this review request.
Thanks,
Stephen Gallagher
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://fedorahosted.org/reviewboard/r/307/
-----------------------------------------------------------
Review request for rolekit reviewers, Stephen Gallagher and Thomas Woerner.
Repository: rolekit
Description
-------
- currently limited to one instance per role, see MAX_INSTANCES in config/
- new class _DEFAULTS in RoleBase
- New src/rolekit/server/dbusrole.py for presenting the role in D-Bus with DEFAULTS property, getInstances, getNamedInstance and deploy methods and InstanceAdded and InstanceRemoved signals
- roled: Use of new src/rolekit/server/dbusrole.DBusRole, new methods getAllRoleInstances and getAllRoleInstancesByState, removed getRolesByState (state only in an instance)
- Basic implementation of src/rolekit/server/rolebase.RoleBase deploy and decommission methods, new StateChanged signal
Diffs
-----
src/rolekit/server/roled.py 9682988dbdf62e9331cb5b0d997abe0db417d9a6
src/rolekit/server/rolebase.py 3d5a85e5deb186df2a13b41d6ac1285f88c89126
src/rolekit/server/dbusrole.py PRE-CREATION
src/Makefile.am ee4e308af0e28243c83a9ee117dba3a55229e9ab
Diff: https://fedorahosted.org/reviewboard/r/307/diff/
Testing
-------
Thanks,
Thomas Woerner
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://fedorahosted.org/reviewboard/r/304/
-----------------------------------------------------------
Review request for rolekit reviewers, Stephen Gallagher and Thomas Woerner.
Repository: rolekit
Description
-------
Simplified src/rolekit/server/io/rolesettings.RoleSettings, new remove method
Diffs
-----
src/rolekit/server/io/rolesettings.py 671a40a36be363a4d0e8f9446dc4e1c2277cbcd5
Diff: https://fedorahosted.org/reviewboard/r/304/diff/
Testing
-------
Thanks,
Thomas Woerner
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://fedorahosted.org/reviewboard/r/308/
-----------------------------------------------------------
Review request for rolekit reviewers, Stephen Gallagher and Thomas Woerner.
Repository: rolekit
Description
-------
config/roles/testrole/role.py using new DEFAULTS, new documentation
Diffs
-----
config/roles/testrole/role.py 377a8e038564f9e717de1c06bfd114b6e1712f76
Diff: https://fedorahosted.org/reviewboard/r/308/diff/
Testing
-------
Thanks,
Thomas Woerner
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://fedorahosted.org/reviewboard/r/302/
-----------------------------------------------------------
Review request for rolekit reviewers, Stephen Gallagher and Thomas Woerner.
Repository: rolekit
Description
-------
Limits the maximum number of instances per role
Diffs
-----
src/rolekit/config/__init__.py.in 3b9751d15cec40337a1c21e187b8a4b13461c5be
Diff: https://fedorahosted.org/reviewboard/r/302/diff/
Testing
-------
Thanks,
Thomas Woerner
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://fedorahosted.org/reviewboard/r/301/
-----------------------------------------------------------
Review request for rolekit reviewers, Stephen Gallagher and Thomas Woerner.
Repository: rolekit
Description
-------
Do not remove config/testrole/role.py with make clean
Diffs
-----
config/Makefile.am 13846cfbcc566041627f5fc272fb38ec8893e12e
Diff: https://fedorahosted.org/reviewboard/r/301/diff/
Testing
-------
Thanks,
Thomas Woerner
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://fedorahosted.org/reviewboard/r/303/
-----------------------------------------------------------
Review request for rolekit reviewers, Stephen Gallagher and Thomas Woerner.
Repository: rolekit
Description
-------
New error codes: TOO_MANY_INSTANCES and NAME_CONFLICT
Diffs
-----
src/rolekit/errors.py e3ec07ebfed3f8276396aecbf3504ec9182e37e6
Diff: https://fedorahosted.org/reviewboard/r/303/diff/
Testing
-------
Thanks,
Thomas Woerner
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://fedorahosted.org/reviewboard/r/300/
-----------------------------------------------------------
Review request for rolekit reviewers, Stephen Gallagher and Thomas Woerner.
Repository: rolekit
Description
-------
Renamed src/rolekit/server/role.py to src/rolekit/server/rolebase.py
Diffs
-----
src/rolekit/server/role.py
src/Makefile.am ee4e308af0e28243c83a9ee117dba3a55229e9ab
config/roles/testrole/role.py 377a8e038564f9e717de1c06bfd114b6e1712f76
Diff: https://fedorahosted.org/reviewboard/r/300/diff/
Testing
-------
Thanks,
Thomas Woerner
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://fedorahosted.org/reviewboard/r/305/
-----------------------------------------------------------
Review request for rolekit reviewers, Stephen Gallagher and Thomas Woerner.
Repository: rolekit
Description
-------
Renamed DBUS_INTERFACE_ROLES to DBUS_INTERFACE_ROLE
Diffs
-----
src/rolekit/server/rolebase.py 65f8eaace55ad18167e1bf7d86ff276450a809f1
src/rolekit/config/dbus.py 8cdae30d9aa3259717347e3b87a0a024ad203028
src/rolekit/client.py d447ace320024b809d7010538f09ebb3b6fcf74c
Diff: https://fedorahosted.org/reviewboard/r/305/diff/
Testing
-------
Thanks,
Thomas Woerner
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://fedorahosted.org/reviewboard/r/306/
-----------------------------------------------------------
Review request for rolekit reviewers, Stephen Gallagher and Thomas Woerner.
Repository: rolekit
Description
-------
New src/rolekit/config/dbus.DBUS_INTERFACE_ROLE_INSTANCE
Diffs
-----
src/rolekit/config/dbus.py 8cdae30d9aa3259717347e3b87a0a024ad203028
Diff: https://fedorahosted.org/reviewboard/r/306/diff/
Testing
-------
Thanks,
Thomas Woerner