-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-fedoraserver.rhcloud.com/r/66/
-----------------------------------------------------------
Review request for RoleKit Mailing List, Miloslav Trmac, Stephen Gallagher, and Thomas Woerner.
Repository: rolekit
Description
-------
This is needed to be able to check types of role specific properties.
Diffs
-----
config/roles/testrole/role.py 358deca3fc7172929d53d2c77efd5c919da2aea9
src/rolekit/server/rolebase.py 8591f8aade76d3463647c59b43cc83877698182d
Diff: http://reviewboard-fedoraserver.rhcloud.com/r/66/diff/
Testing
-------
Thanks,
Thomas Woerner
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-fedoraserver.rhcloud.com/r/69/
-----------------------------------------------------------
Review request for RoleKit Mailing List, Miloslav Trmac, Stephen Gallagher, and Thomas Woerner.
Repository: rolekit
Description
-------
installFirewall uses the firewall _settings from the role: firewall and firewall_zones and stores the applied settings in _settings per zone and also for the runtime and permanant firewalld environment.
uninstallFirewall uses the fw_changes _setting from the role and removed them from the zones in runtime and permanent firewalld environment, then clears fw_changes and savet it to _settings again.
updateFirewall calls uninstallFirewall and then installFirewall
_check_property now checks ports to be valid.
Diffs
-----
src/rolekit/server/rolebase.py 783804e3f8529232b1c0327de4d87130aaca119d
Diff: http://reviewboard-fedoraserver.rhcloud.com/r/69/diff/
Testing
-------
Thanks,
Thomas Woerner
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-fedoraserver.rhcloud.com/r/75/
-----------------------------------------------------------
Review request for RoleKit Mailing List, Miloslav Trmac, Stephen Gallagher, and Thomas Woerner.
Repository: rolekit
Description
-------
- Use get_property and get_dbus_property (non-static).
- Porperties are "name" and "DEFAULTS"
Diffs
-----
src/rolekit/server/dbusrole.py 0750dc4a79171865d0dbfb79baba6bc38125c678
Diff: http://reviewboard-fedoraserver.rhcloud.com/r/75/diff/
Testing
-------
Thanks,
Thomas Woerner
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-fedoraserver.rhcloud.com/r/17/
-----------------------------------------------------------
Review request for RoleKit Mailing List, Stephen Gallagher and Thomas Woerner.
Repository: rolekit
Description
-------
Simplifies the role interface
Role cleanup by dropping "failonthis" setting
Diffs
-----
config/roles/testrole/role.py 2f077c62b4a8027e7783a2e08c84bc9c9715393e
src/rolekit/server/rolebase.py 50b5685a038789d02d3f3b0451f5edaecc187964
Diff: http://reviewboard-fedoraserver.rhcloud.com/r/17/diff/
Testing
-------
Thanks,
Thomas Woerner
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-fedoraserver.rhcloud.com/r/74/
-----------------------------------------------------------
Review request for RoleKit Mailing List, Miloslav Trmac, Stephen Gallagher, and Thomas Woerner.
Repository: rolekit
Description
-------
Domain Controller: Add decommission routine
Diffs
-----
config/roles/domaincontroller/role.py 358deca3fc7172929d53d2c77efd5c919da2aea9
Diff: http://reviewboard-fedoraserver.rhcloud.com/r/74/diff/
Testing
-------
Created and removed a FreeIPA instance successfully.
Thanks,
Stephen Gallagher
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-fedoraserver.rhcloud.com/r/63/
-----------------------------------------------------------
Review request for RoleKit Mailing List, Miloslav Trmac, Stephen Gallagher, Simo Sorce, and Thomas Woerner.
Repository: rolekit
Description
-------
Domain Controller deployment
Diffs
-----
config/roles/domaincontroller/role.py 358deca3fc7172929d53d2c77efd5c919da2aea9
Diff: http://reviewboard-fedoraserver.rhcloud.com/r/63/diff/
Testing
-------
Performed a mostly-successful deployment of FreeIPA onto a Fedora 21 VM.
(Mostly-successful because there appears to be an ipa-server-install bug preventing successful completion, but that should be irrelevant to this patch).
Thanks,
Stephen Gallagher
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-fedoraserver.rhcloud.com/r/72/
-----------------------------------------------------------
Review request for RoleKit Mailing List, Miloslav Trmac, Stephen Gallagher, and Thomas Woerner.
Repository: rolekit
Description
-------
There are several places where we simply log an exception without
any context. This patch adds the exception type to these messages
to improve debugging.
Diffs
-----
src/rolekit/async.py 8a3dfdcf8f86fa0d475d4f95d7dd7aa45a40517f
src/rolekit/server/decorators.py ae30cd8ad7d16b02accdc95bd0dd0f22cbc581ae
src/rolekit/server/rolebase.py cd28d6a47cf183f6017905034f178d7aecf83348
Diff: http://reviewboard-fedoraserver.rhcloud.com/r/72/diff/
Testing
-------
Thanks,
Stephen Gallagher
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-fedoraserver.rhcloud.com/r/55/
-----------------------------------------------------------
Review request for RoleKit Mailing List, Stephen Gallagher and Thomas Woerner.
Repository: rolekit
Description
-------
Fixes https://fedorahosted.org/rolekit/ticket/3
Diffs
-----
src/rolekit/server/dbusrole.py 8a13ccccbb0c9d2940f485697d9d2ef644183b15
src/rolekit/server/roled.py 59d1523347325b20d666c99d8c2087c8ce486608
Diff: http://reviewboard-fedoraserver.rhcloud.com/r/55/diff/
Testing
-------
Thanks,
Thomas Woerner
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-fedoraserver.rhcloud.com/r/71/
-----------------------------------------------------------
Review request for RoleKit Mailing List, Miloslav Trmac, Stephen Gallagher, and Thomas Woerner.
Repository: rolekit
Description
-------
In the original approach, it was impossible to monitor the
progress of a subprocess because all of the stdout/stderr was
being buffered for retrieval only after the process exited.
With this patch, we will now drop stdout into log.debug1() and
stderr into log.error() as they come in (in addition to storing
the complete results for retrieval later). This will make
debugging efforts much simpler.
Diffs
-----
src/rolekit/async.py 8a3dfdcf8f86fa0d475d4f95d7dd7aa45a40517f
Diff: http://reviewboard-fedoraserver.rhcloud.com/r/71/diff/
Testing
-------
Testing was performed alongside the Domain Controller deployment. With this patch, I was able to see how far along the deployment had gotten.
Thanks,
Stephen Gallagher