August 2014 - rolekit-commits - Fedora mailing-lists

Review Request 66: New support for do_check_property
by Stephen Gallagher 02 Oct '14

02 Oct '14

----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-fedoraserver.rhcloud.com/r/66/ ----------------------------------------------------------- Review request for RoleKit Mailing List, Miloslav Trmac, Stephen Gallagher, and Thomas Woerner. Repository: rolekit Description ------- This is needed to be able to check types of role specific properties. Diffs ----- config/roles/testrole/role.py 358deca3fc7172929d53d2c77efd5c919da2aea9 src/rolekit/server/rolebase.py 8591f8aade76d3463647c59b43cc83877698182d Diff: http://reviewboard-fedoraserver.rhcloud.com/r/66/diff/ Testing ------- Thanks, Thomas Woerner

1 10

Review Request 69: RoleBase: Implement installFirewall, updateFirewall and uninstallFirewall
by Stephen Gallagher 02 Oct '14

02 Oct '14

----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-fedoraserver.rhcloud.com/r/69/ ----------------------------------------------------------- Review request for RoleKit Mailing List, Miloslav Trmac, Stephen Gallagher, and Thomas Woerner. Repository: rolekit Description ------- installFirewall uses the firewall _settings from the role: firewall and firewall_zones and stores the applied settings in _settings per zone and also for the runtime and permanant firewalld environment. uninstallFirewall uses the fw_changes _setting from the role and removed them from the zones in runtime and permanent firewalld environment, then clears fw_changes and savet it to _settings again. updateFirewall calls uninstallFirewall and then installFirewall _check_property now checks ports to be valid. Diffs ----- src/rolekit/server/rolebase.py 783804e3f8529232b1c0327de4d87130aaca119d Diff: http://reviewboard-fedoraserver.rhcloud.com/r/69/diff/ Testing ------- Thanks, Thomas Woerner

1 8

Review Request 75: Fixed D-Bus compatibility code in DBusRole
by Stephen Gallagher 02 Sep '14

02 Sep '14

----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-fedoraserver.rhcloud.com/r/75/ ----------------------------------------------------------- Review request for RoleKit Mailing List, Miloslav Trmac, Stephen Gallagher, and Thomas Woerner. Repository: rolekit Description ------- - Use get_property and get_dbus_property (non-static). - Porperties are "name" and "DEFAULTS" Diffs ----- src/rolekit/server/dbusrole.py 0750dc4a79171865d0dbfb79baba6bc38125c678 Diff: http://reviewboard-fedoraserver.rhcloud.com/r/75/diff/ Testing ------- Thanks, Thomas Woerner

1 3

Review Request 17: RoleBase: New do_get_property and do_get_dbus_property in roles
by Stephen Gallagher 29 Aug '14

29 Aug '14

----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-fedoraserver.rhcloud.com/r/17/ ----------------------------------------------------------- Review request for RoleKit Mailing List, Stephen Gallagher and Thomas Woerner. Repository: rolekit Description ------- Simplifies the role interface Role cleanup by dropping "failonthis" setting Diffs ----- config/roles/testrole/role.py 2f077c62b4a8027e7783a2e08c84bc9c9715393e src/rolekit/server/rolebase.py 50b5685a038789d02d3f3b0451f5edaecc187964 Diff: http://reviewboard-fedoraserver.rhcloud.com/r/17/diff/ Testing ------- Thanks, Thomas Woerner

1 17

Review Request 74: Domain Controller: Add decommission routine
by Stephen Gallagher 22 Aug '14

22 Aug '14

----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-fedoraserver.rhcloud.com/r/74/ ----------------------------------------------------------- Review request for RoleKit Mailing List, Miloslav Trmac, Stephen Gallagher, and Thomas Woerner. Repository: rolekit Description ------- Domain Controller: Add decommission routine Diffs ----- config/roles/domaincontroller/role.py 358deca3fc7172929d53d2c77efd5c919da2aea9 Diff: http://reviewboard-fedoraserver.rhcloud.com/r/74/diff/ Testing ------- Created and removed a FreeIPA instance successfully. Thanks, Stephen Gallagher

1 3

Review Request 63: Domain Controller deployment
by Stephen Gallagher 21 Aug '14

21 Aug '14

----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-fedoraserver.rhcloud.com/r/63/ ----------------------------------------------------------- Review request for RoleKit Mailing List, Miloslav Trmac, Stephen Gallagher, Simo Sorce, and Thomas Woerner. Repository: rolekit Description ------- Domain Controller deployment Diffs ----- config/roles/domaincontroller/role.py 358deca3fc7172929d53d2c77efd5c919da2aea9 Diff: http://reviewboard-fedoraserver.rhcloud.com/r/63/diff/ Testing ------- Performed a mostly-successful deployment of FreeIPA onto a Fedora 21 VM. (Mostly-successful because there appears to be an ipa-server-install bug preventing successful completion, but that should be irrelevant to this patch). Thanks, Stephen Gallagher

1 14

Review Request 72: Improve exception logging
by Stephen Gallagher 21 Aug '14

21 Aug '14

----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-fedoraserver.rhcloud.com/r/72/ ----------------------------------------------------------- Review request for RoleKit Mailing List, Miloslav Trmac, Stephen Gallagher, and Thomas Woerner. Repository: rolekit Description ------- There are several places where we simply log an exception without any context. This patch adds the exception type to these messages to improve debugging. Diffs ----- src/rolekit/async.py 8a3dfdcf8f86fa0d475d4f95d7dd7aa45a40517f src/rolekit/server/decorators.py ae30cd8ad7d16b02accdc95bd0dd0f22cbc581ae src/rolekit/server/rolebase.py cd28d6a47cf183f6017905034f178d7aecf83348 Diff: http://reviewboard-fedoraserver.rhcloud.com/r/72/diff/ Testing ------- Thanks, Stephen Gallagher

1 3

Review Request 73: Make decommission asynchronous
by Stephen Gallagher 21 Aug '14

21 Aug '14

----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-fedoraserver.rhcloud.com/r/73/ ----------------------------------------------------------- Review request for RoleKit Mailing List, Miloslav Trmac, Stephen Gallagher, and Thomas Woerner. Repository: rolekit Description ------- Make decommission asynchronous Diffs ----- config/roles/databaseserver/role.py 63687c0be4a5705e772f1a6d60932f69ce9850e7 config/roles/domaincontroller/role.py 358deca3fc7172929d53d2c77efd5c919da2aea9 config/roles/testrole/role.py 358deca3fc7172929d53d2c77efd5c919da2aea9 src/rolekit/server/rolebase.py cd28d6a47cf183f6017905034f178d7aecf83348 Diff: http://reviewboard-fedoraserver.rhcloud.com/r/73/diff/ Testing ------- Verified alongside the Domain Controller decommission() patch (https://reviewboard-fedoraserver.rhcloud.com/r/74/) Thanks, Stephen Gallagher

1 2

Review Request 55: DBusRole: New method get_name, using in RoleD.getNamedRole
by Stephen Gallagher 20 Aug '14

20 Aug '14

----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-fedoraserver.rhcloud.com/r/55/ ----------------------------------------------------------- Review request for RoleKit Mailing List, Stephen Gallagher and Thomas Woerner. Repository: rolekit Description ------- Fixes https://fedorahosted.org/rolekit/ticket/3 Diffs ----- src/rolekit/server/dbusrole.py 8a13ccccbb0c9d2940f485697d9d2ef644183b15 src/rolekit/server/roled.py 59d1523347325b20d666c99d8c2087c8ce486608 Diff: http://reviewboard-fedoraserver.rhcloud.com/r/55/diff/ Testing ------- Thanks, Thomas Woerner

1 7

Review Request 71: Enable logging of subprocess output
by Stephen Gallagher 20 Aug '14

20 Aug '14

----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-fedoraserver.rhcloud.com/r/71/ ----------------------------------------------------------- Review request for RoleKit Mailing List, Miloslav Trmac, Stephen Gallagher, and Thomas Woerner. Repository: rolekit Description ------- In the original approach, it was impossible to monitor the progress of a subprocess because all of the stdout/stderr was being buffered for retrieval only after the process exited. With this patch, we will now drop stdout into log.debug1() and stderr into log.error() as they come in (in addition to storing the complete results for retrieval later). This will make debugging efforts much simpler. Diffs ----- src/rolekit/async.py 8a3dfdcf8f86fa0d475d4f95d7dd7aa45a40517f Diff: http://reviewboard-fedoraserver.rhcloud.com/r/71/diff/ Testing ------- Testing was performed alongside the Domain Controller deployment. With this patch, I was able to see how far along the deployment had gotten. Thanks, Stephen Gallagher

1 6

Review Request 54: Implement starting and stopping services, and use it in databaseserver.
by Stephen Gallagher 19 Aug '14

19 Aug '14

----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-fedoraserver.rhcloud.com/r/54/ ----------------------------------------------------------- Review request for RoleKit Mailing List, Stephen Gallagher and Thomas Woerner. Repository: rolekit Description ------- Implement starting and stopping services, and use it in databaseserver. Includes some work-in-progress edits to databaseserver, IMHO harmless enough but will split them if asked. Now rereading this, should the StartUnit/StopUnit D-Bus calls be non-blocking as well? At this late hour I’m inclined to say that they are explicitly designed to be returning quickly, so it isn’t really necessary. Diffs ----- TODO 053560af7e811ae9d26b7eafff92ac2786af5408 config/roles/databaseserver/role.py b632321de63c331b3b3d0445d134fe1626e9944c src/rolekit/dbus_utils.py fb21cec2681f60ec2ad30372c4caf285e8ba13a7 src/rolekit/server/rolebase.py d53c745352183944e307cca5259a58f058f81e27 Diff: http://reviewboard-fedoraserver.rhcloud.com/r/54/diff/ Testing ------- starting/stopping postgres through d-feet. Thanks, Miloslav Trmac

1 10

Review Request 65: Add an async.async_subprocess_future helper.
by Stephen Gallagher 19 Aug '14

19 Aug '14

----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-fedoraserver.rhcloud.com/r/65/ ----------------------------------------------------------- Review request for RoleKit Mailing List, Miloslav Trmac, Stephen Gallagher, and Thomas Woerner. Repository: rolekit Description ------- This uses the GLib mainloop infrastructure for polling. Also establishes a _future naming suffix for functions that return futures. Diffs ----- src/rolekit/async.py 1e2b82eab5a4e6862594672f738c1935a83c2be5 tests/async_test.py 47a54ed408657e67e797d50d7c73d9a7982bcfc3 Diff: http://reviewboard-fedoraserver.rhcloud.com/r/65/diff/ Testing ------- Thanks, Miloslav Trmac

1 7

Review Request 70: Change async naming conventions.
by Stephen Gallagher 19 Aug '14

19 Aug '14

----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-fedoraserver.rhcloud.com/r/70/ ----------------------------------------------------------- Review request for RoleKit Mailing List, Miloslav Trmac, Stephen Gallagher, and Thomas Woerner. Repository: rolekit Description ------- Establish a _future suffix convention for functions returning futures. Drop async_ from names of all functions within the async module as unnecessarily redundant. To avoid confusion, document that this module should always be used as “async.function_name” (i.e. each time referring to the async nature of the functionality). Hence, also replace __all__ because it is a maintenance burden, and only useful for “from async import *”, which we actively want to break rather than support. Diffs ----- src/rolekit/async.py 0a820c383d89fd6e8a6df22968cf7bae06228b14 src/rolekit/server/dbusrole.py fdf8632b9febbe0a3a358428d065d0d63dda8777 src/rolekit/server/decorators.py 6ea1ba1e5eaad99c58b8618c4386fd2ee967619c src/rolekit/server/rolebase.py a54a3b61b107775140a944a94bedd2dd0fa4ec81 tests/async_test.py 47a54ed408657e67e797d50d7c73d9a7982bcfc3 Diff: http://reviewboard-fedoraserver.rhcloud.com/r/70/diff/ Testing ------- Thanks, Miloslav Trmac

1 2

Review Request 56: Convert exceptions in D-Bus methods as if by @dbus_handle_exceptions.
by Stephen Gallagher 19 Aug '14

19 Aug '14

----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-fedoraserver.rhcloud.com/r/56/ ----------------------------------------------------------- Review request for RoleKit Mailing List, Stephen Gallagher and Thomas Woerner. Repository: rolekit Description ------- This really does call for a decorator that allows us to just say @dbus_service_method_async def deploy_async(..., no_handlers_here): yield None but that’s for later. Diffs ----- src/rolekit/async.py 1e2b82eab5a4e6862594672f738c1935a83c2be5 src/rolekit/server/dbusrole.py 8a13ccccbb0c9d2940f485697d9d2ef644183b15 src/rolekit/server/decorators.py a0c8cf4a86a7391843c33b98e344532b564868e5 src/rolekit/server/rolebase.py d53c745352183944e307cca5259a58f058f81e27 Diff: http://reviewboard-fedoraserver.rhcloud.com/r/56/diff/ Testing ------- Thanks, Miloslav Trmac

1 3

Review Request 62: Add asynchronous helper for calling a subprocess
by Stephen Gallagher 19 Aug '14

19 Aug '14

----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-fedoraserver.rhcloud.com/r/62/ ----------------------------------------------------------- Review request for RoleKit Mailing List, Miloslav Trmac, Stephen Gallagher, and Thomas Woerner. Repository: rolekit Description ------- This will spawn a thread to monitor the subprocess, capture both stdout and stderr and throw an exception if the process terminates with a non-zero error code. Diffs ----- src/rolekit/async.py 1e2b82eab5a4e6862594672f738c1935a83c2be5 Diff: http://reviewboard-fedoraserver.rhcloud.com/r/62/diff/ Testing ------- Manual testing was done by having it call a script that slept for 30s and verifying that other requests could be successfully made to rolekit while it was waiting. This code probably needs a unit test, but I haven't written it yet. Thanks, Stephen Gallagher

1 10

Review Request 67: Missing resetError method for instances
by Stephen Gallagher 18 Aug '14

18 Aug '14

----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-fedoraserver.rhcloud.com/r/67/ ----------------------------------------------------------- Review request for RoleKit Mailing List, Miloslav Trmac, Stephen Gallagher, and Thomas Woerner. Repository: rolekit Description ------- Adds resetError to RoleBase and reset-error to rolectl Diffs ----- src/rolectl d99deab3d054579488551dd6cd61615f919bd018 src/rolekit/client.py f56405183f14bfab29dea6d77ae958ece2775761 src/rolekit/server/rolebase.py 8591f8aade76d3463647c59b43cc83877698182d Diff: http://reviewboard-fedoraserver.rhcloud.com/r/67/diff/ Testing ------- Thanks, Thomas Woerner

1 3

Review Request 68: Better message for INVALID_STATE error
by Stephen Gallagher 18 Aug '14

18 Aug '14

----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-fedoraserver.rhcloud.com/r/68/ ----------------------------------------------------------- Review request for RoleKit Mailing List, Miloslav Trmac, Stephen Gallagher, and Thomas Woerner. Repository: rolekit Description ------- Better message for INVALID_STATE error Diffs ----- src/rolekit/server/rolebase.py 8591f8aade76d3463647c59b43cc83877698182d Diff: http://reviewboard-fedoraserver.rhcloud.com/r/68/diff/ Testing ------- Thanks, Thomas Woerner

1 3

Review Request 64: Use "@VERSION@" for ROLEKIT_VERSION
by Stephen Gallagher 13 Aug '14

13 Aug '14

----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-fedoraserver.rhcloud.com/r/64/ ----------------------------------------------------------- Review request for RoleKit Mailing List, Miloslav Trmac, Stephen Gallagher, and Thomas Woerner. Repository: rolekit Description ------- With this change the proper version of rolekit is used in the D-Bus interface. Diffs ----- src/rolekit/config/__init__.py.in 72d403e2f51a5b1b5fe44d178a72b52468423bca Diff: http://reviewboard-fedoraserver.rhcloud.com/r/64/diff/ Testing ------- Thanks, Thomas Woerner

1 3

Review Request 61: Fix minor typo in async_test
by Stephen Gallagher 04 Aug '14

04 Aug '14

----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-fedoraserver.rhcloud.com/r/61/ ----------------------------------------------------------- Review request for RoleKit Mailing List, Miloslav Trmac, Stephen Gallagher, and Thomas Woerner. Repository: rolekit Description ------- Fix minor typo in async_test Diffs ----- tests/async_test.py 98eaa931a5af3ff11cf64d35d8f8855c67937fbd Diff: http://reviewboard-fedoraserver.rhcloud.com/r/61/diff/ Testing ------- Thanks, Stephen Gallagher

1 1

Review Request 60: Make auto-termination working within RoleBase and DBusRole also
by Stephen Gallagher 01 Aug '14

01 Aug '14

----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-fedoraserver.rhcloud.com/r/60/ ----------------------------------------------------------- Review request for RoleKit Mailing List, Miloslav Trmac, Stephen Gallagher, and Thomas Woerner. Repository: rolekit Description ------- Make auto-termination working within RoleBase and DBusRole also Diffs ----- src/rolekit/server/dbusrole.py 5a70df48b8dbce4e49b6ec02e731ede9ab31b7f6 src/rolekit/server/rolebase.py d53c745352183944e307cca5259a58f058f81e27 Diff: http://reviewboard-fedoraserver.rhcloud.com/r/60/diff/ Testing ------- Thanks, Thomas Woerner

1 4

Review Request 59: Set persistent flag for instances also
by Stephen Gallagher 01 Aug '14

01 Aug '14

----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-fedoraserver.rhcloud.com/r/59/ ----------------------------------------------------------- Review request for RoleKit Mailing List, Miloslav Trmac, Stephen Gallagher, and Thomas Woerner. Repository: rolekit Description ------- Set persistent flag for instances also Diffs ----- src/rolekit/server/dbusrole.py 5a70df48b8dbce4e49b6ec02e731ede9ab31b7f6 Diff: http://reviewboard-fedoraserver.rhcloud.com/r/59/diff/ Testing ------- Thanks, Thomas Woerner

1 3

Review Request 47: RFC: RoleBase.deploy_async: Drop redundant comments
by Stephen Gallagher 01 Aug '14

01 Aug '14

----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-fedoraserver.rhcloud.com/r/47/ ----------------------------------------------------------- Review request for RoleKit Mailing List, Stephen Gallagher and Thomas Woerner. Repository: rolekit Description ------- Comments to the tune of # Check values self.check_values(values) IMHO only make the code less readable. Drop them. Diffs ----- src/rolekit/server/rolebase.py b72071da1b0570f93dd31841747d0ea6967262da Diff: http://reviewboard-fedoraserver.rhcloud.com/r/47/diff/ Testing ------- Thanks, Miloslav Trmac

1 6

Review Request 52: Add d-bus service file to the RPM spec
by Stephen Gallagher 01 Aug '14

01 Aug '14

----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-fedoraserver.rhcloud.com/r/52/ ----------------------------------------------------------- Review request for RoleKit Mailing List, Stephen Gallagher and Thomas Woerner. Repository: rolekit Description ------- Add d-bus service file to the RPM spec Diffs ----- rolekit.spec d1e88dc210fcd40534f21393d7fb27c9eec8c5e5 Diff: http://reviewboard-fedoraserver.rhcloud.com/r/52/diff/ Testing ------- Thanks, Stephen Gallagher

1 2

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

rolekit-commits August 2014