rolekit-commits September 2015

rolekit-commits@lists.stg.fedorahosted.org

1 participants
24 discussions

Start a nNew thread

Review Request 222: New instance name check
by Stephen Gallagher 28 Sep '15

28 Sep '15

1 6

Review Request 219: obviate the need to restore config files from backups
by Stephen Gallagher 25 Sep '15

25 Sep '15

----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-fedoraserver.rhcloud.com/r/219/ ----------------------------------------------------------- Review request for RoleKit Mailing List, Miloslav Trmac, Nils Philippsen, Stephen Gallagher, and Thomas Woerner. Repository: rolekit Description ------- Use an internal implementation instead of calling sed to tweak configuration files. This has the neat side effect of overwriting the target file as the last step, side-stepping the need to copy over the backup file on errors. This change requires python3-slip >= 0.6.4 because in previous versions slip.util.files.overwrite_safely() doesn't preserve file ownership, and the postgresql configuration files need to be owned by the postgres user. https://github.com/libre-server/rolekit/issues/21 Diffs ----- config/roles/databaseserver/role.py 7443979ba7ff87ff6a018ac8a7a0a89e2b8ad6e7 rolekit.spec f3cf9f4b799909bc293f4e56eea78c71e7112e9c Diff: http://reviewboard-fedoraserver.rhcloud.com/r/219/diff/ Testing ------- Deployed `databaseserver` role, compared contents of `postgresql.conf`, `pg_hba.conf` with what the original sed commands produced. Thanks, Nils Philippsen

1 11

Review Request 220: clean up imports
by Stephen Gallagher 25 Sep '15

25 Sep '15

----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-fedoraserver.rhcloud.com/r/220/ ----------------------------------------------------------- Review request for RoleKit Mailing List, Miloslav Trmac, Nils Philippsen, Stephen Gallagher, and Thomas Woerner. Repository: rolekit Description ------- Import specific names rather than wildcards. Remove unnecessary imports. Diffs ----- config/roles/databaseserver/role.py 7443979ba7ff87ff6a018ac8a7a0a89e2b8ad6e7 config/roles/domaincontroller/role.py 899a5aa99bfd4b7311db7bb0bba5adcf1740ab86 config/roles/memcache/role.py c2d82c19e80b553fc7f2223e99a06a1b4e02355b config/roles/testrole/role.py a592fbba02a385610bc9180bce8e7d3fb3553660 doc/examples/emptyrole/role.py d6207fbdc94f11aa0de243e51de259dd2e552a5a src/rolectl 9d8394628ea142788aef20d10a53dbdf5c092567 src/roled 52c48f1e081f3228de4f0f552d8e5c24fd1aaac4 src/rolekit/client.py c90c0aaf091c1026c2341b76be05d69ebff9e200 src/rolekit/server/dbusrole.py 3c0dff6a186d36711200074cd8e7530ee66ff64b src/rolekit/server/decorators.py 8a5aed76f31d35a8c22d548ebc4804e7259a6ef2 src/rolekit/server/io/rolesettings.py 5b3bd595b0fb04f960c2de2c10c4882979320857 src/rolekit/server/rolebase.py ba127afd018c26d2b1b5d9ffc30e960bf2ed1116 src/rolekit/server/roled.py 5dcfd99ded48db0304b752508d83bfbdcc82123d src/rolekit/server/server.py 7e400822ec238f9f9bcffd4386eaf1fcd5b8cd94 Diff: http://reviewboard-fedoraserver.rhcloud.com/r/220/diff/ Testing ------- Successfully deployed and decommissioned `databaseserver`, `memcache` and `domaincontroller`. Thanks, Nils Philippsen

1 2

Review Request 221: remove or use unused exceptions and variables
by Stephen Gallagher 25 Sep '15

25 Sep '15

1 3

Review Request 217: Fix incorrect indentation
by Stephen Gallagher 22 Sep '15

22 Sep '15

1 2

Review Request 218: Set the role state to ERROR if in a transitional state on startup
by Stephen Gallagher 22 Sep '15

22 Sep '15

1 2

Review Request 212: clean up extension unit files on decommission
by Stephen Gallagher 16 Sep '15

16 Sep '15

1 10

Review Request 214: don't write extension unit files multiple times
by Stephen Gallagher 16 Sep '15

16 Sep '15

----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-fedoraserver.rhcloud.com/r/214/ ----------------------------------------------------------- Review request for RoleKit Mailing List, Miloslav Trmac, Nils Philippsen, Stephen Gallagher, and Thomas Woerner. Repository: rolekit Description ------- Before, units that are used for more than one dependency type get written multiple times, and so create useless backup files (and potentially overwrite legit ones). Diffs ----- src/rolekit/server/rolebase.py 55add0077016c92eff2c9699b13e5c7d6026e574 Diff: http://reviewboard-fedoraserver.rhcloud.com/r/214/diff/ Testing ------- [root@vagrant ~]# echo '{"database": "example"}' | rolectl deploy databaseserver --settings-stdin Deployment can take a long time. To monitor the progress, run journalctl -ef -u rolekit success [root@vagrant ~]# find /etc/systemd/ -name role-\* /etc/systemd/system/role-fail-databaseserver-1.service /etc/systemd/system/postgresql.service.d/role-databaseserver-1.target.conf /etc/systemd/system/multi-user.target.wants/role-databaseserver-1.target /etc/systemd/system/syslog.target.d/role-databaseserver-1.target.conf /etc/systemd/system/role-databaseserver-1.target /etc/systemd/system/network.target.d/role-databaseserver-1.target.conf [root@vagrant ~]# --> no `*.old` files Thanks, Nils Philippsen

1 4

Review Request 215: remove 'pass' statements from non-empty blocks
by Stephen Gallagher 16 Sep '15

16 Sep '15

1 5

Review Request 216: clean up target and failure unit files on cleanup, too
by Stephen Gallagher 16 Sep '15

16 Sep '15

1 4

2026

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

rolekit-commits September 2015