rolekit-commits June 2016

rolekit-commits@lists.stg.fedorahosted.org

1 participants
1 discussions

Review Request 245: Domain Controller: Don't require both forwarders
by Stephen Gallagher 03 Jun '16

03 Jun '16

----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-fedoraserver.rhcloud.com/r/245/ ----------------------------------------------------------- Review request for RoleKit Mailing List, Miloslav Trmac, Nils Philippsen, Stephen Gallagher, and Thomas Woerner. Repository: rolekit Description ------- When specifying forwarders for the domain controller, we were checking that both the IPv4 and IPv6 forwarders are present, but we actually only strictly need one or the other (and many environments don't even have both). Change it so that we check for at least one instead. Fixes https://github.com/libre-server/rolekit/issues/64 Diffs ----- config/roles/domaincontroller/role.py 094a2e3feb7a5d39383f3d20e93aad7849ed8e1b Diff: http://reviewboard-fedoraserver.rhcloud.com/r/245/diff/ Testing ------- Tested deployment of a domain controller with only a single IPv4 address. Thanks, Stephen Gallagher

1 1

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

rolekit-commits June 2016