----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-fedoraserver.rhcloud.com/r/54/#review233 -----------------------------------------------------------
Ship it!
Ship It!
- Stephen Gallagher
On Aug. 19, 2014, 7:27 p.m., Miloslav Trmac wrote:
This is an automatically generated e-mail. To reply, visit: http://reviewboard-fedoraserver.rhcloud.com/r/54/
(Updated Aug. 19, 2014, 7:27 p.m.)
Review request for RoleKit Mailing List, Stephen Gallagher and Thomas Woerner.
Repository: rolekit
Description
Implement starting and stopping services, and use it in databaseserver.
Includes some work-in-progress edits to databaseserver, IMHO harmless enough but will split them if asked.
Now rereading this, should the StartUnit/StopUnit D-Bus calls be non-blocking as well? At this late hour I’m inclined to say that they are explicitly designed to be returning quickly, so it isn’t really necessary.
Diffs
TODO 90fcb3f668aa382f0317092a25d794d37e012b23 config/roles/databaseserver/role.py 358deca3fc7172929d53d2c77efd5c919da2aea9 src/rolekit/dbus_utils.py fb21cec2681f60ec2ad30372c4caf285e8ba13a7 src/rolekit/server/rolebase.py a54a3b61b107775140a944a94bedd2dd0fa4ec81
Diff: http://reviewboard-fedoraserver.rhcloud.com/r/54/diff/
Testing
starting/stopping postgres through d-feet.
Thanks,
Miloslav Trmac