----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-fedoraserver.rhcloud.com/r/79/#review275 -----------------------------------------------------------
Ship it!
Ship It!
- Stephen Gallagher
On Sept. 10, 2014, 6:02 p.m., Thomas Woerner wrote:
This is an automatically generated e-mail. To reply, visit: http://reviewboard-fedoraserver.rhcloud.com/r/79/
(Updated Sept. 10, 2014, 6:02 p.m.)
Review request for RoleKit Mailing List, Miloslav Trmac, Stephen Gallagher, and Thomas Woerner.
Repository: rolekit
Description
- New option --settings-file: store all settings in a json file.
- Dropped --set option for --settings-file. Values like arrays or dicts have been very user unfriedly with the --set option.
- The redeploy option was additionally not functional
Fixes https://fedorahosted.org/rolekit/ticket/8 Fixes https://fedorahosted.org/rolekit/ticket/9
Diffs
src/rolectl e686b8858e3ea3b96c82bcf6d1a16e5bd27314a6
Diff: http://reviewboard-fedoraserver.rhcloud.com/r/79/diff/
Testing
Thanks,
Thomas Woerner