----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-fedoraserver.rhcloud.com/r/55/#review191 -----------------------------------------------------------
src/rolekit/server/dbusrole.py http://reviewboard-fedoraserver.rhcloud.com/r/55/#comment106
What does “private” mean in this context BTW? It's obviously neither class-private nor file-private.
src/rolekit/server/dbusrole.py http://reviewboard-fedoraserver.rhcloud.com/r/55/#comment105
No. Logging and ignoring exceptions deep within the call stack, and returning None from functions that are not documented to return None, is not a reasonable error handling strategy.
(I’m not working on fixing the other places, but let’s not spread this any further.)
src/rolekit/server/roled.py http://reviewboard-fedoraserver.rhcloud.com/r/55/#comment107
This kind of suggests that ._roles should be a dictionary instead… but that’s for another time.
- Miloslav Trmac
On Čec. 30, 2014, 5:33 odp., Thomas Woerner wrote:
This is an automatically generated e-mail. To reply, visit: http://reviewboard-fedoraserver.rhcloud.com/r/55/
(Updated Čec. 30, 2014, 5:33 odp.)
Review request for RoleKit Mailing List, Stephen Gallagher and Thomas Woerner.
Repository: rolekit
Description
Fixes https://fedorahosted.org/rolekit/ticket/3
Diffs
src/rolekit/server/dbusrole.py 8a13ccccbb0c9d2940f485697d9d2ef644183b15 src/rolekit/server/roled.py 59d1523347325b20d666c99d8c2087c8ce486608
Diff: http://reviewboard-fedoraserver.rhcloud.com/r/55/diff/
Testing
Thanks,
Thomas Woerner