This is an automatically generated e-mail. To reply, visit: http://reviewboard-fedoraserver.rhcloud.com/r/54/

On srpen 19th, 2014, 9:36 odp. CEST, Stephen Gallagher wrote:

Ship It!
https://git.fedorahosted.org/cgit/rolekit.git/commit/?id=ac05751659b8272aa1cc71f2066adc170658de39

- Miloslav


On srpen 19th, 2014, 9:41 odp. CEST, Miloslav Trmac wrote:

Review request for RoleKit Mailing List, Stephen Gallagher and Thomas Woerner.
By Miloslav Trmac.

Updated Srp. 19, 2014, 9:41 odp.

Repository: rolekit

Description 

Implement starting and stopping services, and use it in databaseserver.


Includes some work-in-progress edits to databaseserver, IMHO harmless enough but will split them if asked.


Now rereading this, should the StartUnit/StopUnit D-Bus calls be non-blocking as well?  At this late hour I’m inclined to say that they are explicitly designed to be returning quickly, so it isn’t really necessary.

Testing 

starting/stopping postgres through d-feet.

Diffs

  • TODO (90fcb3f668aa382f0317092a25d794d37e012b23)
  • config/roles/databaseserver/role.py (358deca3fc7172929d53d2c77efd5c919da2aea9)
  • src/rolekit/dbus_utils.py (fb21cec2681f60ec2ad30372c4caf285e8ba13a7)
  • src/rolekit/server/rolebase.py (a54a3b61b107775140a944a94bedd2dd0fa4ec81)

View Diff