On Čec. 31, 2014, 4:44 odp., Miloslav Trmac wrote:
src/rolekit/server/dbusrole.py, line 209 http://reviewboard-fedoraserver.rhcloud.com/r/55/diff/1/?file=238#file238line209
No. Logging and ignoring exceptions deep within the call stack, and returning None from functions that are not documented to return None, is not a reasonable error handling strategy. (I’m not working on fixing the other places, but let’s not spread this any further.)
And AFAICT it is completely unnecessary as well; this method just can’t fail.
- Miloslav
----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-fedoraserver.rhcloud.com/r/55/#review191 -----------------------------------------------------------
On Čec. 30, 2014, 5:33 odp., Thomas Woerner wrote:
This is an automatically generated e-mail. To reply, visit: http://reviewboard-fedoraserver.rhcloud.com/r/55/
(Updated Čec. 30, 2014, 5:33 odp.)
Review request for RoleKit Mailing List, Stephen Gallagher and Thomas Woerner.
Repository: rolekit
Description
Fixes https://fedorahosted.org/rolekit/ticket/3
Diffs
src/rolekit/server/dbusrole.py 8a13ccccbb0c9d2940f485697d9d2ef644183b15 src/rolekit/server/roled.py 59d1523347325b20d666c99d8c2087c8ce486608
Diff: http://reviewboard-fedoraserver.rhcloud.com/r/55/diff/
Testing
Thanks,
Thomas Woerner