This is an automatically generated e-mail. To reply, visit: http://reviewboard-fedoraserver.rhcloud.com/r/245/

Review request for RoleKit Mailing List, Miloslav Trmac, Nils Philippsen, Stephen Gallagher, and Thomas Woerner.
By Stephen Gallagher.

Updated June 3, 2016, 2:40 p.m.

Changes

Tweaked the check for IPv4 and IPv6 presence in the dictionary.

Repository: rolekit

Description

When specifying forwarders for the domain controller, we were checking
that both the IPv4 and IPv6 forwarders are present, but we actually
only strictly need one or the other (and many environments don't even
have both). Change it so that we check for at least one instead.

Fixes https://github.com/libre-server/rolekit/issues/64

Testing

Tested deployment of a domain controller with only a single IPv4 address.

Diffs (updated)

  • config/roles/domaincontroller/role.py (094a2e3feb7a5d39383f3d20e93aad7849ed8e1b)

View Diff