----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-fedoraserver.rhcloud.com/r/101/#review327 -----------------------------------------------------------

1) Remove empty SYNOPSIS by dropping <refsynopsisdiv> </refsynopsisdiv>

2) Make settings name more visible by using <command>...</command> in <varlistentry><term>...</term>

3) Do not indent in <programlisting> to the XML indentent level, this will move the programlisting content far to the right in man pages.

4) Please do not use expressions like "Default: Autodetected from the machine hostname." Better: "Default: unset. Autodetected from the machine hostname."

- Thomas Woerner

On Oct. 17, 2014, 8:48 p.m., Stephen Gallagher wrote:

---

This is an automatically generated e-mail. To reply, visit: http://reviewboard-fedoraserver.rhcloud.com/r/101/

---

(Updated Oct. 17, 2014, 8:48 p.m.)

Review request for RoleKit Mailing List, Miloslav Trmac, Stephen Gallagher, and Thomas Woerner.

Repository: rolekit

Description

Add manual page for Domain Controller role

I didn't create a manual page entry for the ca_file option yet, as it's stubbed out and useless in the code right now. I'll add it to the manual once that gets fixed.

Diffs

doc/xml/Makefile.am 4f0661d6cd5086ae4cc966f17c0ba627db31c10b doc/xml/rolekit.roles.domaincontroller.xml PRE-CREATION doc/xml/seealso.xml 26bafed10f4f3040c56849e7f2299a5fb77da101

Diff: http://reviewboard-fedoraserver.rhcloud.com/r/101/diff/

Testing

I built the manpages with 'make update-docs' and then examined them.

Thanks,

Stephen Gallagher