----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-fedoraserver.rhcloud.com/r/241/#review575 -----------------------------------------------------------

Ship It!

- Nils Philippsen

On Dez. 22, 2015, 6:16 nachm., Stephen Gallagher wrote:

---

This is an automatically generated e-mail. To reply, visit: http://reviewboard-fedoraserver.rhcloud.com/r/241/

---

(Updated Dez. 22, 2015, 6:16 nachm.)

Review request for RoleKit Mailing List, Miloslav Trmac, Nils Philippsen, Stephen Gallagher, and Thomas Woerner.

Repository: rolekit

Description

If we disable the units before we call stop(), then the RequiredBy linkage is already removed. This means that any unit that should be controlled by the role-*.target won't actually be sent the stop() command.

The correct thing to do here is to stop the role unit first, then disable it.

Diffs

src/rolekit/server/rolebase.py e573f56ae52a3447ce3c953f22f2d8f495de692a

Diff: http://reviewboard-fedoraserver.rhcloud.com/r/241/diff/

Testing

Thanks,

Stephen Gallagher