----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-fedoraserver.rhcloud.com/r/56/#review226 -----------------------------------------------------------

Ship it!

Looks good to me. Clean up the minor nitpick below and submit it.

src/rolekit/async.py http://reviewboard-fedoraserver.rhcloud.com/r/56/#comment132

You added excess whitespace here. No need to resubmit for review, just clean it before pushing, please.

- Stephen Gallagher

On July 31, 2014, 4:31 p.m., Miloslav Trmac wrote:

---

This is an automatically generated e-mail. To reply, visit: http://reviewboard-fedoraserver.rhcloud.com/r/56/

---

(Updated July 31, 2014, 4:31 p.m.)

Review request for RoleKit Mailing List, Stephen Gallagher and Thomas Woerner.

Repository: rolekit

Description

This really does call for a decorator that allows us to just say

@dbus_service_method_async def deploy_async(..., no_handlers_here): yield None

but that’s for later.

Diffs

src/rolekit/async.py 1e2b82eab5a4e6862594672f738c1935a83c2be5 src/rolekit/server/dbusrole.py 8a13ccccbb0c9d2940f485697d9d2ef644183b15 src/rolekit/server/decorators.py a0c8cf4a86a7391843c33b98e344532b564868e5 src/rolekit/server/rolebase.py d53c745352183944e307cca5259a58f058f81e27

Diff: http://reviewboard-fedoraserver.rhcloud.com/r/56/diff/

Testing

Thanks,

Miloslav Trmac

----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-fedoraserver.rhcloud.com/r/56/ -----------------------------------------------------------

(Updated Srp. 19, 2014, 4:34 odp.)

Status ------

This change has been marked as submitted.

Review request for RoleKit Mailing List, Stephen Gallagher and Thomas Woerner.

Repository: rolekit

Description -------

This really does call for a decorator that allows us to just say

@dbus_service_method_async def deploy_async(..., no_handlers_here): yield None

but that’s for later.

Diffs -----

src/rolekit/async.py 1e2b82eab5a4e6862594672f738c1935a83c2be5 src/rolekit/server/dbusrole.py 8a13ccccbb0c9d2940f485697d9d2ef644183b15 src/rolekit/server/decorators.py a0c8cf4a86a7391843c33b98e344532b564868e5 src/rolekit/server/rolebase.py d53c745352183944e307cca5259a58f058f81e27

Diff: http://reviewboard-fedoraserver.rhcloud.com/r/56/diff/

Testing -------

Thanks,

Miloslav Trmac