----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://fedorahosted.org/reviewboard/r/310/ -----------------------------------------------------------
Review request for rolekit reviewers, Stephen Gallagher and Thomas Woerner.
Repository: rolekit
Description -------
- Added missing imports for dbus type conversion and possible method calls - Dropped "backup_paths" setting from _DEFAULS - Added own setting "myownsetting" altogether with an extended get_dbus_property method - Added not covered "failonthis" setting to show error message in the log with get_dbus_property calls
Diffs -----
config/roles/testrole/role.py 5a47874456eaa3a1de5793b86e96f7c01a6d641d
Diff: https://fedorahosted.org/reviewboard/r/310/diff/
Testing -------
Thanks,
Thomas Woerner
----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://fedorahosted.org/reviewboard/r/310/#review499 -----------------------------------------------------------
Ship it!
Ship It!
- Stephen Gallagher
On July 11, 2014, 12:22 p.m., Thomas Woerner wrote:
This is an automatically generated e-mail. To reply, visit: https://fedorahosted.org/reviewboard/r/310/
(Updated July 11, 2014, 12:22 p.m.)
Review request for rolekit reviewers, Stephen Gallagher and Thomas Woerner.
Repository: rolekit
Description
- Added missing imports for dbus type conversion and possible method calls
- Dropped "backup_paths" setting from _DEFAULS
- Added own setting "myownsetting" altogether with an extended get_dbus_property method
- Added not covered "failonthis" setting to show error message in the log with get_dbus_property calls
Diffs
config/roles/testrole/role.py 5a47874456eaa3a1de5793b86e96f7c01a6d641d
Diff: https://fedorahosted.org/reviewboard/r/310/diff/
Testing
Thanks,
Thomas Woerner
On July 11, 2014, 6:47 p.m., Stephen Gallagher wrote:
Ship It!
Pushed: https://git.fedorahosted.org/cgit/rolekit.git/commit/?id=3104b988f5d50a614c2...
- Thomas
----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://fedorahosted.org/reviewboard/r/310/#review499 -----------------------------------------------------------
On July 11, 2014, 6:22 p.m., Thomas Woerner wrote:
This is an automatically generated e-mail. To reply, visit: https://fedorahosted.org/reviewboard/r/310/
(Updated July 11, 2014, 6:22 p.m.)
Review request for rolekit reviewers, Stephen Gallagher and Thomas Woerner.
Repository: rolekit
Description
- Added missing imports for dbus type conversion and possible method calls
- Dropped "backup_paths" setting from _DEFAULS
- Added own setting "myownsetting" altogether with an extended get_dbus_property method
- Added not covered "failonthis" setting to show error message in the log with get_dbus_property calls
Diffs
config/roles/testrole/role.py 5a47874456eaa3a1de5793b86e96f7c01a6d641d
Diff: https://fedorahosted.org/reviewboard/r/310/diff/
Testing
Thanks,
Thomas Woerner
rolekit-commits@lists.stg.fedorahosted.org